public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] CI: Remove KFAIL for Bookworm
Date: Tue, 18 Jul 2023 14:55:11 +0200	[thread overview]
Message-ID: <20230718145511.003d34f3@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20230718113615.854531-1-amikan@ilbers.de>

Am Tue, 18 Jul 2023 14:36:15 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> Debian Bookworm is stable now, so it should always pass all the tests.
> Remove all the KFAIL protection from Bookworm targets.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 38 +++++++++-----------------------------
>  1 file changed, 9 insertions(+), 29 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 34258452..0d30b883 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -127,7 +127,9 @@ class CrossTest(CIBaseTest):
>              'mc:qemuarm-buster:isar-image-ci',
>              'mc:qemuarm-bullseye:isar-image-ci',
>              'mc:de0-nano-soc-bullseye:isar-image-base',
> -            'mc:stm32mp15x-bullseye:isar-image-base'
> +            'mc:stm32mp15x-bullseye:isar-image-base',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemuarm64-bookworm:isar-image-ci'
>                    ]
>  
>          self.init()
> @@ -155,18 +157,6 @@ class CrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_cross_bookworm(self):
> -        targets = [
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets)
> -        except:
> -            self.cancel('KFAIL')
> -
>  class WicTest(CIBaseTest):
>  
>      """
> @@ -216,7 +206,12 @@ class NoCrossTest(CIBaseTest):
>              'mc:nanopi-neo-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:stm32mp15x-initramfs',
> -            'mc:qemuamd64-focal:isar-image-ci'
> +            'mc:qemuamd64-focal:isar-image-ci',
> +            'mc:qemuamd64-bookworm:isar-image-ci',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemui386-bookworm:isar-image-base',
> +            'mc:qemumipsel-bookworm:isar-image-ci',
> +            'mc:hikey-bookworm:isar-image-base'

i would suggest to end that last line with a , so it never matters
which one is the last and adding more does not have to touch this again

Henning

>                    ]
>  
>          self.init()
> @@ -238,21 +233,6 @@ class NoCrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_nocross_bookworm(self):
> -        targets = [
> -            'mc:qemuamd64-bookworm:isar-image-ci',
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemui386-bookworm:isar-image-base',
> -            'mc:qemumipsel-bookworm:isar-image-ci',
> -            'mc:hikey-bookworm:isar-image-base'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets, cross=False)
> -        except:
> -            self.cancel('KFAIL')
> -
>      def test_nocross_trixie(self):
>          targets = [
>              'mc:qemuamd64-trixie:isar-image-ci',


  reply	other threads:[~2023-07-18 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 11:36 Anton Mikanovich
2023-07-18 12:55 ` Henning Schild [this message]
2023-08-02  4:07 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718145511.003d34f3@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox