* [PATCH] CI: End the last target with comma
@ 2023-07-19 10:22 Anton Mikanovich
2023-07-19 10:24 ` Anton Mikanovich
2023-08-02 4:07 ` Uladzimir Bely
0 siblings, 2 replies; 4+ messages in thread
From: Anton Mikanovich @ 2023-07-19 10:22 UTC (permalink / raw)
To: isar-users; +Cc: Anton Mikanovich
Add commas to the last target in the list for better maintainability.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
testsuite/citest.py | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/testsuite/citest.py b/testsuite/citest.py
index c706abe0..8253bd52 100755
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -29,7 +29,7 @@ class DevTest(CIBaseTest):
'mc:qemuamd64-bullseye:isar-image-ci',
'mc:qemuarm-bullseye:isar-image-base',
'mc:qemuarm-bullseye:isar-image-base:do_populate_sdk',
- 'mc:qemuarm64-bullseye:isar-image-base'
+ 'mc:qemuarm64-bullseye:isar-image-base',
]
self.init()
@@ -38,7 +38,7 @@ class DevTest(CIBaseTest):
def test_dev_apps(self):
targets = [
'mc:qemuamd64-bullseye:isar-image-ci',
- 'mc:qemuarm64-bullseye:isar-image-base'
+ 'mc:qemuarm64-bullseye:isar-image-base',
]
self.init()
@@ -82,7 +82,7 @@ class ReproTest(CIBaseTest):
def test_repro_signed(self):
targets = [
'mc:rpi-arm-v7-bullseye:isar-image-base',
- 'mc:qemuarm64-bullseye:isar-image-base'
+ 'mc:qemuarm64-bullseye:isar-image-base',
]
self.init()
@@ -94,7 +94,7 @@ class ReproTest(CIBaseTest):
def test_repro_unsigned(self):
targets = [
'mc:qemuamd64-bullseye:isar-image-base',
- 'mc:qemuarm-bullseye:isar-image-base'
+ 'mc:qemuarm-bullseye:isar-image-base',
]
self.init()
@@ -130,7 +130,7 @@ class CrossTest(CIBaseTest):
'mc:stm32mp15x-bullseye:isar-image-base',
'mc:qemuarm-bookworm:isar-image-ci',
'mc:qemuarm64-bookworm:isar-image-ci',
- 'mc:qemuarm64-focal:isar-image-base'
+ 'mc:qemuarm64-focal:isar-image-base',
]
self.init()
@@ -138,7 +138,7 @@ class CrossTest(CIBaseTest):
def test_cross_rpi(self):
targets = [
- 'mc:rpi-arm-v7-bullseye:isar-image-base'
+ 'mc:rpi-arm-v7-bullseye:isar-image-base',
]
self.init()
@@ -201,7 +201,7 @@ class NoCrossTest(CIBaseTest):
'mc:qemuarm-bookworm:isar-image-ci',
'mc:qemui386-bookworm:isar-image-base',
'mc:qemumipsel-bookworm:isar-image-ci',
- 'mc:hikey-bookworm:isar-image-base'
+ 'mc:hikey-bookworm:isar-image-base',
]
self.init()
@@ -214,7 +214,7 @@ class NoCrossTest(CIBaseTest):
'mc:rpi-arm-bullseye:isar-image-base',
'mc:rpi-arm-v7-bullseye:isar-image-base',
'mc:rpi-arm-v7l-bullseye:isar-image-base',
- 'mc:rpi-arm64-v8-bullseye:isar-image-base'
+ 'mc:rpi-arm64-v8-bullseye:isar-image-base',
]
self.init()
@@ -227,7 +227,7 @@ class NoCrossTest(CIBaseTest):
targets = [
'mc:qemuamd64-trixie:isar-image-ci',
'mc:qemuarm64-trixie:isar-image-ci',
- 'mc:qemuarm-trixie:isar-image-ci'
+ 'mc:qemuarm-trixie:isar-image-ci',
]
self.init()
@@ -239,7 +239,7 @@ class NoCrossTest(CIBaseTest):
def test_nocross_sidports(self):
targets = [
'mc:qemuriscv64-sid-ports:isar-image-base',
- 'mc:sifive-fu540-sid-ports:isar-image-base'
+ 'mc:sifive-fu540-sid-ports:isar-image-base',
]
self.init()
@@ -260,7 +260,7 @@ class ContainerImageTest(CIBaseTest):
targets = [
'mc:container-amd64-buster:isar-image-base',
'mc:container-amd64-bullseye:isar-image-base',
- 'mc:container-amd64-bookworm:isar-image-base'
+ 'mc:container-amd64-bookworm:isar-image-base',
]
self.init()
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] CI: End the last target with comma
2023-07-19 10:22 [PATCH] CI: End the last target with comma Anton Mikanovich
@ 2023-07-19 10:24 ` Anton Mikanovich
2023-07-19 12:29 ` Henning Schild
2023-08-02 4:07 ` Uladzimir Bely
1 sibling, 1 reply; 4+ messages in thread
From: Anton Mikanovich @ 2023-07-19 10:24 UTC (permalink / raw)
To: isar-users
19/07/2023 13:22, Anton Mikanovich wrote:
> Add commas to the last target in the list for better maintainability.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
This patch is based on the following commits already on the list:
CI: Remove KFAIL for Ubuntu
CI: Remove KFAIL for Bookworm
meta: Add Debian Trixie
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CI: End the last target with comma
2023-07-19 10:24 ` Anton Mikanovich
@ 2023-07-19 12:29 ` Henning Schild
0 siblings, 0 replies; 4+ messages in thread
From: Henning Schild @ 2023-07-19 12:29 UTC (permalink / raw)
To: Anton Mikanovich; +Cc: isar-users
Am Wed, 19 Jul 2023 13:24:01 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:
> 19/07/2023 13:22, Anton Mikanovich wrote:
> > Add commas to the last target in the list for better
> > maintainability.
> >
> > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>
> This patch is based on the following commits already on the list:
>
> CI: Remove KFAIL for Ubuntu
> CI: Remove KFAIL for Bookworm
> meta: Add Debian Trixie
>
ACK, Thanks.
Henning
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CI: End the last target with comma
2023-07-19 10:22 [PATCH] CI: End the last target with comma Anton Mikanovich
2023-07-19 10:24 ` Anton Mikanovich
@ 2023-08-02 4:07 ` Uladzimir Bely
1 sibling, 0 replies; 4+ messages in thread
From: Uladzimir Bely @ 2023-08-02 4:07 UTC (permalink / raw)
To: Anton Mikanovich, isar-users
On Wed, 2023-07-19 at 13:22 +0300, Anton Mikanovich wrote:
> Add commas to the last target in the list for better maintainability.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> testsuite/citest.py | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index c706abe0..8253bd52 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -29,7 +29,7 @@ class DevTest(CIBaseTest):
> 'mc:qemuamd64-bullseye:isar-image-ci',
> 'mc:qemuarm-bullseye:isar-image-base',
> 'mc:qemuarm-bullseye:isar-image-base:do_populate_sdk',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -38,7 +38,7 @@ class DevTest(CIBaseTest):
> def test_dev_apps(self):
> targets = [
> 'mc:qemuamd64-bullseye:isar-image-ci',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -82,7 +82,7 @@ class ReproTest(CIBaseTest):
> def test_repro_signed(self):
> targets = [
> 'mc:rpi-arm-v7-bullseye:isar-image-base',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -94,7 +94,7 @@ class ReproTest(CIBaseTest):
> def test_repro_unsigned(self):
> targets = [
> 'mc:qemuamd64-bullseye:isar-image-base',
> - 'mc:qemuarm-bullseye:isar-image-base'
> + 'mc:qemuarm-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -130,7 +130,7 @@ class CrossTest(CIBaseTest):
> 'mc:stm32mp15x-bullseye:isar-image-base',
> 'mc:qemuarm-bookworm:isar-image-ci',
> 'mc:qemuarm64-bookworm:isar-image-ci',
> - 'mc:qemuarm64-focal:isar-image-base'
> + 'mc:qemuarm64-focal:isar-image-base',
> ]
>
> self.init()
> @@ -138,7 +138,7 @@ class CrossTest(CIBaseTest):
>
> def test_cross_rpi(self):
> targets = [
> - 'mc:rpi-arm-v7-bullseye:isar-image-base'
> + 'mc:rpi-arm-v7-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -201,7 +201,7 @@ class NoCrossTest(CIBaseTest):
> 'mc:qemuarm-bookworm:isar-image-ci',
> 'mc:qemui386-bookworm:isar-image-base',
> 'mc:qemumipsel-bookworm:isar-image-ci',
> - 'mc:hikey-bookworm:isar-image-base'
> + 'mc:hikey-bookworm:isar-image-base',
> ]
>
> self.init()
> @@ -214,7 +214,7 @@ class NoCrossTest(CIBaseTest):
> 'mc:rpi-arm-bullseye:isar-image-base',
> 'mc:rpi-arm-v7-bullseye:isar-image-base',
> 'mc:rpi-arm-v7l-bullseye:isar-image-base',
> - 'mc:rpi-arm64-v8-bullseye:isar-image-base'
> + 'mc:rpi-arm64-v8-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -227,7 +227,7 @@ class NoCrossTest(CIBaseTest):
> targets = [
> 'mc:qemuamd64-trixie:isar-image-ci',
> 'mc:qemuarm64-trixie:isar-image-ci',
> - 'mc:qemuarm-trixie:isar-image-ci'
> + 'mc:qemuarm-trixie:isar-image-ci',
> ]
>
> self.init()
> @@ -239,7 +239,7 @@ class NoCrossTest(CIBaseTest):
> def test_nocross_sidports(self):
> targets = [
> 'mc:qemuriscv64-sid-ports:isar-image-base',
> - 'mc:sifive-fu540-sid-ports:isar-image-base'
> + 'mc:sifive-fu540-sid-ports:isar-image-base',
> ]
>
> self.init()
> @@ -260,7 +260,7 @@ class ContainerImageTest(CIBaseTest):
> targets = [
> 'mc:container-amd64-buster:isar-image-base',
> 'mc:container-amd64-bullseye:isar-image-base',
> - 'mc:container-amd64-bookworm:isar-image-base'
> + 'mc:container-amd64-bookworm:isar-image-base',
> ]
>
> self.init()
> --
> 2.34.1
>
Applied to next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 4:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 10:22 [PATCH] CI: End the last target with comma Anton Mikanovich
2023-07-19 10:24 ` Anton Mikanovich
2023-07-19 12:29 ` Henning Schild
2023-08-02 4:07 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox