From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7259987580358230016 X-Received: by 2002:a19:915b:0:b0:4fb:73d1:58e5 with SMTP id y27-20020a19915b000000b004fb73d158e5mr500278lfj.53.1690347581721; Tue, 25 Jul 2023 21:59:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:1808:b0:51b:d432:a176 with SMTP id g8-20020a056402180800b0051bd432a176ls804694edy.2.-pod-prod-00-eu; Tue, 25 Jul 2023 21:59:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlERFDp/V0kWvzNMNsEYkvZrn59vW4DqpKY2YtVvAo2hbyC/aHeBqTcDTzAVSxKUDmfZ9ipm X-Received: by 2002:aa7:d85a:0:b0:522:4cb6:d1e3 with SMTP id f26-20020aa7d85a000000b005224cb6d1e3mr1177786eds.10.1690347579637; Tue, 25 Jul 2023 21:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690347579; cv=none; d=google.com; s=arc-20160816; b=wpMhYX02IJn33OI7NY3KznUvpYtyz+kWB9hCCsF+QG9pn8jMuHp/DpSxThXWCRMQ13 X3/j4PllFcXGktwSBYsWZZM0tkWOJdXkF1MeYaHNCr6iHKEotML6y50wr6qcmmQiVyCj g1g7sNmGmOuftLrf1Xtz0hzvZSxEVMiQSYKDWVlOmXV0plq7Apaaz8D6AWKa3Y+Og/bS y+614nSwhofNEOl6QQDgFdcXw68ZiOeos1oUV705fp06K7ODDR8IosqpgrfPEqSEOGFL 4wBK3SNiyY8+RFpOdxta1XgtaGXOaycNfomlsm8sXxI7ucPwJaBrdYJeoyZuLnvj7yxx JLfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; fh=JKAk5g9OeEpZsHSr5t9bMJhmzqtLpjZpEcjmUiZCWCM=; b=JAOV6vc0V6kG++72Dyr+sg2AfWfq4DKK7pqPCS3QYvYvB+vJt43N49v+odGcNmr6UZ ZxKUn3aap3pUTMBl6mVzcrGNlV/NhxlmFKqZa2PmlFoEDMPiLaTUOjDyXWLh1Va8x+A+ faKljcqYv2qJyJ43pcl6NUuS/hu4jC2uDT4iL4EhtfxPST21YZobB4mojiBjoSvOEGfI zv566EwemdR+z+JJIud9FUnensAOs7LQGxGW+2JUrkc8zBcULik6Iy2JIO3Mr34rBB2Z R/FbM3B0xqCDaqEnAuZFSBy8+PELnDlXdYbFXlxmhtEOrba/ShrK067RPEA/fxckxqKE xA7w== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CyJUJaww; spf=pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202307260459395a287a0960ea006cc1-Ll7yDt@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id g20-20020a056402321400b0051e6316130dsi798752eda.5.2023.07.25.21.59.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2023 21:59:39 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CyJUJaww; spf=pass (google.com: domain of fm-72506-202307260459395a287a0960ea006cc1-ll7ydt@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202307260459395a287a0960ea006cc1-Ll7yDt@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 202307260459395a287a0960ea006cc1 for ; Wed, 26 Jul 2023 06:59:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; b=CyJUJawwOBgmCYJx2C9oHrpYhWEMnLijycpDGlTC7gUPZM3nQe/721JAIyYK1Brd6t35aZ cdoWT4qcH0wRQo6/iqMw9nasg9Koth23BN6GMNspGqhcvMTRUlAdLsTQRsTFv20kD/hebg+Y QtVpvUpwMlfjM8dt7FCATkNLChB4c=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: tobias.schaffner@siemens.com, Felix Moessbauer Subject: [PATCH 1/1] fix group splitting in user creation Date: Wed, 26 Jul 2023 04:59:20 +0000 Message-Id: <20230726045920.1542471-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: 135FvjDCMGZW There is a bug when converting the USER_[groups] configuration from the bitbake format (space separated) to the format useradd expects (comma separated). We cannot simply replace spaces with commas, as then multiple spaces in a row would create multiple commas. Instead, we need to split it first into the tokens and then join these tokens by comma. Signed-off-by: Felix Moessbauer --- meta/classes/image-account-extension.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index e783c135..6f67f459 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -98,10 +98,10 @@ def image_create_users(d: "DataSmart") -> None: add_user_option("--comment", "comment") add_user_option("--shell", "shell") - groups = d.getVarFlag(user_entry, "groups") or "" + groups = (d.getVarFlag(user_entry, "groups") or "").split() if groups: args.append("--groups") - args.append(groups.replace(' ', ',')) + args.append(','.join(groups)) flags = (d.getVarFlag(user_entry, "flags") or "").split() -- 2.34.1