From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7259987580358230016 X-Received: by 2002:a2e:7d0f:0:b0:2b8:67ce:4ad7 with SMTP id y15-20020a2e7d0f000000b002b867ce4ad7mr627980ljc.6.1690428278211; Wed, 26 Jul 2023 20:24:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:c85:b0:2b9:57fb:fcf1 with SMTP id bz5-20020a05651c0c8500b002b957fbfcf1ls153648ljb.1.-pod-prod-05-eu; Wed, 26 Jul 2023 20:24:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlGLZlvmWKm9a51ZG+kv1gFH6x3SU0uA/sGuwH6NjSiddeOrTHgps+aKp5V/ZNiHAV1gctui X-Received: by 2002:ac2:58d4:0:b0:4fe:95e:159a with SMTP id u20-20020ac258d4000000b004fe095e159amr600186lfo.23.1690428276052; Wed, 26 Jul 2023 20:24:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690428276; cv=none; d=google.com; s=arc-20160816; b=eu1apGetWMXgDQgdU/4YhmBbYtGBP+zj+z1iL5wHXcAwOJGAIHJZt0roF+5m337jWQ QrOdhSw0dDbybXDg9VTd8f5lJwIXhKjlqEfG2KzlbGtkq2eeBYbrZAV6QB9/HqLIBDnC CczK8fNg/40IE2FELltMpsSWKRULCH8LVyB2JJ/6ODRgVVmzksSiiSMTXImrm5K7Qnu3 PorN/Epcvd4/IejPPQdoU91ex+Cag+Li45Lu0ejEDa2jD9+4wymKBNJ+CRQ4iYcgUr1O LL3gdJLikTENCBKr2JzNR+KjgCcatr0HC8oGo6317qEeuaRma7ssUhz6D/fbRjU+ShCs 3LLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; fh=JKAk5g9OeEpZsHSr5t9bMJhmzqtLpjZpEcjmUiZCWCM=; b=oHj7PNb+Npq8cBLIlNHIou6hya3r4EUwaUCtx+TxSOzAgaI0SHAhRItFxCySHpOR1y PmHGr5rQZoYezys4IuL9jnSioko1YpzpgXd2D/qqc5ANcN72Rn6PJhllf0ZtvZpELCV8 x670hhwo1SSU5ZUchlLwmP6Q5+4DLYMwkjVwOMJL1AG32I1wEtpJLvexodtxOIB9Okdk T8lXY2QYlXQ7j6lVy7SLDZxfE6+wyyiRnhHmcogyu45DFr1AiaC5mDaWSVIc6EMBJSH6 mfiz2P/eW/aHB2E3szUzASJQEcnmPdMlntokYAfSD1371wy+0PVhfELcBmQTYEzgo4ar hSZg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=BzMQ7pye; spf=pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-72506-20230727032434988a094ff95ae4f76d-2tNFow@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id j5-20020a056512344500b004fa16c65a05si31515lfr.6.2023.07.26.20.24.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2023 20:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=BzMQ7pye; spf=pass (google.com: domain of fm-72506-20230727032434988a094ff95ae4f76d-2tnfow@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-72506-20230727032434988a094ff95ae4f76d-2tNFow@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20230727032434988a094ff95ae4f76d for ; Thu, 27 Jul 2023 05:24:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=k6Gjyfky9UKQDT2df89/91SYNhpD81vRPvaHhPIXQF0=; b=BzMQ7pyeersYFbyOiMyTKgLk0ViLd8ZGS8WD2XqXZvO/JiNAiebD+SmGSAAgaDrkGZPY87 l2EJUrKZ2JI0yyeSnxAWS52A8A+9Zvhfipe0HEh++7h6C1OkuyjHCZCaNU9hD/h6D0UbGQmJ DF7sxu1y0eP/DPAHsVmkmoK6b7Py8=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: tobias.schaffner@siemens.com, Felix Moessbauer Subject: [PATCH v2 1/2] fix group splitting in user creation Date: Thu, 27 Jul 2023 03:24:14 +0000 Message-Id: <20230727032415.3366650-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: XS1EHvTRvxUo There is a bug when converting the USER_[groups] configuration from the bitbake format (space separated) to the format useradd expects (comma separated). We cannot simply replace spaces with commas, as then multiple spaces in a row would create multiple commas. Instead, we need to split it first into the tokens and then join these tokens by comma. Signed-off-by: Felix Moessbauer --- meta/classes/image-account-extension.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index e783c135..6f67f459 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -98,10 +98,10 @@ def image_create_users(d: "DataSmart") -> None: add_user_option("--comment", "comment") add_user_option("--shell", "shell") - groups = d.getVarFlag(user_entry, "groups") or "" + groups = (d.getVarFlag(user_entry, "groups") or "").split() if groups: args.append("--groups") - args.append(groups.replace(' ', ',')) + args.append(','.join(groups)) flags = (d.getVarFlag(user_entry, "flags") or "").split() -- 2.34.1