public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Felix Moessbauer <felix.moessbauer@siemens.com>
To: isar-users@googlegroups.com
Cc: florian.bezdeka@siemens.com, jan.kiszka@siemens.com,
	daniel.bovensiepen@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/3] add comment about content of u-boot OVERLAYS var
Date: Mon,  4 Sep 2023 05:51:31 +0000	[thread overview]
Message-ID: <20230904055133.1851073-2-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20230904055133.1851073-1-felix.moessbauer@siemens.com>

The update-u-boot-script implementation uses a runtime loop to iterate
over the content each individual overlay entry. This is required because
the entry might contain an u-boot variable, containing multiple overlays
itself.

To avoid incorrect code cleanups like in 680ad26, we add a comment about
this special handling.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/recipes-bsp/u-boot-script/files/update-u-boot-script | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-bsp/u-boot-script/files/update-u-boot-script b/meta/recipes-bsp/u-boot-script/files/update-u-boot-script
index e9ace15e..1d9c6d45 100755
--- a/meta/recipes-bsp/u-boot-script/files/update-u-boot-script
+++ b/meta/recipes-bsp/u-boot-script/files/update-u-boot-script
@@ -63,6 +63,7 @@ if [ -n "${OVERLAYS}" ]; then
 		if ! echo $OVERLAY | grep -q "^/"; then
 			OVERLAY_PATH=/usr/lib/linux-image-${KERNEL_VERSION}/
 		fi
+		# The ${OVERLAY} might contain an u-boot variable with multiple entries.
 		echo "for entry in ${OVERLAY}; do" >> ${BOOT_CMD}
 		echo "echo Loading ${OVERLAY_PATH}\${entry}..." >> ${BOOT_CMD}
 		echo "load \${devtype} \${devnum}:${ROOT_PARTITION}" \
-- 
2.34.1


  reply	other threads:[~2023-09-04  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  5:51 [PATCH 0/3] Extend u-boot-script for DT overlays Felix Moessbauer
2023-09-04  5:51 ` Felix Moessbauer [this message]
2023-09-04  5:51 ` [PATCH 2/3] u-boot-script: add support to use builtin dt Felix Moessbauer
2023-09-04  6:05   ` Jan Kiszka
2023-09-04  7:09     ` MOESSBAUER, Felix
2023-09-04  5:51 ` [PATCH 3/3] use builtin DT for nanopi-neo target Felix Moessbauer
2023-09-04  6:05 ` [PATCH 0/3] Extend u-boot-script for DT overlays Jan Kiszka
2023-09-22  4:23 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230904055133.1851073-2-felix.moessbauer@siemens.com \
    --to=felix.moessbauer@siemens.com \
    --cc=daniel.bovensiepen@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox