* [PATCH] image: Fix quality check ignore for multiuser config
@ 2023-10-20 11:15 Anton Mikanovich
2023-10-20 15:32 ` MOESSBAUER, Felix
0 siblings, 1 reply; 2+ messages in thread
From: Anton Mikanovich @ 2023-10-20 11:15 UTC (permalink / raw)
To: isar-users; +Cc: Anton Mikanovich, Zhibin Dong
If changing user, UID or GID information more then once, original files
will be saved in temporary files which should be ignored during
do_rootfs_quality_check task.
Fixes #98
Reported-by: Zhibin Dong <developerdong@gmail.com>
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
meta/classes/image.bbclass | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index cc8e3443..73f1d52c 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -496,8 +496,11 @@ do_rootfs_quality_check() {
args="${args} ! -path ${ROOTFSDIR}/etc/machine-id";;
image_postprocess_accounts)
args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
+ ! -path ${ROOTFSDIR}/etc/passwd- \
! -path ${ROOTFSDIR}/etc/subgid \
+ ! -path ${ROOTFSDIR}/etc/subgid- \
! -path ${ROOTFSDIR}/etc/subuid \
+ ! -path ${ROOTFSDIR}/etc/subuid- \
! -path ${ROOTFSDIR}/etc/gshadow \
! -path ${ROOTFSDIR}/etc/gshadow- \
! -path ${ROOTFSDIR}/etc/shadow \
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] image: Fix quality check ignore for multiuser config
2023-10-20 11:15 [PATCH] image: Fix quality check ignore for multiuser config Anton Mikanovich
@ 2023-10-20 15:32 ` MOESSBAUER, Felix
0 siblings, 0 replies; 2+ messages in thread
From: MOESSBAUER, Felix @ 2023-10-20 15:32 UTC (permalink / raw)
To: amikan, isar-users; +Cc: developerdong
On Fri, 2023-10-20 at 14:15 +0300, Anton Mikanovich wrote:
> If changing user, UID or GID information more then once, original
> files
> will be saved in temporary files which should be ignored during
> do_rootfs_quality_check task.
Do we include these files in the final image? I'm pretty sure we should
not as this is a reproducibility issue.
Felix
>
> Fixes #98
>
> Reported-by: Zhibin Dong <developerdong@gmail.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/image.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index cc8e3443..73f1d52c 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -496,8 +496,11 @@ do_rootfs_quality_check() {
> args="${args} ! -path ${ROOTFSDIR}/etc/machine-id";;
> image_postprocess_accounts)
> args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
> + ! -path ${ROOTFSDIR}/etc/passwd- \
> ! -path ${ROOTFSDIR}/etc/subgid \
> + ! -path ${ROOTFSDIR}/etc/subgid- \
> ! -path ${ROOTFSDIR}/etc/subuid \
> + ! -path ${ROOTFSDIR}/etc/subuid- \
> ! -path ${ROOTFSDIR}/etc/gshadow \
> ! -path ${ROOTFSDIR}/etc/gshadow- \
> ! -path ${ROOTFSDIR}/etc/shadow \
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-20 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 11:15 [PATCH] image: Fix quality check ignore for multiuser config Anton Mikanovich
2023-10-20 15:32 ` MOESSBAUER, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox