public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH 4/4] CI: Use getVars for vm output checking
Date: Thu, 25 Jan 2024 11:06:17 +0200	[thread overview]
Message-ID: <20240125090617.2945621-5-amikan@ilbers.de> (raw)
In-Reply-To: <20240125090617.2945621-1-amikan@ilbers.de>

This will reduce overhead and should speedup startvm tests execution.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 testsuite/cibuilder.py | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index 273a1dce..0f2aa0f5 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -507,17 +507,20 @@ BBPATH .= ":${LAYERDIR}"\
         return 1
 
 
-    def vm_parse_output(self, boot_log, bb_output, skip_modulecheck):
+    def vm_parse_output(self, boot_log, multiconfig, skip_modulecheck):
         # the printk of recipes-kernel/example-module
         module_output = b'Just an example'
         resize_output = None
-        image_fstypes = start_vm.get_bitbake_var(bb_output, 'IMAGE_FSTYPES')
-        wks_file = start_vm.get_bitbake_var(bb_output, 'WKS_FILE')
+        image_fstypes, \
+        wks_file, \
+        bbdistro = self.getVars('IMAGE_FSTYPES', \
+                                'WKS_FILE', \
+                                'DISTRO', \
+                                target=multiconfig)
 
         # only the first type will be tested in start_vm.py
         if image_fstypes.split()[0] == 'wic':
             if wks_file:
-                bbdistro = start_vm.get_bitbake_var(bb_output, 'DISTRO')
                 # ubuntu is less verbose so we do not see the message
                 # /etc/sysctl.d/10-console-messages.conf
                 if bbdistro and "ubuntu" not in bbdistro:
@@ -627,8 +630,8 @@ BBPATH .= ":${LAYERDIR}"\
                     self.vm_turn_off(vm)
                 self.fail('Failed to run test over ssh')
         else:
-            bb_output = start_vm.get_bitbake_env(arch, distro, image).decode()
-            rc = self.vm_parse_output(boot_log, bb_output, skip_modulecheck)
+            multiconfig = 'mc:qemu' + arch + '-' + distro + ':' + image
+            rc = self.vm_parse_output(boot_log, multiconfig, skip_modulecheck)
             if rc != 0:
                 if stop_vm:
                     self.vm_turn_off(vm)
-- 
2.34.1


  parent reply	other threads:[~2024-01-25  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  9:06 [PATCH 0/4] Improve variables obtaining in CI Anton Mikanovich
2024-01-25  9:06 ` [PATCH 1/4] CI: Fix getVars API self checks Anton Mikanovich
2024-01-25  9:06 ` [PATCH 2/4] CI: Remove getlayerdir API Anton Mikanovich
2024-01-25  9:06 ` [PATCH 3/4] CI: Reuse getVars in repro-build-test Anton Mikanovich
2024-01-25  9:06 ` Anton Mikanovich [this message]
2024-01-31 14:41 ` [PATCH 0/4] Improve variables obtaining in CI Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240125090617.2945621-5-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox