public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [RFC 1/4] multiarch: Add warning on PN usage fallback
Date: Fri, 16 Feb 2024 16:34:23 +0200	[thread overview]
Message-ID: <20240216143426.3490967-2-amikan@ilbers.de> (raw)
In-Reply-To: <20240216143426.3490967-1-amikan@ilbers.de>

Using PN in variables should be avoided in prior to BPN for -compat and
-native compatibility. Add a warning in case of autofixing.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/multiarch.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/multiarch.bbclass b/meta/classes/multiarch.bbclass
index b3fc9441..d1bad652 100644
--- a/meta/classes/multiarch.bbclass
+++ b/meta/classes/multiarch.bbclass
@@ -52,6 +52,8 @@ python multiarch_virtclass_handler() {
             if v is not None and '${PN}' in v:
                 d.setVar(var + ':remove', v)
                 d.appendVar(var, v.replace('${PN}', '${BPN}'))
+                bb.warn('Variable PN in ' + var + ' is not recommended. ' +
+                        'Use BPN instead.')
 
     # When building compat/native, the corresponding suffix needs to be
     # propagated to all bitbake dependency definitions.
-- 
2.34.1


  reply	other threads:[~2024-02-16 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 14:34 [RFC 0/4] Warn on PN usage for virtual packages Anton Mikanovich
2024-02-16 14:34 ` Anton Mikanovich [this message]
2024-02-16 14:34 ` [RFC 2/4] meta/conf/bitbake.conf: Set global BPN Anton Mikanovich
2024-02-16 14:34 ` [RFC 3/4] base: Fix FILESPATH value for -native and -compat Anton Mikanovich
2024-02-16 14:34 ` [RFC 4/4] hello: Use BPN instead of PN Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240216143426.3490967-2-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox