public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Cedric Hombourger <cedric.hombourger@siemens.com>
To: isar-users@googlegroups.com
Cc: Cedric Hombourger <cedric.hombourger@siemens.com>
Subject: [PATCH v2] repository: make repo_del_srcpackage delete only source packages
Date: Mon, 26 Feb 2024 08:07:05 +0100	[thread overview]
Message-ID: <20240226070705.12563-1-cedric.hombourger@siemens.com> (raw)
In-Reply-To: <5f4783e3-8f92-4f28-b408-cb9165f95db4@siemens.com>

The reprepro removesrc command not only deletes the requested source
package but also any binary packages that were built from it. If
do_deploy_source is recalled after do_deploy_deb, we would see
previously deployed binary packages vanish from isar-apt. This
incoherency was found by running bitbake -fc deploy_source after a
complete build of a recipe.

Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
---
 meta/classes/repository.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/repository.bbclass b/meta/classes/repository.bbclass
index a61e5dcd..28e712fd 100644
--- a/meta/classes/repository.bbclass
+++ b/meta/classes/repository.bbclass
@@ -70,8 +70,8 @@ repo_del_srcpackage() {
     if [ -n "${GNUPGHOME}" ]; then
         export GNUPGHOME="${GNUPGHOME}"
     fi
-    reprepro -b "${dir}" --dbdir "${dbdir}" \
-        removesrc "${codename}" \
+    reprepro -b "${dir}" --dbdir "${dbdir}" -A source \
+        remove "${codename}" \
         "${packagename}"
 }
 
-- 
2.39.2


  reply	other threads:[~2024-02-26  7:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  9:42 [PATCH] " Cedric Hombourger
2024-02-23 11:34 ` Jan Kiszka
2024-02-23 11:52   ` cedric.hombourger
2024-02-23 12:23     ` Jan Kiszka
2024-02-26  7:07       ` Cedric Hombourger [this message]
2024-03-11 12:07         ` [PATCH v2] " Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226070705.12563-1-cedric.hombourger@siemens.com \
    --to=cedric.hombourger@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox