From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7348708478702059520 X-Received: by 2002:a05:6820:308c:b0:5a4:886a:baf with SMTP id eu12-20020a056820308c00b005a4886a0bafmr15821626oob.7.1711004525708; Thu, 21 Mar 2024 00:02:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a4a:e0d1:0:b0:5a4:3b6f:c4fa with SMTP id e17-20020a4ae0d1000000b005a43b6fc4fals586077oot.2.-pod-prod-02-us; Thu, 21 Mar 2024 00:02:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjhDE42rq/zwv4gJXQv+H/uz8KBhvD5cD5QBNaxukZaaK0asx2ElKXEzVtOgkMa0VSwh93 X-Received: by 2002:a05:6830:4b1:b0:6e5:3134:10f7 with SMTP id l17-20020a05683004b100b006e5313410f7mr21429828otd.32.1711004523217; Thu, 21 Mar 2024 00:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711004523; cv=none; d=google.com; s=arc-20160816; b=fUAsMcghVGN9ru0QE18Yvf462oRr45hY6VvhJDt8K91o3bkmhvagM0NKh9Cf0tYLTJ oMJYOQZEUJ6q78Sn5YHEr0GbsDuU/VHNh6/USotW0NuCWn1UrJ3kQvm/gKia0RZkLgLL oyxCTqHQaY759Xz05lNwkOm6PGUzlx4lxOuskcpMH7J1VQZWR65jgQPOxN9Obi8/cnvX uzbOC1GvX+GNvQo5/0hvnGWUIFEwDuGe69AbWWjS0Z8Siu4bUoFAXclsHVGR8cah74n2 2B0cXGgbvjv/mGGQG32e+KY6tfxLJ8qWDjDZHUeyfO+BwtBPFAiQNx2fGMvM9g2WjVDY fI4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:ironport-sdr; bh=SpuCw9t/Rdhh637+ulwC736FruuDfforCpiWnO5bO1c=; fh=F4R8d8MZz4e5TZM675wSZVz+eMNa1apx7X6eFG4Iths=; b=smTh2Tpes+sDj9OJAtLgHQsNhb6GdynOuHVtS/JWhA9pfkLYnQcaCXqD3Eq+UI/OwR UgTB6aa+cNPbUi6EMpVPFDr5yUfba6C6U9U6ofLT9tBaJlKtIOVIz2pvEq84HxZLkeD/ g2NJMx6Cvz1FwpMwX7WdSBeXHCbSRQYuKn5QQWn7j/Ww4igC18gl7BEUNj8C22vRg65a BknSP1YQz8ROudlYNOcz3OBDnz4RwaLA2Tlmy47nvKCkn2gllrgO4RlF5n575DJef2oA YC3RxSbYA0JLCor0dFKl1/jI5mJF+rQSC53QYLyzXwTXqcYfbaI62D+PqSGL5qf30pOE IZqQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) smtp.mailfrom=Badrikesh_Prusty@mentor.com Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com. [68.232.141.98]) by gmr-mx.google.com with ESMTPS id l2-20020a9d6a82000000b006e6a1f0ac32si352847otq.1.2024.03.21.00.02.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2024 00:02:03 -0700 (PDT) Received-SPF: pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) client-ip=68.232.141.98; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) smtp.mailfrom=Badrikesh_Prusty@mentor.com X-CSE-ConnectionGUID: J4B0AXw7RxCfhaxO6nC5Tg== X-CSE-MsgGUID: IHll00iYR0KOVYQl6a0oQw== X-IronPort-AV: E=Sophos;i="6.07,142,1708416000"; d="scan'208";a="36340820" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 20 Mar 2024 23:02:01 -0800 IronPort-SDR: uWnj0YvmlCM+VpqXtxW2rG1rFnOQFYQ1v7GjU2xulvIaXMf/pBqMIvwixPDFT5AJubXunW/oXn XoqlnoTil5Edo/RE5SNG3aPpnWQgeEehRTLA6hpQK+VZoXp+jYI/pWiatQGkvOZxhOYJL2FNp9 OnkBAzQLVqwmPKP6R6lHPTJXptU05cE4K0RTYnK8kNeuaEINVOnkPy2htvspY3cyPzkLw5P05h w9CXab3NRszSSGi+/NfSeWrRLzD3mRr68dvdLlH4VNW9H+KZJ2U+BUtw/NHu1HUoYi9tcd4smv VkU= From: Badrikesh Prusty To: CC: Badrikesh Prusty Subject: [PATCH] scripts/start_vm: enclose -append args in quotes and use eval Date: Thu, 21 Mar 2024 12:31:19 +0530 Message-ID: <20240321070119.2973182-1-badrikesh_prusty@mentor.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Return-Path: badrikesh_prusty@mentor.com X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-TUID: +//w+V7nX+uH From: Badrikesh Prusty - Observing boot failure of qemuarm64 with error message: 'root=/dev/vda': No such file or directory - Fix syntax for providing -append arguments with qemu-system-* command - The -append arguments must be enclosed in quotes - Use eval to execute qemu-system-* command - Fix consistency with use of spaces instead of tabs Signed-off-by: Badrikesh Prusty --- scripts/start_vm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/scripts/start_vm b/scripts/start_vm index 8c696a4a..e9f13dc0 100755 --- a/scripts/start_vm +++ b/scripts/start_vm @@ -19,18 +19,18 @@ bb2sh() { start_qemu() { root=`echo $QEMU_DISK_ARGS \ | sed 's,##ROOTFS_IMAGE##,'$IMAGE_DIR/$ROOTFS_IMAGE','` - [ -n "$KARGS$EXTRA_KARGS" ] && OPT_KERNEL_ARGS="-append $KARGS$EXTRA_KARGS" + [ -n "$KARGS$EXTRA_KARGS" ] && OPT_KERNEL_ARGS="-append '$KARGS$EXTRA_KARGS'" local had_x echo $- | grep -q x && had_x=1 || had_x=0 [ $had_x -eq 0 ] && set -x - qemu-system-$QEMU_ARCH \ - -m 1024M \ - -M $QEMU_MACHINE \ - $QCPU \ - -nographic \ - $EXTRA_ARGS \ - $OPT_KERNEL_ARGS \ - $root + eval qemu-system-$QEMU_ARCH \ + -m 1024M \ + -M $QEMU_MACHINE \ + $QCPU \ + -nographic \ + $EXTRA_ARGS \ + $OPT_KERNEL_ARGS \ + $root [ $had_x -eq 0 ] && set +x } -- 2.39.2