public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: srinuvasan.a@siemens.com
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, Srinuvasan A <srinuvasan.a@siemens.com>
Subject: [PATCH] wic: bootimg-efi-isar: use static method for _copy_additional_files
Date: Mon, 25 Mar 2024 14:19:04 +0530	[thread overview]
Message-ID: <20240325084904.2036784-1-srinuvasan.a@siemens.com> (raw)

From: Srinuvasan A <srinuvasan.a@siemens.com>

Presently we uses classmethod decorator for _copy_additional_files
method, and actually this not needed becuase we are not accessing any
class variable or method in this function.

Change to static method for the below reason
- We are performing the generic functionality
- Moreover this should be initialized only once

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
index 4bfb70a0..5fe9bcb0 100644
--- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
+++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
@@ -40,8 +40,8 @@ class BootimgEFIPlugin(SourcePlugin):
 
     name = 'bootimg-efi-isar'
 
-    @classmethod
-    def _copy_additional_files(cls, hdddir, initrd, dtb):
+    @staticmethod
+    def _copy_additional_files(hdddir, initrd, dtb):
         bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
         if not bootimg_dir:
             raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")
-- 
2.25.1


             reply	other threads:[~2024-03-25  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25  8:49 srinuvasan.a [this message]
2024-03-25 13:30 ` Jan Kiszka
2024-03-25 13:54   ` Srinuvasan Arjunan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240325084904.2036784-1-srinuvasan.a@siemens.com \
    --to=srinuvasan.a@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox