From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7350220502645866496 X-Received: by 2002:a92:c5c4:0:b0:366:a703:24a3 with SMTP id s4-20020a92c5c4000000b00366a70324a3mr6190104ilt.25.1711356570149; Mon, 25 Mar 2024 01:49:30 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:2187:b0:368:8ad8:ea97 with SMTP id j7-20020a056e02218700b003688ad8ea97ls660453ila.2.-pod-prod-09-us; Mon, 25 Mar 2024 01:49:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHYWBqcOlY+vdSiuR/z/92ezOLMF4tEUf3xBOPAO1HjYeqbQTw6TPgzkuUREEjbzAldTra X-Received: by 2002:a6b:fe02:0:b0:7d0:5464:dd45 with SMTP id x2-20020a6bfe02000000b007d05464dd45mr2643853ioh.0.1711356568802; Mon, 25 Mar 2024 01:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711356568; cv=none; d=google.com; s=arc-20160816; b=VY+H/Pzu9xGgg0W4whr7CKcWQvn+BCUcODm7pqs78+T6STyRplno/XQRBW+JAThyxv op69EEy7NJwib0C45vWcuzeFvG+coneK8QGQ2sK85TXJHklk11qj63kC5/UP4zua1eYz BbLHIYM3ce6EJr36/kEEgHeohti2HrO6xa3thWv8+/3OIFXhFZ9JKUKYWUc42bU2kPRu WwODMdn+L5Xs3pWa7DcXZq34ee//VUoxUO0rllmtOQBir6sbhV0W/AvYNVjBzGW4kMQN 3aT5wdPLb+lPV8/yPK7YFArghCO9CtPGGHNB8qO7eS5b2f6pMHD1YQog7/Ob10HBmCR+ HcgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=38kQIthBi3jks9vF8/N66xQQMniUbfevxeEeoIvp/pk=; fh=kfhEa0yq30nvGTzFPP1zawlSoLTryr3g7woN/9lNEak=; b=Vofrzn2hG9Jgn6guWHcCzqSpbWcGQsFzaHLHudLJAd2T7fycywLKjg1qQ1XeIWRVBs bzYdu1+lbLA181iVIwjOYZ/qkpTTZghe6oBO6/3WOTBwLbLboxdrSiY5mCFK/CU11p3+ DeVwxYeodet64JyZ6XsPQ6EQdr/nXJGKZ6uJfbVNpNk16+sJg3ZXKcIIhm6YePgrwnU6 S93g3DLt2/n1EEOI6NjEfdIHS3CEq544nhU/PwZhNxwLMVRrWIdWSgOlkcTsYW8IHJ9q 3vHOcrnXuVOqYBScXJqp5g6s/jVZRu+wfemfL+/fEOwlW1saAm3FqL/xCRgIeE5ioTdk 2SWw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Kn0OzV2F; spf=pass (google.com: domain of fm-1324425-20240325084926d35a9713a37fec3576-a5anei@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1324425-20240325084926d35a9713a37fec3576-a5aNEI@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id cb19-20020a056602421300b007ccaf5d9a27si333336iob.4.2024.03.25.01.49.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2024 01:49:28 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1324425-20240325084926d35a9713a37fec3576-a5anei@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Kn0OzV2F; spf=pass (google.com: domain of fm-1324425-20240325084926d35a9713a37fec3576-a5anei@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1324425-20240325084926d35a9713a37fec3576-a5aNEI@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 20240325084926d35a9713a37fec3576 for ; Mon, 25 Mar 2024 09:49:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=srinuvasan.a@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=38kQIthBi3jks9vF8/N66xQQMniUbfevxeEeoIvp/pk=; b=Kn0OzV2FjaNv2mBTba8eV6aZ53s0FE+X8t5CyS7tQX1xcrlrYMTtaCFZYd/40VbS6uQ8vU 0Kk6iSFt5Mea3aZjb/xNlU/q2fWh1LttDmd4jYzBGL7JLIjVlkYIcOZ7vN7H3vXS3sx3uw55 /Kt0f20Y67EwW5n8p96JnnAc30cgk=; From: srinuvasan.a@siemens.com To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, Srinuvasan A Subject: [PATCH] wic: bootimg-efi-isar: use static method for _copy_additional_files Date: Mon, 25 Mar 2024 14:19:04 +0530 Message-Id: <20240325084904.2036784-1-srinuvasan.a@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1324425:519-21489:flowmailer X-TUID: m4ENJbmsP5fc From: Srinuvasan A Presently we uses classmethod decorator for _copy_additional_files method, and actually this not needed becuase we are not accessing any class variable or method in this function. Change to static method for the below reason - We are performing the generic functionality - Moreover this should be initialized only once Signed-off-by: Srinuvasan A --- meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index 4bfb70a0..5fe9bcb0 100644 --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -40,8 +40,8 @@ class BootimgEFIPlugin(SourcePlugin): name = 'bootimg-efi-isar' - @classmethod - def _copy_additional_files(cls, hdddir, initrd, dtb): + @staticmethod + def _copy_additional_files(hdddir, initrd, dtb): bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE") if not bootimg_dir: raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting") -- 2.25.1