From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7350330382288420864 X-Received: by 2002:a2e:9f53:0:b0:2d6:a1f7:2a12 with SMTP id v19-20020a2e9f53000000b002d6a1f72a12mr4792889ljk.38.1711382165266; Mon, 25 Mar 2024 08:56:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:7019:0:b0:2d4:9683:bb0b with SMTP id l25-20020a2e7019000000b002d49683bb0bls1653988ljc.0.-pod-prod-04-eu; Mon, 25 Mar 2024 08:56:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF68HoDXSwZRPI0SXzrDz06+hyDAzB2Ar5A4HLhDCrStp9WOeOprbugWdln35oItLBmW/4c X-Received: by 2002:a2e:b042:0:b0:2d4:729a:bc05 with SMTP id d2-20020a2eb042000000b002d4729abc05mr4108941ljl.36.1711382163210; Mon, 25 Mar 2024 08:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711382163; cv=none; d=google.com; s=arc-20160816; b=hAbSNcOrDdCzwRNgnidRHrjGstx5LILdKUvpaeQuLCDrX7zvxNYjcfTH4h3hK8wjWJ 228zYFwJ/atL7py8wqPOdb9yXpffd/M/wOpaZrX8HnMhuS3+NKX3UF6YMNRPRL+4P9mK 5RpQ37wNjFu82fA+oAV0pHOLKQ1TXFVFgP/0BJUTLsGlx5yblMQVf3BVS738FBQFWyQN fR0hDuwfbPGOmjKRxa7G4jnkPJOQNDUJQhmHkh+cifk2UaX6ignxBcvJlLk41keQTEdB 2OdpEpms+GiFi9M9xdRiy64rWlIBfSQHv0gw+T1roLpX+QFKIzPKSkBMr1AAMUF2Y7kH gWBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=qyGyrBuA9vpuogwzn/R/BeiHf4xxhcB3jEpl0xisHmo=; fh=/h9QQkzJ8EboVkWg45aWwpaUro6WMavIVd2OhN45RtE=; b=RcNgp/sYTnec6hSU4ZBP2+5O+rRVP6DkYcGH+03WM+Z3lEfyOjAD/bA769fBpoEChE PsiLSsIyvzKEZuNO/33iB1VjOzviWbHUGxtGs3Hsr8E37kGpkl6xkaLSqL02wK1jJr5K /UFbAzVH+eTy6QbaiIzQzN1U2GmEEPv9rwrHxY7Km2JxOY7P/prgveFdajktEzEy+e6N HZ5c7O8DAr1D5zPPT3RO4Ag+06HU+lZNBTfo8GyhxsD3EU/gR9guWgffPSG2CrN7tzbz 9aYcmj3K3cRJEkAtCywdVMPEIria7RbFjgnGrL2BeUC3VV27yDl1vVd5LQJRcTcGsUMW BGSg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id jv1-20020a05600c570100b0041466c64287si287541wmb.1.2024.03.25.08.56.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2024 08:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from user-B660.promwad.corp ([159.148.83.123]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 42PFtnLL011703 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Mar 2024 16:56:00 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH 12/23] CI: Do not lost errors on failed processes Date: Mon, 25 Mar 2024 17:55:29 +0200 Message-Id: <20240325155540.4162990-13-amikan@ilbers.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240325155540.4162990-1-amikan@ilbers.de> References: <20240325155540.4162990-1-amikan@ilbers.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: XG14MKAJN/9F If subprocess failed before parsing its output we should try to get error output at least once. Otherwise it will be lost. Signed-off-by: Anton Mikanovich --- testsuite/cibuilder.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py index ec2c0044..a4658ea7 100755 --- a/testsuite/cibuilder.py +++ b/testsuite/cibuilder.py @@ -197,7 +197,7 @@ class CIBuilder(Test): poller = select.poll() poller.register(p1.stdout, select.POLLIN) poller.register(p1.stderr, select.POLLIN) - while p1.poll() is None: + while True: events = poller.poll(1000) for fd, event in events: if event != select.POLLIN: @@ -206,6 +206,8 @@ class CIBuilder(Test): self.log.info(p1.stdout.readline().rstrip()) if fd == p1.stderr.fileno(): self.log.error(p1.stderr.readline().rstrip()) + if p1.poll() is not None: + break p1.wait() if p1.returncode: self.fail('Bitbake failed') @@ -477,7 +479,7 @@ BBPATH .= ":${LAYERDIR}"\ databuf = bytearray(b'') databuf_size = 1024 * 2 + len(login_prompt) - while time.time() < timeout and p1.poll() is None: + while time.time() < timeout: events = poller.poll(1000 * (timeout - time.time())) for fd, event in events: if event != select.POLLIN: @@ -491,6 +493,8 @@ BBPATH .= ":${LAYERDIR}"\ return 0 if fd == p1.stderr.fileno(): self.log.error(p1.stderr.readline().rstrip()) + if p1.poll() is not None: + break rc = 1 if time.time() > timeout: -- 2.34.1