public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH 1/1] fix: trixie package exceptions
@ 2024-03-26  8:47 Adriaan Schmidt
  2024-03-26  9:00 ` Anton Mikanovich
  0 siblings, 1 reply; 3+ messages in thread
From: Adriaan Schmidt @ 2024-03-26  8:47 UTC (permalink / raw)
  To: isar-users; +Cc: Adriaan Schmidt

We have some cases of changing package names (originally between bullseye
and bookworm), which were solved by adding explicit exceptions for bookworm.
This adds the same exceptions for trixie.

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
---
 meta/conf/distro/debian-common.conf         | 1 +
 meta/recipes-kernel/kselftest/kselftest.inc | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index 1e1dfc83..c6b5d2cd 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -35,6 +35,7 @@ SYSLINUX_BOOTLOADER_INSTALL = "syslinux syslinux-common"
 
 SYSTEMD_BOOTLOADER_INSTALL = "systemd:${DISTRO_ARCH}"
 SYSTEMD_BOOTLOADER_INSTALL:bookworm = "systemd-boot-efi:${DISTRO_ARCH}"
+SYSTEMD_BOOTLOADER_INSTALL:trixie = "systemd-boot-efi:${DISTRO_ARCH}"
 SYSTEMD_BOOTLOADER_INSTALL:sid = "systemd-boot-efi:${DISTRO_ARCH}"
 
 COMPAT_DISTRO_ARCH:amd64 = "i386"
diff --git a/meta/recipes-kernel/kselftest/kselftest.inc b/meta/recipes-kernel/kselftest/kselftest.inc
index 6196f825..ffd44e67 100644
--- a/meta/recipes-kernel/kselftest/kselftest.inc
+++ b/meta/recipes-kernel/kselftest/kselftest.inc
@@ -20,7 +20,7 @@ DEBIAN_BUILD_DEPENDS ?= " \
     rsync, \
     flex,  \
     bison, \
-    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') == 'bookworm' else 'fuse'}, \
+    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') in ['bookworm', 'trixie'] else 'fuse'}, \
     libelf-dev:native, \
     libcap-ng-dev:native, \
     libpopt-dev:native, \
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] fix: trixie package exceptions
  2024-03-26  8:47 [PATCH 1/1] fix: trixie package exceptions Adriaan Schmidt
@ 2024-03-26  9:00 ` Anton Mikanovich
  2024-03-26  9:37   ` Schmidt, Adriaan
  0 siblings, 1 reply; 3+ messages in thread
From: Anton Mikanovich @ 2024-03-26  9:00 UTC (permalink / raw)
  To: Adriaan Schmidt, isar-users

26/03/2024 10:47, 'Adriaan Schmidt' via isar-users wrote:
> We have some cases of changing package names (originally between bullseye
> and bookworm), which were solved by adding explicit exceptions for bookworm.
> This adds the same exceptions for trixie.
>
> Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> ---
>   meta/conf/distro/debian-common.conf         | 1 +
>   meta/recipes-kernel/kselftest/kselftest.inc | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
> index 1e1dfc83..c6b5d2cd 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -35,6 +35,7 @@ SYSLINUX_BOOTLOADER_INSTALL = "syslinux syslinux-common"
>   
>   SYSTEMD_BOOTLOADER_INSTALL = "systemd:${DISTRO_ARCH}"
>   SYSTEMD_BOOTLOADER_INSTALL:bookworm = "systemd-boot-efi:${DISTRO_ARCH}"
> +SYSTEMD_BOOTLOADER_INSTALL:trixie = "systemd-boot-efi:${DISTRO_ARCH}"
>   SYSTEMD_BOOTLOADER_INSTALL:sid = "systemd-boot-efi:${DISTRO_ARCH}"
Maybe its better to make systemd-boot-efi to be default and set 
overrides for
Buster and Bullseye? This will not require adding new overrides for the next
releases and will be easier to track when removing Buster and Bullseye 
in the
future.
>   
>   COMPAT_DISTRO_ARCH:amd64 = "i386"
> diff --git a/meta/recipes-kernel/kselftest/kselftest.inc b/meta/recipes-kernel/kselftest/kselftest.inc
> index 6196f825..ffd44e67 100644
> --- a/meta/recipes-kernel/kselftest/kselftest.inc
> +++ b/meta/recipes-kernel/kselftest/kselftest.inc
> @@ -20,7 +20,7 @@ DEBIAN_BUILD_DEPENDS ?= " \
>       rsync, \
>       flex,  \
>       bison, \
> -    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') == 'bookworm' else 'fuse'}, \
> +    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') in ['bookworm', 'trixie'] else 'fuse'}, \
>       libelf-dev:native, \
>       libcap-ng-dev:native, \
>       libpopt-dev:native, \



^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH 1/1] fix: trixie package exceptions
  2024-03-26  9:00 ` Anton Mikanovich
@ 2024-03-26  9:37   ` Schmidt, Adriaan
  0 siblings, 0 replies; 3+ messages in thread
From: Schmidt, Adriaan @ 2024-03-26  9:37 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users

Anton Mikanovich <amikan@ilbers.de>, Sent: Dienstag, 26. März 2024 10:01:
> 26/03/2024 10:47, 'Adriaan Schmidt' via isar-users wrote:
> > We have some cases of changing package names (originally between
> > bullseye and bookworm), which were solved by adding explicit exceptions for
> bookworm.
> > This adds the same exceptions for trixie.
> >
> > Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> > ---
> >   meta/conf/distro/debian-common.conf         | 1 +
> >   meta/recipes-kernel/kselftest/kselftest.inc | 2 +-
> >   2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/distro/debian-common.conf
> > b/meta/conf/distro/debian-common.conf
> > index 1e1dfc83..c6b5d2cd 100644
> > --- a/meta/conf/distro/debian-common.conf
> > +++ b/meta/conf/distro/debian-common.conf
> > @@ -35,6 +35,7 @@ SYSLINUX_BOOTLOADER_INSTALL = "syslinux syslinux-common"
> >
> >   SYSTEMD_BOOTLOADER_INSTALL = "systemd:${DISTRO_ARCH}"
> >   SYSTEMD_BOOTLOADER_INSTALL:bookworm = "systemd-boot-efi:${DISTRO_ARCH}"
> > +SYSTEMD_BOOTLOADER_INSTALL:trixie = "systemd-boot-efi:${DISTRO_ARCH}"
> >   SYSTEMD_BOOTLOADER_INSTALL:sid = "systemd-boot-efi:${DISTRO_ARCH}"
> Maybe its better to make systemd-boot-efi to be default and set overrides for
> Buster and Bullseye? This will not require adding new overrides for the next
> releases and will be easier to track when removing Buster and Bullseye in the
> future.

I was actually thinking the same when I wrote the patch...
V2 coming up...
Adriaan

> >
> >   COMPAT_DISTRO_ARCH:amd64 = "i386"
> > diff --git a/meta/recipes-kernel/kselftest/kselftest.inc
> > b/meta/recipes-kernel/kselftest/kselftest.inc
> > index 6196f825..ffd44e67 100644
> > --- a/meta/recipes-kernel/kselftest/kselftest.inc
> > +++ b/meta/recipes-kernel/kselftest/kselftest.inc
> > @@ -20,7 +20,7 @@ DEBIAN_BUILD_DEPENDS ?= " \
> >       rsync, \
> >       flex,  \
> >       bison, \
> > -    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') == 'bookworm' else
> 'fuse'}, \
> > +    ${@ 'fuse3' if d.getVar('BASE_DISTRO_CODENAME') in ['bookworm',
> > + 'trixie'] else 'fuse'}, \
> >       libelf-dev:native, \
> >       libcap-ng-dev:native, \
> >       libpopt-dev:native, \
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-26  9:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-26  8:47 [PATCH 1/1] fix: trixie package exceptions Adriaan Schmidt
2024-03-26  9:00 ` Anton Mikanovich
2024-03-26  9:37   ` Schmidt, Adriaan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox