public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: kergoth@gmail.com
To: isar-users@googlegroups.com
Cc: Christopher Larson <chris.larson@seimens.com>,
	Christopher Larson <chris.larson@siemens.com>
Subject: [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI
Date: Tue,  2 Apr 2024 17:28:07 +0000	[thread overview]
Message-ID: <20240402172813.418770-4-chris.larson@siemens.com> (raw)
In-Reply-To: <20240402172813.418770-1-chris.larson@siemens.com>

From: Christopher Larson <chris.larson@seimens.com>

In addition to the current checks for variables starting with an
absolute path, particularly those within the build or sources
directories, we should also check for absolute paths in SRC_URI
file entries.

Signed-off-by: Christopher Larson <chris.larson@siemens.com>
---
 scripts/isar-sstate | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/scripts/isar-sstate b/scripts/isar-sstate
index c14c2843..9b20cb8e 100755
--- a/scripts/isar-sstate
+++ b/scripts/isar-sstate
@@ -839,6 +839,23 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, **
                 continue
             # remove leading whitespaces possibly added by appending
             val = val.lstrip()
+            if name == 'SRC_URI':
+                src_uri = val.split()
+                for entry in src_uri:
+                    if entry.startswith('file:///'):
+                        entry_path = entry[7:]
+                        if entry_path.startswith(build_dir):
+                            pn_issues.append(f'\033[0;31m-> path in build-dir:   SRC_URI entry "{entry}"\033[0m')
+                            hits_builddir += 1
+                        elif entry_path.startswith(sources_dir):
+                            pn_issues.append(f'\033[0;31m-> path in sources-dir: SRC_URI entry "{entry}"\033[0m')
+                            hits_srcdir += 1
+                        else:
+                            hits_other += 1
+                            if verbose:
+                                pn_issues.append(f'\033[0;34m-> other absolute path: SRC_URI entry "{entry}"\033[0m')
+                continue
+
             if not val[0] == '/':
                 continue
             if val.startswith(build_dir):
-- 
2.39.2


  parent reply	other threads:[~2024-04-02 17:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 17:28 [PATCH 0/9] Add more signature cachability tests to the testsuite kergoth
2024-04-02 17:28 ` [PATCH 1/9] isar-bootstrap: avoid forced early expansion of key vars kergoth
2024-04-03  6:54   ` MOESSBAUER, Felix
2024-04-03 21:42     ` Larson, Chris
2024-04-04  6:26       ` MOESSBAUER, Felix
2024-04-02 17:28 ` [PATCH 2/9] isar-ci-ssh-setup: avoid abs path in signatures kergoth
2024-04-02 17:28 ` kergoth [this message]
2024-04-03  6:56   ` [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI MOESSBAUER, Felix
2024-04-02 17:28 ` [PATCH 4/9] isar-sstate: lint: add support for checking stamps kergoth
2024-04-03  7:02   ` MOESSBAUER, Felix
2024-04-03 21:42     ` Larson, Chris
2024-04-02 17:28 ` [PATCH 5/9] isar-sstate: lint: ignore more image tasks kergoth
2024-04-03  7:08   ` MOESSBAUER, Felix
2024-04-02 17:28 ` [PATCH 6/9] isar-sstate: add --excluded-tasks argument kergoth
2024-04-03  7:10   ` MOESSBAUER, Felix
2024-04-03 21:41     ` Larson, Chris
2024-04-03 21:44     ` Larson, Chris
2024-04-04  6:28       ` MOESSBAUER, Felix
2024-04-02 17:28 ` [PATCH 7/9] cibuilder.py: add -S support to the bitbake method kergoth
2024-04-03  7:12   ` MOESSBAUER, Felix
2024-04-03 21:41     ` Larson, Chris
2024-04-02 17:28 ` [PATCH 8/9] testsuite: add perform_signature_lint method kergoth
2024-04-02 17:28 ` [PATCH 9/9] testsuite: add signature cachability checks kergoth
2024-04-05 16:31 [PATCHv2 0/9] Add more signature cachability tests to the testsuite chris.larson
2024-04-05 16:31 ` [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI chris.larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402172813.418770-4-chris.larson@siemens.com \
    --to=kergoth@gmail.com \
    --cc=chris.larson@seimens.com \
    --cc=chris.larson@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox