From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7353323043876241408 X-Received: by 2002:a05:6830:d8:b0:6e6:94cc:d2d2 with SMTP id x24-20020a05683000d800b006e694ccd2d2mr294967oto.37.1712078941680; Tue, 02 Apr 2024 10:29:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ad4:4ea9:0:b0:698:7a54:d873 with SMTP id ed9-20020ad44ea9000000b006987a54d873ls1036835qvb.2.-pod-prod-03-us; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzyfDO8g8sZjEAtbJfmPzUX0JhY6h4E9EYYtcZ9AONQIOZ4yoVJMZbVg+ap0QX3RBW/s4J X-Received: by 2002:a05:6122:2003:b0:4b6:d63c:ca8f with SMTP id l3-20020a056122200300b004b6d63cca8fmr377053vkd.16.1712078940163; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712078940; cv=none; d=google.com; s=arc-20160816; b=TBAVjKfcck+9k4DEAYQQdTxsS4+Q5kgDGZVZyE5/JPdsliW+PInjzfCItfw2bBp3Xr PzqPpuZRewUirZrVT5iN2TNDVqcmWVdVzWfJ0DPyp/gD5Kk80a7DFz4ttCkq+v3Pkao1 mJKHavG6Wquldds2eucjNMyYiF7/glEJYzOrFnXqUPUb6UTqKHxj7eLLK6W3kIQGOp9r xs6MIpyHKGCMN5dDYWUhybtGkzuQxhqA+gXzWBnuhZIuYmr+OLxaepdjGrzsH54Mvby2 tFA44d3G8hDPjZzp7yYnW64IomRS2TiL/CeVK3A3UMR4ehih6pYJdXI1aBFJG3jNvjwv 7VCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PsoYVkopixoTWu0I0XvQ3YIN+luvBXXfRju/3GaGyGk=; fh=oQsVBfLFKOCDpQI4v78XDUCp+c0vYPEMW+xCOFIgP4c=; b=tq1yFI8DA+ao6R03DhoV6/am9IFwN7eMFYtoR85VGXHEUxevpNhqFU5Yt8b5Hr9/Gi EgI1sgeA8Tu3XgMMRoJ/JyCQa6bduXGuzo1sMGclqFP4uTKIQaZ//g1XNv+blMgfRbsP jURGv/JMHABhpoWxJ9sfaqHso+w9RFdmIk+0Q2LL1HA9D1D6gDVX3l5OOXIT+OFVbi5f lSiMclrqdkO4/4E2JlrQ9wKdCyUkVwmijGKOGihqhgLPxh/EjchxGFygHFhYnqhy1ddp uUxYTrH78mehOVmcvuGbUwdfP2Ap68UWB2HpkuE/hBeaUKakkJO3qfmy/b6C/7OFRGhT 4kpA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jw+Zk5wi; spf=pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) smtp.mailfrom=kergoth@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com. [2607:f8b0:4864:20::1032]) by gmr-mx.google.com with ESMTPS id 33-20020a0561220a2100b004d3c4a37c63si564643vkn.2.2024.04.02.10.29.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 10:29:00 -0700 (PDT) Received-SPF: pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) client-ip=2607:f8b0:4864:20::1032; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jw+Zk5wi; spf=pass (google.com: domain of kergoth@gmail.com designates 2607:f8b0:4864:20::1032 as permitted sender) smtp.mailfrom=kergoth@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-29b7164eef6so4468667a91.2 for ; Tue, 02 Apr 2024 10:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712078939; x=1712683739; dara=google.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PsoYVkopixoTWu0I0XvQ3YIN+luvBXXfRju/3GaGyGk=; b=jw+Zk5wiKN3QA7DnKcbLckW/+b4XJFvtH1eWXYuZR+hw3jEKYvO6qXKTr1JC1PBcNM WQsKTBj4ttjSXFOYzwQYABtjvKZ/mLW0yNbtWmYmIIOStkR7FlXjvKZch574igxlDY8Z 9nOBnHvAn8J8z6nRcMCWK70DE+GOb9V0zEENg1J82qFfABULqkLjDATX/5zkFqIWcQ3n pXJYs1cEGosX+kQ31Xb897mN4rT691as1HPG2kch6cnSrTl2EbZqQq4xcegE+CArK/4s XKnRz4d4MFYP+L3zJjvoDl5LhH647WttngnV9N+hoz1tXD4zm/QMtFuvba7Zh+EidM4A IzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712078939; x=1712683739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PsoYVkopixoTWu0I0XvQ3YIN+luvBXXfRju/3GaGyGk=; b=M0eILsb3ooWMUnV81DXjv55t+nAakOB1BmT/pF5pBFn57f2dipizfNMFGxDtSYtrjI rDks5Ko9aOGvw+8Y0w66Ay8JLSaF0wth7eg9SikIc/YtrR1kcSGJv7JOi7J1zA6AXyVl fvVFNuMx+MFFRz8bya2YeHq9kLNQBPfMHk9HTHS5xOnVpQeAMvvKSIjiv4nnYrJZiRJv zO5+eu8cVBydXIYyV23Y0/r9A4zw3z4x9ek0CZuFkqPE7TaJ5P5yNBOdq9bv2LzIhWvj TxccWxRptJLgqAgCum27qf2gOXT38EcWHn7AOGh5SPnp/y3AZ8XXzItsmiqJAOp0zACJ Opsw== X-Gm-Message-State: AOJu0YxcHIR7JgR/IH3sNYJhAZptfJ+P6wdwaV0xUEVeGc5JQKBr5FFe kmxAAwcQpP2cpONS31Lrc0YUH3IlVbpXpCnMk+fSWtFhEudrww4LDvraEN1wvws= X-Received: by 2002:a17:90b:18e:b0:2a0:2a36:91a0 with SMTP id t14-20020a17090b018e00b002a02a3691a0mr400677pjs.18.1712078939376; Tue, 02 Apr 2024 10:28:59 -0700 (PDT) Return-Path: Received: from dc4670097af0.alm.mentorg.com (nat-mam.mentorg.com. [139.181.8.34]) by smtp.googlemail.com with ESMTPSA id bt19-20020a17090af01300b002a2313f62dcsm66705pjb.0.2024.04.02.10.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:28:59 -0700 (PDT) From: kergoth@gmail.com X-Google-Original-From: chris.larson@siemens.com To: isar-users@googlegroups.com Cc: Christopher Larson , Christopher Larson Subject: [PATCH 3/9] isar-sstate: lint: check for absolute paths in SRC_URI Date: Tue, 2 Apr 2024 17:28:07 +0000 Message-Id: <20240402172813.418770-4-chris.larson@siemens.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402172813.418770-1-chris.larson@siemens.com> References: <20240402172813.418770-1-chris.larson@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: i3UEG5oX8AdF From: Christopher Larson In addition to the current checks for variables starting with an absolute path, particularly those within the build or sources directories, we should also check for absolute paths in SRC_URI file entries. Signed-off-by: Christopher Larson --- scripts/isar-sstate | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index c14c2843..9b20cb8e 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -839,6 +839,23 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, ** continue # remove leading whitespaces possibly added by appending val = val.lstrip() + if name == 'SRC_URI': + src_uri = val.split() + for entry in src_uri: + if entry.startswith('file:///'): + entry_path = entry[7:] + if entry_path.startswith(build_dir): + pn_issues.append(f'\033[0;31m-> path in build-dir: SRC_URI entry "{entry}"\033[0m') + hits_builddir += 1 + elif entry_path.startswith(sources_dir): + pn_issues.append(f'\033[0;31m-> path in sources-dir: SRC_URI entry "{entry}"\033[0m') + hits_srcdir += 1 + else: + hits_other += 1 + if verbose: + pn_issues.append(f'\033[0;34m-> other absolute path: SRC_URI entry "{entry}"\033[0m') + continue + if not val[0] == '/': continue if val.startswith(build_dir): -- 2.39.2