From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7353323043876241408 X-Received: by 2002:a17:902:f78f:b0:1e0:3518:4522 with SMTP id q15-20020a170902f78f00b001e035184522mr2183614pln.15.1712334748571; Fri, 05 Apr 2024 09:32:28 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e5cb:b0:1e2:a413:578b with SMTP id u11-20020a170902e5cb00b001e2a413578bls1735814plf.0.-pod-prod-02-us; Fri, 05 Apr 2024 09:32:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlwD81+jyCUB1xTLRurJnSmmbGIGIZ6xd7Hm8WpMq8jqrPYXmJkDQHVTtndnSuF+b+BmHg X-Received: by 2002:a17:902:d2d1:b0:1e2:aa13:5bf4 with SMTP id n17-20020a170902d2d100b001e2aa135bf4mr2370307plc.8.1712334746965; Fri, 05 Apr 2024 09:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712334746; cv=none; d=google.com; s=arc-20160816; b=sFXScQZ5C+xZ0tjYt329YUQeV1ma9WFdksN/XlmI3nl97P1jpqm4P+q7g0Pb3oeuba ZiYZD3EXh/0/vE2VTCqib44BLyOzZa9/HG2uHN97Tc6X1ploF5EZ2esyx7wqUxGe0gup Pe7PjKGVpwGG+TovNYbDXuK2BGyqWlOjYx9xUBVyB6LqkMI/EE8rkShkWim/wX9bf6wl MD/59QeoEtl6A2U+LysKLtumK52YlU10gdGIBwuumB8k1ULCIUzCmpBMKXum46knKMy6 fYOWi/0PKRxBCS6S+HVh8gdK9Hv+BWpIhjcBJl/qXZgvG0jLuQPcChzdYFZFCggyPs+u N7sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=XQoEjsphyZvUDDMutunjKOyx4SuUUd8lZ7A+xckUXIg=; fh=3bh9z2BWAzGAc1byRhMi0K+arMZmX5BQHE0sOxINdyU=; b=m8ZMuNNjmH7weUVYfIBv5ZF3g2cr1GQ0N2EF049lRBvkAxM0C5YQLc38QRx81A4x2v S+jdlTRs7FzNFJ85VduA8dx/4dHb8k7Xvs9lv0KtxPMEKfcWJsybkMxpwfeeangESN7j bQofGsVzYm57PjnF0ooXhgQck9949Axn/pckBxC1/6HDKhaSOC+wb75HJj0/jvKIW/cr XqnL5ZuKEqSdfKJ49rrfopNWIIcpkEDVb3utdiVEIr5xE2qUvdy1xkvjMlNiN+SEISOg 1+sBKnqNMUTfELcJOm4eqt/bC8+VSyytBX9oa6bPxu1ud5YsNSkxRopxXTZrwYTCL2MB c1fQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Z7p6ts4B; spf=pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1325773-20240405163226e6ce2504f08d44c6f5-zAPzuJ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id jc18-20020a17090325d200b001dd61b4ef8esi97963plb.12.2024.04.05.09.32.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2024 09:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Z7p6ts4B; spf=pass (google.com: domain of fm-1325773-20240405163226e6ce2504f08d44c6f5-zapzuj@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1325773-20240405163226e6ce2504f08d44c6f5-zAPzuJ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20240405163226e6ce2504f08d44c6f5 for ; Fri, 05 Apr 2024 18:32:26 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=chris.larson@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=XQoEjsphyZvUDDMutunjKOyx4SuUUd8lZ7A+xckUXIg=; b=Z7p6ts4BRz8Y3IK6V58BNbzF0SkCcNaUImDyuRWAXPGSEXvcN+UKsMIBXol7Ml28wSsKK2 xtNImo1we7PY2wqvHoCd+++lli92XIGdOfk9AHPxwGRU9JE9eazsNmADgJHwtQ0gIAjYpWPn zlg98WsmlejMlFxP2QZ2jnPJkKb3c=; From: chris.larson@siemens.com To: isar-users@googlegroups.com Cc: Christopher Larson Subject: [PATCH 6/9] isar-sstate: fix failures if a variable is set to just whitespace Date: Fri, 5 Apr 2024 16:31:32 +0000 Message-Id: <20240405163135.2987489-7-chris.larson@siemens.com> In-Reply-To: <20240405163135.2987489-1-chris.larson@siemens.com> References: <20240405163135.2987489-1-chris.larson@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1325773:519-21489:flowmailer X-TUID: ZWqlyYPsx00Y From: Christopher Larson We see this failure if a variable is set to the empty string, as whitespace is being stripped off of the variable after we check if the value is empty or None, not before. Traceback (most recent call last): File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 941, in sys.exit(main()) ^^^^^^ File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 937, in main return globals()[f'sstate_{args.command}'](**vars(args)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kergoth/Code/indos/signatures/isar/scripts/isar-sstate", line 894, in sstate_lint if not val[0] == '/': ~~~^^^ IndexError: string index out of range Signed-off-by: Christopher Larson --- scripts/isar-sstate | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/isar-sstate b/scripts/isar-sstate index a4429b7a..4ea38bc8 100755 --- a/scripts/isar-sstate +++ b/scripts/isar-sstate @@ -868,10 +868,11 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, li sigdata['taskhash_ignore_tasks'] and name in sigdata['taskhash_ignore_tasks'] or \ name in ADDITIONAL_IGNORED_VARNAMES: continue - if not val: - continue # remove leading whitespaces possibly added by appending val = val.lstrip() + if not val: + continue + if name == 'SRC_URI': src_uri = val.split() for entry in src_uri: -- 2.39.2