From: Zhibin Dong <developerdong@gmail.com>
To: isar-users@googlegroups.com
Cc: Zhibin Dong <zhibin.dong@siemens.com>
Subject: [PATCH] image: check if the file is core dump
Date: Tue, 16 Apr 2024 13:12:22 +0800 [thread overview]
Message-ID: <20240416051222.3344127-1-zhibin.dong@siemens.com> (raw)
The previous code does a wrong judgement in two cases:
1. a file is suffixed by .core but is not a core dump file
2. a file is a core dump file but is not suffixed by .core
The new code uses `file` to determine the type of files, which is more
accurate.
Signed-off-by: Zhibin Dong <zhibin.dong@siemens.com>
---
meta/classes/image.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 98741da0..10923947 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -444,7 +444,7 @@ EOSUDO
# Sometimes qemu-user-static generates coredumps in chroot, move them
# to work temporary directory and inform user about it.
- for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do
+ for f in $(sudo find ${ROOTFSDIR} -type f -exec file {} \; | grep 'core file' | cut -d: -f1); do
sudo mv "${f}" "${WORKDIR}/temp/"
bbwarn "found core dump in rootfs, check it in ${WORKDIR}/temp/${f##*/}"
done
--
2.39.2
next reply other threads:[~2024-04-16 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AQHaj8I6385ePySTC0KmWAQOaNXsHbFrY0SA>
2024-04-16 5:12 ` Zhibin Dong [this message]
2024-04-16 21:02 ` MOESSBAUER, Felix
2024-04-17 2:11 ` Zhibin Dong
2024-04-17 4:57 ` Schmidt, Adriaan
2024-04-17 6:46 ` Zhibin Dong
2024-04-17 6:50 ` Zhibin Dong
2024-06-17 5:23 ` Uladzimir Bely
2024-06-27 15:44 ` Jan Kiszka
2024-07-01 4:56 ` Schmidt, Adriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416051222.3344127-1-zhibin.dong@siemens.com \
--to=developerdong@gmail.com \
--cc=isar-users@googlegroups.com \
--cc=zhibin.dong@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox