From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7358338671440822272 X-Received: by 2002:a05:6820:1ac2:b0:5ac:5c3c:6aca with SMTP id bu2-20020a0568201ac200b005ac5c3c6acamr12044835oob.0.1713246729888; Mon, 15 Apr 2024 22:52:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6820:16a0:b0:5a4:ee4f:96d0 with SMTP id bc32-20020a05682016a000b005a4ee4f96d0ls1688305oob.0.-pod-prod-09-us; Mon, 15 Apr 2024 22:52:09 -0700 (PDT) X-Received: by 2002:a05:6830:2646:b0:6eb:5652:e9ac with SMTP id f6-20020a056830264600b006eb5652e9acmr534646otu.5.1713246729420; Mon, 15 Apr 2024 22:52:09 -0700 (PDT) Received: by 2002:a05:6808:bc6:b0:3c7:2609:6bf4 with SMTP id 5614622812f47-3c726096daamsb6e; Mon, 15 Apr 2024 22:12:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYo3UoF6NZ9HPJY8U5ytD5Z2uYWXTn1TOcno/Jf3eMTCtSV8JpX/j/712gDPtBkRPDZkok X-Received: by 2002:a54:448a:0:b0:3c6:efd4:199c with SMTP id v10-20020a54448a000000b003c6efd4199cmr11498788oiv.59.1713244364004; Mon, 15 Apr 2024 22:12:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713244363; cv=none; d=google.com; s=arc-20160816; b=osvRuNnhJUxCAWMd/tEIUfrtZRbM3jWMfQvqzBRbzOeD120ldO4mtdfoQrTCRTva15 XT3JdoTEcbWNdROA6OaeI5a4S4SnDRDEaKXbZexJulYZ3fSa+vbnEJwKNWYAWA7hutE8 bqOD27u5+QBJ2fE9QspZUnSvA7sg7VnPEjq7IyOOnqTzaz8zgpFAMiuPAetW+JnrqHKN nFcng49nR8lBgOpvdLxta3SsWH799uBcbVzNCfqdnYvFySOQC4GjRKbDU6OiW8eRAg2S Vn4Q3qXVUO7q+6UcT7mn1lUFKkoxbIZgpyb84qahF0kzM/6fDRh/l8Uqla+8jmHz8gFO o0Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=0Gponuc1qcetSfFdW18kaLsA5IwY75XRLC8B11k1noE=; fh=dZbs7OdW2ieBo6+PoNybICM0JqsHP1X53GnCLtZWpyw=; b=s3L95eoXCK8q3uZ3U/OpUkMQZxu70PvGfluvb/qyzIRmdoQQHzvUs04y2Vy09mVhsh 8FM1qBlrazSf1oC30t2EjN+55dhbFCqmjQQTqJSR0DPKhi/86hmrQJxHzrXMIhpEpr6t bZNEGOcHv32NZ7sNbBGjiDSzhPwb2MMrhXRCbVFMoLEYcSSRjPPeVlAW5uw2B3z2awby LZ7mp5s28W1aiDRH/RrzkFd75K1yd25N0QngS84xPh5GYav1Hh6sthFO+qHdVq9fOxXV tW8zPVVFXWLFwzoscxzeVfWaTJDTWKNxv3DLBJcPFGhd9tJOy/6LeC2z+0xchAg6EDDe S++w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jT5GMLuY; spf=pass (google.com: domain of developerdong@gmail.com designates 2001:4860:4864:20::34 as permitted sender) smtp.mailfrom=developerdong@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com. [2001:4860:4864:20::34]) by gmr-mx.google.com with ESMTPS id bd4-20020a056808220400b003c614d0a6b2si653326oib.1.2024.04.15.22.12.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 22:12:43 -0700 (PDT) Received-SPF: pass (google.com: domain of developerdong@gmail.com designates 2001:4860:4864:20::34 as permitted sender) client-ip=2001:4860:4864:20::34; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jT5GMLuY; spf=pass (google.com: domain of developerdong@gmail.com designates 2001:4860:4864:20::34 as permitted sender) smtp.mailfrom=developerdong@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-22fa18566adso2309034fac.0 for ; Mon, 15 Apr 2024 22:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713244363; x=1713849163; dara=google.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0Gponuc1qcetSfFdW18kaLsA5IwY75XRLC8B11k1noE=; b=jT5GMLuYgINFfhvBPVsxTg+UrypRl1rOoLM2dmZproBODeiYMty+Vbd/tObCm669oq GHYhI4T82R1LC/WMRi2SJlj6oqm6j8x2uoGBkkmpX2gYQciRhyFFeonafbqh8A5qm6AX QQF9bpZYaKiJUDbzykOC4QHZlfAlUDAfs1XU9HQdvzh9Xiw47q+4ihsSCO9N8pAKAI+D YWY6Ag8H2Eyf65M2ok/uNfqEuYjEw/lLvlxrRBdlLpwHPH7QFxF812vleFGORkxAHWqn VC9LuDgRsKCPKHAy2PmYzVbUlWc8+Qi9pFosqj7hbCYu00c9gu+bTTzwp+m0eSfBtRBC xsjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713244363; x=1713849163; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Gponuc1qcetSfFdW18kaLsA5IwY75XRLC8B11k1noE=; b=kzNg5fVSgHtUrd5wsA8OiuGT19jFm/I2wggGVtie95eqmXDKM3RTGN3cz+x0iWwD8F W8d2HyALU1p8ORQlBrw2KPhFnntwG2O8hxK/Q9gHfUo4Cu/qey6I58oxBDcYrLPhPa47 dAlj1NEBXhfuanD+E2LvB0am81ioNEGx9s6PNNmyVnn4M28NEj1yFpMcryfoHPnBhczZ XflVjOM/qBESZLwwcePN2vJIamMEnvTc76ddAafYfMfYOw3NJJhap7FFF7ZjynA6JeE2 9xm0ASIhm5yAZSFFUKi/+nXNCqFqehvifQYtcZ+AUXN2jRDL8+6UDMYq1EZbwqrO7Exp q94Q== X-Gm-Message-State: AOJu0YyPRc64YwbsYZk3ExvHVRbSS59PNv8Gh+wwd2wVIxVoNbjcnxsq 8+zEdK2RR03J9t9lgy+vctI6W55BpAWnoIJQMOKzE9XbAUpctI9ks3Bg0TspiWs= X-Received: by 2002:a05:6870:f811:b0:229:f988:4305 with SMTP id fr17-20020a056870f81100b00229f9884305mr14629042oab.10.1713244363106; Mon, 15 Apr 2024 22:12:43 -0700 (PDT) Return-Path: Received: from md3knb8c.ad001.siemens.net (45.78.51.22.16clouds.com. [45.78.51.22]) by smtp.gmail.com with ESMTPSA id e18-20020a056a0000d200b006edadf8058asm8073878pfj.23.2024.04.15.22.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 22:12:42 -0700 (PDT) From: Zhibin Dong X-Google-Original-From: Zhibin Dong To: isar-users@googlegroups.com Cc: Zhibin Dong Subject: [PATCH] image: check if the file is core dump Date: Tue, 16 Apr 2024 13:12:22 +0800 Message-Id: <20240416051222.3344127-1-zhibin.dong@siemens.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: PKk1IFGK4/81 The previous code does a wrong judgement in two cases: 1. a file is suffixed by .core but is not a core dump file 2. a file is a core dump file but is not suffixed by .core The new code uses `file` to determine the type of files, which is more accurate. Signed-off-by: Zhibin Dong --- meta/classes/image.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 98741da0..10923947 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -444,7 +444,7 @@ EOSUDO # Sometimes qemu-user-static generates coredumps in chroot, move them # to work temporary directory and inform user about it. - for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do + for f in $(sudo find ${ROOTFSDIR} -type f -exec file {} \; | grep 'core file' | cut -d: -f1); do sudo mv "${f}" "${WORKDIR}/temp/" bbwarn "found core dump in rootfs, check it in ${WORKDIR}/temp/${f##*/}" done -- 2.39.2