* [PATCH] Drop redundant expand=True parameter from getVar
@ 2024-05-24 6:52 srinuvasan.a
2024-05-24 7:27 ` MOESSBAUER, Felix
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: srinuvasan.a @ 2024-05-24 6:52 UTC (permalink / raw)
To: isar-users; +Cc: jan.kiszka, Srinuvasan A
From: Srinuvasan A <srinuvasan.a@siemens.com>
It is long True by default, but people keep adding new cases of this
redundancy, hence fix this one.
Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
meta/recipes-kernel/linux/linux-custom.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
index 0d222332..433ed057 100644
--- a/meta/recipes-kernel/linux/linux-custom.inc
+++ b/meta/recipes-kernel/linux/linux-custom.inc
@@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}"
# Determine cross-profile override
python() {
- if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"):
+ if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"):
d.appendVar("OVERRIDES", ":cross-profile")
}
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Drop redundant expand=True parameter from getVar
2024-05-24 6:52 [PATCH] Drop redundant expand=True parameter from getVar srinuvasan.a
@ 2024-05-24 7:27 ` MOESSBAUER, Felix
2024-05-24 8:38 ` Anton Mikanovich
2024-06-03 6:37 ` [PATCH] " Uladzimir Bely
2 siblings, 0 replies; 6+ messages in thread
From: MOESSBAUER, Felix @ 2024-05-24 7:27 UTC (permalink / raw)
To: isar-users, Arjunan, Srinu; +Cc: Kiszka, Jan
On Fri, 2024-05-24 at 12:22 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> It is long True by default, but people keep adding new cases of this
> redundancy, hence fix this one.
Thanks!
Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> b/meta/recipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@
> d.getVar('BPN').partition('linux-')[2]}"
>
> # Determine cross-profile override
> python() {
> - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in
> d.getVar("OVERRIDES", True).split(":"):
> + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in
> d.getVar("OVERRIDES").split(":"):
> d.appendVar("OVERRIDES", ":cross-profile")
> }
>
> --
> 2.34.1
>
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Drop redundant expand=True parameter from getVar
2024-05-24 6:52 [PATCH] Drop redundant expand=True parameter from getVar srinuvasan.a
2024-05-24 7:27 ` MOESSBAUER, Felix
@ 2024-05-24 8:38 ` Anton Mikanovich
2024-05-27 5:38 ` Srinuvasan Arjunan
2024-05-28 6:20 ` [PATCH v1] " srinuvasan.a
2024-06-03 6:37 ` [PATCH] " Uladzimir Bely
2 siblings, 2 replies; 6+ messages in thread
From: Anton Mikanovich @ 2024-05-24 8:38 UTC (permalink / raw)
To: srinuvasan.a, isar-users; +Cc: jan.kiszka, Felix Moessbauer
24/05/2024 09:52, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> It is long True by default, but people keep adding new cases of this
> redundancy, hence fix this one.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}"
>
> # Determine cross-profile override
> python() {
> - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in d.getVar("OVERRIDES", True).split(":"):
> + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in d.getVar("OVERRIDES").split(":"):
> d.appendVar("OVERRIDES", ":cross-profile")
> }
>
Hello Srinuvasan,
This was already fixed in next by:
7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE")
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Drop redundant expand=True parameter from getVar
2024-05-24 8:38 ` Anton Mikanovich
@ 2024-05-27 5:38 ` Srinuvasan Arjunan
2024-05-28 6:20 ` [PATCH v1] " srinuvasan.a
1 sibling, 0 replies; 6+ messages in thread
From: Srinuvasan Arjunan @ 2024-05-27 5:38 UTC (permalink / raw)
To: isar-users
[-- Attachment #1.1: Type: text/plain, Size: 1622 bytes --]
On Friday, May 24, 2024 at 2:08:44 PM UTC+5:30 Anton Mikanovich wrote:
24/05/2024 09:52, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuv...@siemens.com>
>
> It is long True by default, but people keep adding new cases of this
> redundancy, hence fix this one.
>
> Signed-off-by: Srinuvasan A <srinuv...@siemens.com>
> ---
> meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
b/meta/recipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@
d.getVar('BPN').partition('linux-')[2]}"
>
> # Determine cross-profile override
> python() {
> - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in
d.getVar("OVERRIDES", True).split(":"):
> + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in
d.getVar("OVERRIDES").split(":"):
> d.appendVar("OVERRIDES", ":cross-profile")
> }
>
Hello Srinuvasan,
This was already fixed in next by:
7505bd07 ("linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE")
Hi Anton,
Yes, accidently created patch on master instead of next, sorry
for the inconvenience, but still it's partially fixed in next, i will send
v1 of this patch again.
Thanks,
Srinu
[-- Attachment #1.2: Type: text/html, Size: 2186 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Drop redundant expand=True parameter from getVar
2024-05-24 8:38 ` Anton Mikanovich
2024-05-27 5:38 ` Srinuvasan Arjunan
@ 2024-05-28 6:20 ` srinuvasan.a
1 sibling, 0 replies; 6+ messages in thread
From: srinuvasan.a @ 2024-05-28 6:20 UTC (permalink / raw)
To: isar-users; +Cc: Srinuvasan A
From: Srinuvasan A <srinuvasan.a@siemens.com>
It is long True by default, but people keep adding new cases of this
redundancy, hence fix this one.
Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
meta/recipes-kernel/linux/linux-custom.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
index b53d136c..aef80fbb 100644
--- a/meta/recipes-kernel/linux/linux-custom.inc
+++ b/meta/recipes-kernel/linux/linux-custom.inc
@@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@ d.getVar('BPN').partition('linux-')[2]}"
# Determine cross-profile override
python() {
- if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and bb.utils.to_boolean(d.getVar("ISAR_CROSS_COMPILE")) and "class-native" not in d.getVar("OVERRIDES", True).split(":"):
+ if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and bb.utils.to_boolean(d.getVar("ISAR_CROSS_COMPILE")) and "class-native" not in d.getVar("OVERRIDES").split(":"):
d.appendVar("OVERRIDES", ":cross-profile")
}
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Drop redundant expand=True parameter from getVar
2024-05-24 6:52 [PATCH] Drop redundant expand=True parameter from getVar srinuvasan.a
2024-05-24 7:27 ` MOESSBAUER, Felix
2024-05-24 8:38 ` Anton Mikanovich
@ 2024-06-03 6:37 ` Uladzimir Bely
2 siblings, 0 replies; 6+ messages in thread
From: Uladzimir Bely @ 2024-06-03 6:37 UTC (permalink / raw)
To: srinuvasan.a, isar-users
On Fri, 2024-05-24 at 12:22 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> It is long True by default, but people keep adding new cases of this
> redundancy, hence fix this one.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> b/meta/recipes-kernel/linux/linux-custom.inc
> index 0d222332..433ed057 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@
> d.getVar('BPN').partition('linux-')[2]}"
>
> # Determine cross-profile override
> python() {
> - if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in
> d.getVar("OVERRIDES", True).split(":"):
> + if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> d.getVar("ISAR_CROSS_COMPILE") == "1" and "class-native" not in
> d.getVar("OVERRIDES").split(":"):
> d.appendVar("OVERRIDES", ":cross-profile")
> }
>
> --
> 2.34.1
>
Applied to next, thanks.
--
Best regards,
Uladzimir.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-03 6:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-24 6:52 [PATCH] Drop redundant expand=True parameter from getVar srinuvasan.a
2024-05-24 7:27 ` MOESSBAUER, Felix
2024-05-24 8:38 ` Anton Mikanovich
2024-05-27 5:38 ` Srinuvasan Arjunan
2024-05-28 6:20 ` [PATCH v1] " srinuvasan.a
2024-06-03 6:37 ` [PATCH] " Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox