public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: adriaan.schmidt@siemens.com, Uladzimir Bely <ubely@ilbers.de>,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/1] fix(isar-sstate): continue on missing varvals value
Date: Mon, 22 Jul 2024 14:03:51 +0200	[thread overview]
Message-ID: <20240722120351.656333-1-felix.moessbauer@siemens.com> (raw)

Before operating on the varvals values, we need to check if varvals !=
None.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
This fixes a regression found while applying the "fix expansion of
variables in SRC_URI of dpkg-prebuilt" patch.

Best regards,
Felix

 scripts/isar-sstate | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/isar-sstate b/scripts/isar-sstate
index 4ea38bc8..64511c44 100755
--- a/scripts/isar-sstate
+++ b/scripts/isar-sstate
@@ -869,9 +869,9 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, li
                name in ADDITIONAL_IGNORED_VARNAMES:
                 continue
             # remove leading whitespaces possibly added by appending
-            val = val.lstrip()
-            if not val:
+            if not val or not val.lstrip():
                 continue
+            val = val.lstrip()
 
             if name == 'SRC_URI':
                 src_uri = val.split()
-- 
2.39.2

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240722120351.656333-1-felix.moessbauer%40siemens.com.

             reply	other threads:[~2024-07-22 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 12:03 'Felix Moessbauer' via isar-users [this message]
2024-07-30  8:04 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722120351.656333-1-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox