[PATCH v2 0/1] bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS

[PATCH v2 0/1] bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS

['Benedikt Niedermayr' via isar-users]

This patch basically copies the OE implementation for setting
ZSTD_DEFAULTS and thereby fixes a rebuild in case ZSTD_LEVEL changes
(or ZSTD_COMPRESSION_LEVEL as named by OE).

There is still one question open: Why is ZSTD_THREADS pinned to 1 and
also added to vardepsexclude? It should be sufficient to do one of both
I think. Any comments to that?

Changes in v2:

- Copy the OE implementation for setting ZSTD_DEFAULTS

Benedikt Niedermayr (1):
  bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS

 meta/conf/bitbake.conf | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240725084701.856618-1-benedikt.niedermayr%40siemens.com.

[PATCH v2 1/1] bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS

['Benedikt Niedermayr' via isar-users]

This fixes a rebuild in case ZSTD_LEVEL changes. This is valid since
a different compression level leads to different outputs.

This patch copies the current implementation from OE and thereby
fixing this issue in order to be more aligned with the OE
naming convention.

Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
---
 meta/conf/bitbake.conf | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 4cfa8b10b58b..cda980358fd6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -159,9 +159,10 @@ XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS"
 # Default parallelism for zstd
 ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
 ZSTD_THREADS[vardepvalue] = "1"
-ZSTD_LEVEL ?= "19"
-ZSTD_DEFAULTS ?= "--rsyncable -${ZSTD_LEVEL} --threads=${ZSTD_THREADS}"
-ZSTD_DEFAULTS[vardepsexclude] += "ZSTD_LEVEL ZSTD_THREADS"
+
+ZSTD_COMPRESSION_LEVEL ?= "-3"
+ZSTD_DEFAULTS ?= "--threads=${ZSTD_THREADS} ${ZSTD_COMPRESSION_LEVEL}"
+ZSTD_DEFAULTS[vardepsexclude] = "ZSTD_THREADS"

 # Default compression settings for zchunk
 ZCK_DEFAULTS ?= ""
--
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240725084701.856618-2-benedikt.niedermayr%40siemens.com.

Re: [PATCH v2 0/1] bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS

[Uladzimir Bely]

On Thu, 2024-07-25 at 10:47 +0200, 'Benedikt Niedermayr' via isar-users
wrote:
> This patch basically copies the OE implementation for setting
> ZSTD_DEFAULTS and thereby fixes a rebuild in case ZSTD_LEVEL changes
> (or ZSTD_COMPRESSION_LEVEL as named by OE).
> 
> There is still one question open: Why is ZSTD_THREADS pinned to 1 and
> also added to vardepsexclude? It should be sufficient to do one of
> both
> I think. Any comments to that?
> 
> Changes in v2:
> 
> - Copy the OE implementation for setting ZSTD_DEFAULTS
> 
> Benedikt Niedermayr (1):
>   bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS
> 
>  meta/conf/bitbake.conf | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> --
> 2.34.1
> 

Applied to next, thanks.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/e4a5356854099c027c26236f27e2c7af5f72b96b.camel%40ilbers.de.