From: "'Benedikt Niedermayr' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Subject: [PATCH v2 1/1] bitbake.conf: fix vardepsexclude for ZSTD_DEFAULTS
Date: Thu, 25 Jul 2024 10:47:01 +0200 [thread overview]
Message-ID: <20240725084701.856618-2-benedikt.niedermayr@siemens.com> (raw)
In-Reply-To: <20240725084701.856618-1-benedikt.niedermayr@siemens.com>
This fixes a rebuild in case ZSTD_LEVEL changes. This is valid since
a different compression level leads to different outputs.
This patch copies the current implementation from OE and thereby
fixing this issue in order to be more aligned with the OE
naming convention.
Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
---
meta/conf/bitbake.conf | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 4cfa8b10b58b..cda980358fd6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -159,9 +159,10 @@ XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS"
# Default parallelism for zstd
ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
ZSTD_THREADS[vardepvalue] = "1"
-ZSTD_LEVEL ?= "19"
-ZSTD_DEFAULTS ?= "--rsyncable -${ZSTD_LEVEL} --threads=${ZSTD_THREADS}"
-ZSTD_DEFAULTS[vardepsexclude] += "ZSTD_LEVEL ZSTD_THREADS"
+
+ZSTD_COMPRESSION_LEVEL ?= "-3"
+ZSTD_DEFAULTS ?= "--threads=${ZSTD_THREADS} ${ZSTD_COMPRESSION_LEVEL}"
+ZSTD_DEFAULTS[vardepsexclude] = "ZSTD_THREADS"
# Default compression settings for zchunk
ZCK_DEFAULTS ?= ""
--
2.34.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240725084701.856618-2-benedikt.niedermayr%40siemens.com.
next prev parent reply other threads:[~2024-07-25 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 8:47 [PATCH v2 0/1] " 'Benedikt Niedermayr' via isar-users
2024-07-25 8:47 ` 'Benedikt Niedermayr' via isar-users [this message]
2024-07-31 6:45 ` Uladzimir Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725084701.856618-2-benedikt.niedermayr@siemens.com \
--to=isar-users@googlegroups.com \
--cc=benedikt.niedermayr@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox