public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps
@ 2024-07-31 15:16 'Felix Moessbauer' via isar-users
  2024-08-01  6:12 ` Anton Mikanovich
  0 siblings, 1 reply; 4+ messages in thread
From: 'Felix Moessbauer' via isar-users @ 2024-07-31 15:16 UTC (permalink / raw)
  To: isar-users; +Cc: adriaan.schmidt, Felix Moessbauer

The python3-distutils package currently does not exist in debian trixie,
breaking the build. While debugging this, I noticed that this dependency
seems to be no longer needed.

This patch removes the wic dependency python3-distutils

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/conf/distro/debian-common.conf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
index d8556964..8c6a3f63 100644
--- a/meta/conf/distro/debian-common.conf
+++ b/meta/conf/distro/debian-common.conf
@@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \
                        dosfstools \
                        mtools \
                        e2fsprogs \
-                       python3-distutils \
                        bmap-tools \
                        tar \
                        fdisk"
-- 
2.39.2

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20240731151644.213693-1-felix.moessbauer%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps
  2024-07-31 15:16 [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps 'Felix Moessbauer' via isar-users
@ 2024-08-01  6:12 ` Anton Mikanovich
  2024-08-01  6:16   ` 'MOESSBAUER, Felix' via isar-users
  0 siblings, 1 reply; 4+ messages in thread
From: Anton Mikanovich @ 2024-08-01  6:12 UTC (permalink / raw)
  To: Felix Moessbauer, isar-users; +Cc: adriaan.schmidt, Kiszka, Jan

31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote:
> The python3-distutils package currently does not exist in debian trixie,
> breaking the build. While debugging this, I noticed that this dependency
> seems to be no longer needed.
>
> This patch removes the wic dependency python3-distutils
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/conf/distro/debian-common.conf | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf
> index d8556964..8c6a3f63 100644
> --- a/meta/conf/distro/debian-common.conf
> +++ b/meta/conf/distro/debian-common.conf
> @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \
>                          dosfstools \
>                          mtools \
>                          e2fsprogs \
> -                       python3-distutils \
>                          bmap-tools \
>                          tar \
>                          fdisk"

Hello Felix,

The same fix was already sent by Jan in the patch:

[PATCH] debian-common: Drop python3-distutils dependency

but your patch looks cleaner because of endline changes.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/26ee75ae-0103-4e9c-a57a-85d9a89aabb0%40ilbers.de.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps
  2024-08-01  6:12 ` Anton Mikanovich
@ 2024-08-01  6:16   ` 'MOESSBAUER, Felix' via isar-users
  2024-08-01  6:38     ` 'Jan Kiszka' via isar-users
  0 siblings, 1 reply; 4+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2024-08-01  6:16 UTC (permalink / raw)
  To: amikan, isar-users; +Cc: Schmidt, Adriaan, Kiszka, Jan

On Thu, 2024-08-01 at 09:12 +0300, Anton Mikanovich wrote:
> 31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote:
> > The python3-distutils package currently does not exist in debian
> > trixie,
> > breaking the build. While debugging this, I noticed that this
> > dependency
> > seems to be no longer needed.
> > 
> > This patch removes the wic dependency python3-distutils
> > 
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >   meta/conf/distro/debian-common.conf | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/meta/conf/distro/debian-common.conf
> > b/meta/conf/distro/debian-common.conf
> > index d8556964..8c6a3f63 100644
> > --- a/meta/conf/distro/debian-common.conf
> > +++ b/meta/conf/distro/debian-common.conf
> > @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \
> >                          dosfstools \
> >                          mtools \
> >                          e2fsprogs \
> > -                       python3-distutils \
> >                          bmap-tools \
> >                          tar \
> >                          fdisk"
> 
> Hello Felix,
> 
> The same fix was already sent by Jan in the patch:
> 
> [PATCH] debian-common: Drop python3-distutils dependency

Ah ok. I overlooked this.

> 
> but your patch looks cleaner because of endline changes.

Then let's just merge this and drop the one from Jan.

Felix

> 

-- 
Siemens AG, Technology
Linux Expert Center


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/4d40fb5fa264f1ee3cae1772f5ef5227a4eba3f7.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps
  2024-08-01  6:16   ` 'MOESSBAUER, Felix' via isar-users
@ 2024-08-01  6:38     ` 'Jan Kiszka' via isar-users
  0 siblings, 0 replies; 4+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2024-08-01  6:38 UTC (permalink / raw)
  To: Moessbauer, Felix (T CED OES-DE), amikan, isar-users
  Cc: Schmidt, Adriaan (T CED EDC-DE)

On 01.08.24 08:16, Moessbauer, Felix (T CED OES-DE) wrote:
> On Thu, 2024-08-01 at 09:12 +0300, Anton Mikanovich wrote:
>> 31/07/2024 18:16, 'Felix Moessbauer' via isar-users wrote:
>>> The python3-distutils package currently does not exist in debian
>>> trixie,
>>> breaking the build. While debugging this, I noticed that this
>>> dependency
>>> seems to be no longer needed.
>>>
>>> This patch removes the wic dependency python3-distutils
>>>
>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>>> ---
>>>   meta/conf/distro/debian-common.conf | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/conf/distro/debian-common.conf
>>> b/meta/conf/distro/debian-common.conf
>>> index d8556964..8c6a3f63 100644
>>> --- a/meta/conf/distro/debian-common.conf
>>> +++ b/meta/conf/distro/debian-common.conf
>>> @@ -18,7 +18,6 @@ IMAGER_INSTALL:wic += "parted \
>>>                          dosfstools \
>>>                          mtools \
>>>                          e2fsprogs \
>>> -                       python3-distutils \
>>>                          bmap-tools \
>>>                          tar \
>>>                          fdisk"
>>
>> Hello Felix,
>>
>> The same fix was already sent by Jan in the patch:
>>
>> [PATCH] debian-common: Drop python3-distutils dependency
> 
> Ah ok. I overlooked this.
> 
>>
>> but your patch looks cleaner because of endline changes.
> 
> Then let's just merge this and drop the one from Jan.
> 

Mine provides clear reasoning AND cleans up the file :)

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/3ce1b20e-975c-4803-9b57-40dad06d916d%40siemens.com.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-08-01  6:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-31 15:16 [PATCH 1/1] fix: remove not-needed python3-distutils from wic deps 'Felix Moessbauer' via isar-users
2024-08-01  6:12 ` Anton Mikanovich
2024-08-01  6:16   ` 'MOESSBAUER, Felix' via isar-users
2024-08-01  6:38     ` 'Jan Kiszka' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox