From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 11 Oct 2024 12:01:16 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pf1-f190.google.com (mail-pf1-f190.google.com [209.85.210.190]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49BA1Ek8008825 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 Oct 2024 12:01:15 +0200 Received: by mail-pf1-f190.google.com with SMTP id d2e1a72fcca58-71e479829c8sf69278b3a.0 for ; Fri, 11 Oct 2024 03:01:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1728640869; cv=pass; d=google.com; s=arc-20240605; b=CaUyqdwq91+XznfWxCMlqFRr8C/hc0uho5JdOa1DUvYWtqCL66o1qG92AiZe3ervPE YcyD+W9smO/hEaTlEtFVxvegnXGVoSocNK97sIhpBWXjbkZbDX8KI6Fg4Td+GO6xudhU f/yV4A8GXaQNJDcodzL2E4Xctcgx09J2hiOi5h4vk0+6yKOqXiqhTWEXWNrGfpF8SL+r wB3N2RAkdC5gCSIPtobAo7k2Rrppzqwffnd2VudismRV3+9WNu/5e0ftF8f/HUaQsYXA 9ymcgujm+kikY03Ebh3HFPeu7XIIQ/+6cGBhZys52Cv/DljFuniDvr5C+ncUbeCDbaas nLig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=9t6Vq2p5F4BD42580+9liNuY6lsX1MbLkM9lTwu5Zd4=; fh=td4L19Ssq72uSG0yA85u0QrzTjGcEyBiLN/LKNs448A=; b=U/4Dm//ZDe7SaD0MjltEHe9rfvM3Afirc/8lWxu1hJVVxGdEE6iDGL9wysY3rV5h3t UL0TAPzHAd69r7mRbHvYg8cRDJy486Ra45fZMT6TD3kDFSEJdkJdsBAWEYZDx3sbWUQt SrR7W2qspUpI5TIZan7W2fCDN3DgeKDIG3tojx4/G0qo0pvH6gqTStuyPgrrrEw/HNNZ 0JJZJeeo8ZvbNpRCDhkzylDaZnhpiv8/w7lLtTIhsJTmCyK1UWy1SjoqZyzbyTAnzlnX kN76Qb3K5FKIQnAsiTIfJA9rswaPhrRx/h/S5QKp3gBjM4+jkDzXaO5ZsvicsfsUbSNL UsDw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1728640869; x=1729245669; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=9t6Vq2p5F4BD42580+9liNuY6lsX1MbLkM9lTwu5Zd4=; b=g1FHiCKZpALw0p5ffLsvLx4vVTaOmAiHaiiVDQ7wtR9XmzFdhOxwvTqEBUZ17Cxjyq fPBTY4gVIzSpx88Gf9Nl6NbQGokNtJ9wsDCOmQ+XUQRYxtUySaM/P5MkPD71XO2sfKpR Af7gq8g1QaklKUkbEOiItk3VuyuuxIhE30m2iXDP595FNdTtVt36fJsjaCt65VEQMaDm ExJMh6gT4ZqiOPkamMz2YLHP1LTa0yNhafgJQUArWf9GYnyLF5GtspTubFyJ5rS2bL4a FupYag327Z+fHgA87JQAV53DtDnrRbrLiBT/3795RQxyfvn4IwGvqMX3qMO2ynWsAmEK Zrhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728640869; x=1729245669; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=9t6Vq2p5F4BD42580+9liNuY6lsX1MbLkM9lTwu5Zd4=; b=c2Gq77rSTJ2NauJQyg5EixMs0Adqy0MxMgPtRYp0OLAXJFHjI2lixlgV+9+5bv1zXy DuyaFuHWcybao4jxdqieVaX6hrlFObrJDcT1aKN4/qR7NJkRbHbJFhZcyZa3/dmiyK30 AtdVHRmfo/n4o70UQhiS9z4UXDLxVgom2cbTpBd2yCiDMamWI7GQEr4jW6TnUax3xH0c CM5NKKCmFc04ViMybGZzKBk8f6WhMcImBCq7jHZ6N2dT47HdCXBbhpXeFx0uRl69GDTo oMG4Vg4/VTxbX+qnTqbf7FvkqCnwgO+MfhdIPB3/0F2tovpMrurElERitpeOJRtIurao 2qKQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXJcQZnse9pKfjMjpAKAtJy+KP78L1wtiVlm6DQ9Bl43cThA/ah9xqkLel5wIcxu5o2NKB3@ilbers.de X-Gm-Message-State: AOJu0YzIQwyMf9suChTMsLsWbw8lZx++8I4Onh+Gg5A4qmnD0XsuYaiI MuE0lUQf4xkAsWMq/+89zTVu2jxEkB1rViV6kBbSwRdI23zmV7PQ X-Google-Smtp-Source: AGHT+IGX93FLV9vOY4cv/ZvZgZjBK/MS+817W+zPdqI+/T8RMtHZZUoZkykqd6JgJW0OvA5YelxlcA== X-Received: by 2002:a05:6a21:1786:b0:1cf:6533:5c86 with SMTP id adf61e73a8af0-1d8bcf41d86mr2785345637.21.1728640869165; Fri, 11 Oct 2024 03:01:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:8a15:b0:2e0:79a0:bd97 with SMTP id 98e67ed59e1d1-2e2c81f42edls1377046a91.0.-pod-prod-01-us; Fri, 11 Oct 2024 03:01:08 -0700 (PDT) X-Received: by 2002:a17:90b:33d1:b0:2e2:acd7:1df0 with SMTP id 98e67ed59e1d1-2e2f0dd5ec3mr2209444a91.41.1728640867891; Fri, 11 Oct 2024 03:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728640867; cv=none; d=google.com; s=arc-20240605; b=i0939hr1TkVh478/mmRnaY6xoOC5Yt8sANZ8sNQgviq8W9XG4N1tKU59XMxN1/galU lG3gCNEH0Mv4fBbYxWAfhp94GJtBvRLdFKgNyZJ8sst8sAFoKGZk2HqjlpFis7AlSu/5 oUg/lOUceYYiEwo5XtVz6k8yMKD+MDgj3aVtZ0T3YtMIwQZjQMioo080gYxa7d5gonjH du3ipZSha/xQZMegXT6r1X9E3YUXTbSQ49oX7z3I3I3kGP3l9sGJNJFiq4VuIXMn578f R+nEQ7CsamAfFsRwn7mavQTEmM4tzAYnubtVhNbVItezAKINhSFtcjSulOymQRzOH9/L rahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=4YD3qD9Hl9OR7+d5AooDuYg4c93EVDoah5pZUp32DTw=; fh=/h9QQkzJ8EboVkWg45aWwpaUro6WMavIVd2OhN45RtE=; b=EXqIZI7b/hvTCK4C/TiKuxF7f3Bb0tcUoqhTSZChhn/wxIQXSPlRXy6MXqd82VArQu 4W8fpyeFt2qgBqxs9R/HrmVjXPtQLAPuBIIJeXoql/w7p8cLE8FGQcsikjpcziNH/mk8 dcsUHCGU9TOG4kLM/zRIy1r0T+UfBigJtQqeyM8GkoiG3hBU3rvaJeZoGREytPH091/P 5ctmKyyKfFxhMvw2YrBsp1uGGWgkebletjfwAD7wRlupdM8RQI0/X9iqUID7Suvef1b1 PpwMGpGRaXfkLawZCR8Ot7O9XGD27lCKWbsVR0z4K/b95FcYjUggholsVqfk1ZLNuRad lzfA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 98e67ed59e1d1-2e2cc1d9c1bsi281971a91.0.2024.10.11.03.01.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Oct 2024 03:01:07 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from user-B660.promwad.corp ([159.148.83.114]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49BA0vWP008632 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Oct 2024 12:01:05 +0200 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH v3 8/8] image: Do not call rootfs_do_umounts twice Date: Fri, 11 Oct 2024 13:00:50 +0300 Message-Id: <20241011100050.322686-9-amikan@ilbers.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241011100050.322686-1-amikan@ilbers.de> References: <20241011100050.322686-1-amikan@ilbers.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: +797/cwO8DPt As now every rootfs_do_mounts should be followed by rootfs_do_umounts in the same task, there is no need in calling umount inside do_rootfs_finalize. Signed-off-by: Anton Mikanovich --- RECIPE-API-CHANGELOG.md | 6 ++++++ meta/classes/image.bbclass | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md index 608d0cc3..56ebfeb7 100644 --- a/RECIPE-API-CHANGELOG.md +++ b/RECIPE-API-CHANGELOG.md @@ -674,3 +674,9 @@ always outputs a warning if mounts are left behind after the build. Bitbake exit status depends on ISAR_FAIL_ON_CLEANUP bitbake variable: - 0 or unset: Output a warning, unmount, build succeeds (default). - 1: Output a warning, keep mounts left behind, build fails. + +### Stricter rootfs mounts management + +rootfs_do_umounts is not called from do_rootfs_finalize anymore. + +Every individual task that does mounting must also do the umounting at its end. diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 1eb974e8..472df3cf 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -405,8 +405,6 @@ def apt_list_files(d): IMAGE_LISTS = "${@ ' '.join(apt_list_files(d)) }" do_rootfs_finalize() { - rootfs_do_umounts - sudo -s <<'EOSUDO' set -e -- 2.34.1 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20241011100050.322686-9-amikan%40ilbers.de.