public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "srinuvasan.a via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, srinuvasan <srinuvasan.a@siemens.com>
Subject: [PATCH] meta/classes/sdk: use rootfs_do_umounts to unmount the filesystem
Date: Fri, 17 Jan 2025 19:55:13 +0530	[thread overview]
Message-ID: <20250117142513.264551-1-srinuvasan.a@siemens.com> (raw)

From: srinuvasan <srinuvasan.a@siemens.com>

Use the rootfs_do_umounts function instead of duplicating the unmount
filesystem.

Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
---
 meta/classes/sdk.bbclass | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index c69f7096..46436d97 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -90,16 +90,8 @@ sdkchroot_configscript () {
 
 ROOTFS_POSTPROCESS_COMMAND:append:class-sdk = " sdkchroot_finalize"
 sdkchroot_finalize() {
-    mountpoint -q "${ROOTFSDIR}/dev/pts" && \
-        sudo umount "${ROOTFSDIR}/dev/pts"
-    mountpoint -q "${ROOTFSDIR}/dev/shm" && \
-        sudo umount "${ROOTFSDIR}/dev/shm"
-    mountpoint -q "${ROOTFSDIR}/dev" && \
-        sudo umount "${ROOTFSDIR}/dev"
-    mountpoint -q "${ROOTFSDIR}/proc" && \
-        sudo umount "${ROOTFSDIR}/proc"
-    mountpoint -q "${ROOTFSDIR}/sys" && \
-        sudo umount "${ROOTFSDIR}/sys"
+
+    rootfs_do_umounts
 
     # Remove setup scripts
     sudo rm -f ${ROOTFSDIR}/chroot-setup.sh ${ROOTFSDIR}/configscript.sh
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250117142513.264551-1-srinuvasan.a%40siemens.com.

             reply	other threads:[~2025-01-17 14:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 14:25 srinuvasan.a via isar-users [this message]
2025-01-27 13:28 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117142513.264551-1-srinuvasan.a@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=srinuvasan.a@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox