public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Benedikt Niedermayr' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: felix.moessbauer@siemens.com
Subject: [PATCH 0/1] deb-dl-dir: fix package source download
Date: Wed, 22 Jan 2025 14:49:06 +0100	[thread overview]
Message-ID: <20250122134907.2826754-1-benedikt.niedermayr@siemens.com> (raw)

I recently wanted to download all source packages for a specific image and encountered
that some of the source packages were missing (e.g. adduser).

I tracked the issue down to the deb-dl-dir.bbclass and found that the
"is_not_part_of_current_build" function skipped the source package download
because the "adduser" package was not listed in the "/var/log/dpkg.log" file.

I assume that this package has been installed during early debootstrap
and therefore the package is not listed in the dpkg.log file.

I'm not sure if I got the comment in the function right:

"Since we are parsing all the debs in DEBDIR, we can to some extend
try to eliminate some debs that are not part of the current multiconfig
build using the below method"

AFAIK we could also achieve this by running dpkg-query commands on the target
filesystem and also catch the packages that have been installed during bootstrap.

I'm not sure if this patch will interfere in any way with multiconfig builds,
as mentioned in the comment above, but I think it's worth a try.

Benedikt Niedermayr (1):
  deb-dl-dir: fix package source download

 meta/classes/deb-dl-dir.bbclass | 39 ++++++++++-----------------------
 1 file changed, 11 insertions(+), 28 deletions(-)

--
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250122134907.2826754-1-benedikt.niedermayr%40siemens.com.

             reply	other threads:[~2025-01-22 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 13:49 'Benedikt Niedermayr' via isar-users [this message]
2025-01-22 13:49 ` [PATCH 1/1] " 'Benedikt Niedermayr' via isar-users
2025-01-22 14:00   ` 'Jan Kiszka' via isar-users
2025-01-22 14:37     ` 'Niedermayr, BENEDIKT' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122134907.2826754-1-benedikt.niedermayr@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=benedikt.niedermayr@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox