public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH v2 3/3] installer: Run in unattended mode only on ttyS0
Date: Tue, 18 Mar 2025 09:10:05 +0300	[thread overview]
Message-ID: <20250318061300.12805-4-ubely@ilbers.de> (raw)
In-Reply-To: <20250318061300.12805-1-ubely@ilbers.de>

This fixes race between two unattended installer instances running
on serial "ttyS0" and graphic "tty1" terminals.

While one of them starts writing the disk, another one fails
and schedules reboot in 60 seconds. Depending on build machine
performance we can get incomplete installation and broken target
filesystem.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 .../deploy-image/files/usr/bin/deploy-image-wic.sh          | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index 7f552eee..bd580694 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -10,6 +10,12 @@ SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; )
 
 . ${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh
 
+if $installer_unattended; then
+    if [ "$(tty)" != "/dev/ttyS0" ]; then
+        echo "Disable unattended mode on $(tty), it's active on /dev/ttyS0"
+        installer_unattended=0
+    fi
+fi
 
 if ! $installer_unattended; then
     installer_image_uri=$(find "$installdata" -type f -iname "*.wic*" -a -not -iname "*.wic.bmap" -exec basename {} \;)
-- 
2.45.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250318061300.12805-4-ubely%40ilbers.de.

  parent reply	other threads:[~2025-03-18  6:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  6:10 [PATCH v2 0/3] Fixes for unattended installation Uladzimir Bely
2025-03-18  6:10 ` [PATCH v2 1/3] meta-isar: Use to_boolean for INSTALLER_UNATTENDED variable Uladzimir Bely
2025-03-18  6:10 ` [PATCH v2 2/3] testsuite: Disable "snapshot" feature for installer image Uladzimir Bely
2025-03-18  6:10 ` Uladzimir Bely [this message]
2025-03-18  6:25   ` [PATCH v2 3/3] installer: Run in unattended mode only on ttyS0 'Jan Kiszka' via isar-users
2025-03-18  6:29     ` 'Jan Kiszka' via isar-users
2025-03-18  6:33       ` Uladzimir Bely
2025-03-18  7:08         ` 'Jan Kiszka' via isar-users
2025-03-18  7:51           ` Uladzimir Bely
2025-03-18  8:13             ` Uladzimir Bely
2025-03-18  6:37     ` Uladzimir Bely
2025-03-18  7:09       ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318061300.12805-4-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox