public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH v3 1/4] meta-isar: Use to_boolean for INSTALLER_UNATTENDED variable
Date: Tue, 18 Mar 2025 17:02:14 +0300	[thread overview]
Message-ID: <20250318140622.13676-2-ubely@ilbers.de> (raw)
In-Reply-To: <20250318140622.13676-1-ubely@ilbers.de>

Existing implementation treated INSTALLER_UNATTENDED = "0" like
it was enabled.

See also commit 29bb5a5c.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta-isar/recipes-core/images/isar-image-installer.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-isar/recipes-core/images/isar-image-installer.bb b/meta-isar/recipes-core/images/isar-image-installer.bb
index ee04bb41..db379f5d 100644
--- a/meta-isar/recipes-core/images/isar-image-installer.bb
+++ b/meta-isar/recipes-core/images/isar-image-installer.bb
@@ -13,7 +13,7 @@ WKS_FILE = "${INSTALLER_WKS_FILE}"
 
 ADDITIONAL_KERNEL_CMDLINE ??= ""
 
-OVERRIDES .= "${@':unattended-installer' if d.getVar('INSTALLER_UNATTENDED') else ''}"
+OVERRIDES .= "${@':unattended-installer' if bb.utils.to_boolean(d.getVar('INSTALLER_UNATTENDED')) else ''}"
 ADDITIONAL_KERNEL_CMDLINE:append:unattended-installer = " \
     installer.unattended \
     installer.image.uri=/install/${IMAGE_DATA_FILE}.${IMAGE_DATA_POSTFIX} \
-- 
2.45.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250318140622.13676-2-ubely%40ilbers.de.

  reply	other threads:[~2025-03-18 14:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 14:02 [PATCH v3 0/4] Fixes for unattended installation Uladzimir Bely
2025-03-18 14:02 ` Uladzimir Bely [this message]
2025-03-18 14:02 ` [PATCH v3 2/4] testsuite: Disable "snapshot" feature for installer image Uladzimir Bely
2025-03-18 14:02 ` [PATCH v3 3/4] Installer: allow to set custom TTYs for installer Uladzimir Bely
2025-03-18 21:25   ` 'Jan Kiszka' via isar-users
2025-03-18 14:02 ` [PATCH v3 4/4] installer: Run unattended mode on the only terminal Uladzimir Bely
2025-03-18 21:39   ` 'Jan Kiszka' via isar-users
2025-03-19  9:15     ` Uladzimir Bely
2025-03-19 10:13     ` Uladzimir Bely
2025-03-24  9:20 ` [PATCH v3 0/4] Fixes for unattended installation Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318140622.13676-2-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox