From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 25 Jun 2025 15:55:05 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f189.google.com (mail-qt1-f189.google.com [209.85.160.189]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 55PDswax005676 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Jun 2025 15:54:58 +0200 Received: by mail-qt1-f189.google.com with SMTP id d75a77b69052e-4a799f5b463sf17658561cf.1 for ; Wed, 25 Jun 2025 06:54:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1750859692; cv=pass; d=google.com; s=arc-20240605; b=UDwZmX/xTcBbesvh/2mUkmxuszWzo0TokdrPc/JRm8zYiDOZUTwtMMi3tWdfxMz+5v 7b1vSqs5qdVyBN40kYGRMhl/roKXp9miCdqw8TDOycZ28gJJqtH8Hb8DnfW9/wZAVkoJ g0g3ll6GIVCLNUbGAVqZxiprV4+4hab78LAM3LIV8r4jWtjKW1xeaA5gDhFk36Mm9vVt r3c7EXHZl266B6ph1IBCLw/6IRgLdBFO5/0snYP+zTkqo3xhh2xsg0lqWc2eSGhIPMj+ zNVarFPac6By1AqOLc7Qrp5/k22K2GNrz9tDQVBrnb1rwp2GTX2GmPPVUPzY/Omh4QrZ m+ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IJi8g88oM8tJ7PE8DMO8jko/J/toMn3jOgd9p6H24IU=; fh=CKmAr9MfwR/FMwIf49Z906HNnSgnwI9dGkIhFJqIB3U=; b=HKqSP4Jgw0NWESrP9gEkarbYoXvo1lxqcRAKLASGx6JqweTIw/YaLM9T6DbIvxun3e bVPupmIOUVbZhMOxeIuvZd/W6p3u97LkiYo+BoSlLG555QpwsL1sBWvmOmHK2CcdB+Qn uutjc9ZhcPB/PCKVdbBjnw6IFvHV6wj9h3I8UFD14TAVB1hDLhtoPfl9fZkz8rkcMKKP b0bqJGqo8hUh9SKYYwgJakLy/L8RE2dqXs9jVT6oJYhiCKJZoPwLzaB9FSvdZgimFbqi PjnisFn13CiGuAeBI73kGjJ3xYls163seS3+Wm+70S72Qjjzxp4ZEFu/OGGwWY7lMQo5 L4lg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=YfYGOflf; spf=pass (google.com: domain of fm-1047747-20250625135447de70a26571b1078d1d-vx98ok@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1047747-20250625135447de70a26571b1078d1d-VX98oK@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1750859692; x=1751464492; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=IJi8g88oM8tJ7PE8DMO8jko/J/toMn3jOgd9p6H24IU=; b=ETd7451N8q4cHtTdrLqxchnQWLs7u8KlZs8VjeI+8zEcoOSQ6xOkiAjc/XDHjyLH4T P5OhCoq94duJ4NJc1kh0nJJ/sjXLX1RWAKMagfkV6OfEVuTLPdrC0Xr+bIG+PhCSmki3 1hWdwNISQTtTrtsIrJ5ML835AMWNxlrzAa5Zsa37CWDsFKfaVS3vaNS72M2YTzt3kMHl MOS+RPoc2vYYBpxxQ5Fpjecjkw+nkBtxnxFw3ic3pnid9wXMxJKoW8NRQdYwbTVznkBe ig4Ad7YF2+wC1zN8p4QWOEge4Uv4D9a6UOGPWEgzuarnJ/v/9/p7PjEm/yUUkFPxv6hO otfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750859692; x=1751464492; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IJi8g88oM8tJ7PE8DMO8jko/J/toMn3jOgd9p6H24IU=; b=cOtxPoYyQb+Y5r5Hno2dLR6MPm+nNXldPDXx9bcfaUT7uQK/yCiqkBYeCz1b0admiM vVR6IVkVPU78G/H+P+7GHeuKgm/YcQsIrjYByL40Xq2tX4RDcfO7MXJcDlOymvs7aNrN YGeEU5QJuiK+HHdCm/MEObbvTNxLBjSVAWI6dzAw3nwJyyryMxxRSAoS0of1foiCMMJj LwScgwEhnHA77J7+4F+xSMpzxmnd+CdMDX/hviVI2xibgyUMDhWOsstMIY6pqOw4k581 8QsMmNTLi+e7Uek3Vfcmdf/njkEe5pmi7SEk1sFyHZkofFtqlYsHZVqvcfqjlvvt7obw oOQQ== X-Forwarded-Encrypted: i=2; AJvYcCXh4zBP7NrRtZkaglWc+B4T6p66E+A8rCmfePgkGp6dQFoEYhwE7aFqcBNqHzdvt4nOsNBT@ilbers.de X-Gm-Message-State: AOJu0YyZ/lRdzBc3TfePM1Bdxx223cnqvNtIJz4/tPG3eWFciVbN8NkH DsQuuUoQBCgv5aSpMRh8jLRqFyHvL6nLX0ljcgy738f6txSG7olh5HG5 X-Google-Smtp-Source: AGHT+IG6+3WQXESLvLfdDF4T3YvXOeyQ5xYoCSMWiKKx8o5t2Oqh9zO7IPsWSDkIf1pPCJ62dD1eFQ== X-Received: by 2002:ac8:5783:0:b0:4a7:6408:b449 with SMTP id d75a77b69052e-4a7c121b9ddmr44570271cf.2.1750859691879; Wed, 25 Jun 2025 06:54:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZdjpm/MTUTU0yQ2w1lPfqmil7dQcCvkutKrqMcyS7HoZw== Received: by 2002:a05:622a:58c5:b0:476:6eec:3aa5 with SMTP id d75a77b69052e-4a76f278ebdls111993471cf.0.-pod-prod-00-us; Wed, 25 Jun 2025 06:54:51 -0700 (PDT) X-Received: by 2002:a05:622a:250d:b0:494:731c:8746 with SMTP id d75a77b69052e-4a7ae9e44f4mr116061721cf.23.1750859690883; Wed, 25 Jun 2025 06:54:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750859690; cv=none; d=google.com; s=arc-20240605; b=VpoNt7r//3nF1ias6f+9mzGdx6sApjRD1zAyaLVghoYKz76FvdxjCZyPjgbxXAcrV5 ld1/xu94AQydqDQuyf4nE6wVAlnzx2c+KPAAzQV6+JtxpVROSu1uLTT+FwHTg0TyB0Ze lgA5UQ+79ew79e0Axo3PRGSqHem9ENVrFAjX7JNQempmtpOst15iROR+RV6RCsjA68vz kztKzd6GP1dL1+RoVlKW3DuKMP4yCq8JxjoZihbDiK7qrw4zVq8hEofGLuRgzofJo9cX A1gKAvfwuNWnVxXGUJ4bted3bpO7Ea161m7CdVi0vn9zGoWEZsCM9Fqv22P1l7p9Fk6g no2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=tcn7FT9mB654HNUfoYPdvg+FVqV/AGiiHo7Imi1nIio=; fh=nuVAnAKFXZ/c71OwrdWzSuwNyXL8JbkZbL1MQ1Fe+gs=; b=hoiK1SUdJmxreQvO2/L1KK89t9SGqOQpOQ/+2+JBVF0z+rmi7mPU6OYG93o+eyr4Iy tDIQbMC5BAgQ8+ON0Zj5SD0ces58JbQaCvobORn7VrpzAm4T4q6opq9Zam6QM6R73vU5 0XQeMpaUWCzmTRBW36+Ui3Gb5vsUG94pFIHQK8XD/lIkjctDBSpAKIJAwVAb2cRlajNU 0n/oy8HXi0XDFffTHIpWmtReKNFCvkpQdRax8VPiObYQlS9m4FvyrTtJ8CCX8nkSAMUg eeah9v+PwLcwdhtVkcvELeDzIPTiC4mYhUZup2Zl8y/vLR1lbAAmoKi1WdhxSh0E0WR0 L3ig==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=YfYGOflf; spf=pass (google.com: domain of fm-1047747-20250625135447de70a26571b1078d1d-vx98ok@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1047747-20250625135447de70a26571b1078d1d-VX98oK@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id d75a77b69052e-4a779cf1538si4983921cf.0.2025.06.25.06.54.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2025 06:54:50 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1047747-20250625135447de70a26571b1078d1d-vx98ok@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 20250625135447de70a26571b1078d1d for ; Wed, 25 Jun 2025 15:54:47 +0200 From: "'Clara Kowalsky' via isar-users" To: isar-users@googlegroups.com Cc: jan.kiszka@siemens.com, Clara Kowalsky Subject: [PATCH 1/2] container_fetcher: Fix missing checksum warning Date: Wed, 25 Jun 2025 15:54:41 +0200 Message-ID: <20250625135442.1420977-1-clara.kowalsky@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1047747:519-21489:flowmailer X-Original-Sender: clara.kowalsky@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=YfYGOflf; spf=pass (google.com: domain of fm-1047747-20250625135447de70a26571b1078d1d-vx98ok@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1047747-20250625135447de70a26571b1078d1d-VX98oK@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Clara Kowalsky Reply-To: Clara Kowalsky Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ILMJe7bHAqww In case only a tag is specified for a container image in the SRC_URI and no digest, a warning should be issued with the recommendation to add the digest of the container image. So far, the number specified in the warning would be the checksum of the manifest.json, which is a metadata file. However, we want to show the registry digest, which is calculated over the complete image content. In addition, reading the manifest.json does not work at this point anyway, as skopeo has already packed it into a Docker archive. Signed-off-by: Clara Kowalsky --- meta/lib/container_fetcher.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/meta/lib/container_fetcher.py b/meta/lib/container_fetcher.py index 0d659154..16467abb 100644 --- a/meta/lib/container_fetcher.py +++ b/meta/lib/container_fetcher.py @@ -6,6 +6,7 @@ import oe.path import os import tempfile +import json from bb.fetch2 import FetchMethod from bb.fetch2 import logger from bb.fetch2 import MissingChecksumEvent @@ -60,16 +61,17 @@ class Container(FetchMethod): if ud.digest: return - checksum = bb.utils.sha256_file(ud.localpath + "/manifest.json") - checksum_line = f"SRC_URI = \"{ud.url};digest=sha256:{checksum}\"" + inspect_output = runfetchcmd(f"skopeo inspect docker://{ud.container_name}:{ud.tag}", d, True) + digest = json.loads(inspect_output)["Digest"] + checksum_line = f'SRC_URI = "{ud.url};digest={digest}"' strict = d.getVar("BB_STRICT_CHECKSUM") or "0" # If strict checking enabled and neither sum defined, raise error if strict == "1": raise NoChecksumError(checksum_line) - checksum_event = {"sha256sum": checksum} + checksum_event = {"sha256sum": digest} bb.event.fire(MissingChecksumEvent(ud.url, **checksum_event), d) if strict == "ignore": @@ -77,7 +79,7 @@ class Container(FetchMethod): # Log missing digest so user can more easily add it logger.warning( - f"Missing checksum for '{ud.localpath}', consider using this " \ + f"Missing checksum for '{ud.url}', consider using this " \ f"SRC_URI in the recipe:\n{checksum_line}") def unpack(self, ud, rootdir, d): -- 2.49.0 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250625135442.1420977-1-clara.kowalsky%40siemens.com.