From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 20 Aug 2025 11:21:12 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f185.google.com (mail-qt1-f185.google.com [209.85.160.185]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 57K9LBbb028415 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Aug 2025 11:21:11 +0200 Received: by mail-qt1-f185.google.com with SMTP id d75a77b69052e-4b109c4d944sf164297011cf.3 for ; Wed, 20 Aug 2025 02:21:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1755681665; cv=pass; d=google.com; s=arc-20240605; b=GL449hk7wS0qbxjJMvtj/oBiX+VSsrD5T6L2u3IixRA4n2pjQ8f9A69ygDMbDY80jb +RVTNz5bjKJ8ysRQ8EHth/Djmst0YDhIFVpgswCsbZ28N44UWTG7sndt/dhyJKMMoGvG 0DWdyZ+2024+8LOMZzsBVXZhxUdzyIPT2XUsxDc6KpssyFP42G15qIuQZCUJTwHwVz9u bsQwy1etmVHP9oQU4mdNbFzB2WqaRDlCxFvPX/hJFuZ1jb2QsHEvGj814aTSgJ/wXJC9 4JqwQCPo4fnFJlik+nS1yp/qCE1sJkMmA2z1oHBzkGRdATEhA/0RolfN2GptvJzOjCcx dAyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V16tJF3PClIcGvLnoTeav89IlCYNxfezE9HL4DSNmEg=; fh=Q25n97EE30aKwEKj3uQpF9kvrEzh536+mwGeDbBxz0k=; b=k5p7HOf5nNKmXJ5lmomxjMflfCEejE4zmZowmLy5zSLVkiU+3QfZER0vzUXM2cY2AA ZKvum9wV7w/b9I/vxPcYZyJRsQwKgoVTcMv8dTV9TQCTr7cPVZljVsFn04sqhk9TWhkL LvgteEC6G0ML8+KUtwkE/bny8fyS2rJFkcfnUflqdXk++tZfHAfM6be171YJGVdLGvIe K+3oHIa9BLjiDcM56h9DRPwp8Pld6KAX43OEsYzvfdB6ycE/e3SKRLvxao2uqHaEMWLn aN3xpf5iRZOsu86cPR+O4QiXIJ33+M11jGxCvCERhQa3ibwpXkPg2pXHCyXCsicldajr klIA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=GdZHV5zd; spf=pass (google.com: domain of fm-1328757-20250820092102483fac7439582cfac2-sqv2aq@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820092102483fac7439582cfac2-sQv2AQ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1755681665; x=1756286465; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=V16tJF3PClIcGvLnoTeav89IlCYNxfezE9HL4DSNmEg=; b=FhQ2FkZZDhQhZVi74z4+3bYFQZxbEcD/QQqlruZLq1bSFtNIlgq+/w/Dl8t26b/w6Z t+5uLODSrTNFSHj1HE7arzaq4k7IhnQGcaZOFP/T3WJQb8v5Vx1bw9OQj/iFY0Jbu+7k O+HfoONc40UK+Md/RkQVB3TBBX5VRyXmYV6leBj+zisCQv6qN5lreQortjmrQ/3Z5+u2 er/9VOJrdzW4lhQOvM9OD/p+qNHxhO9C+2oesFW+H//51za2vvxukQ6A9Ohe96Ryj+8L yAPXrXWm+Au16fhkDT0IsV80D20hRzufj7bn3GUlt5MnOQ0K+JWDm+kLlvlHQh0Xcx6d 6hkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755681665; x=1756286465; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V16tJF3PClIcGvLnoTeav89IlCYNxfezE9HL4DSNmEg=; b=ZvzWWYohqjKPA3gl//VXcoebgepUjTo6NgVSkc19bGliPDKfIhMf3ao9MMgM7o0iwP 2XmN/6mGm0mcq+v5KcO/b52hVCfrAr0d9obcqtiwbDsFuNBALb5o7rxMDLAV0CY74R2z dbHvCW9pP+d84ES8Khh+8+DpB2UVdqnNoPVpulyAxjvvLA/fk5v6R+8jX4zjdnyOOQvD UHy7fh1oCkCGNBEcgHklghbFa3aoZLC+TeabI/ZigfNp5tNsinIzEiHPskJXn+JW0bZ/ uQWibVEkBwk+YeOTWOtjX1TiamfeQwyZIf2ugLT/LHBx3n7gz1amZeJDB4E5FljbVYZJ 4pHw== X-Forwarded-Encrypted: i=2; AJvYcCUyHmQx/acofgSM2Xc4dLgTUigOTOotyEh6VxaRZXUs9NU8kT1DkeQNqkih8DBwRxt/oYc0@ilbers.de X-Gm-Message-State: AOJu0YxyQzzDhwhXeeGEu5fnIuey9JaXlJU9rcJ8Mu5N5C5+kWIvEovJ /0Y4fdDCL4kLwI089PwzvAZ7bHZKvfIa/EAqbYQ37CuSO2vTV2hcbW7u X-Google-Smtp-Source: AGHT+IE8rfNsIa9/SytI2Mv7VDxycmDwW5VYFagfFmTr6uFu0MbdF3vKVTzHXZQm0lpHxCPLBcWlCQ== X-Received: by 2002:a05:622a:4c8a:b0:4b2:8ac4:ef5f with SMTP id d75a77b69052e-4b291c0aa63mr21069951cf.66.1755681665224; Wed, 20 Aug 2025 02:21:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZexmUAE+i/BlLzCy5BP+nmDhWjxcaLQPzs1k7gu2bidbw== Received: by 2002:a05:622a:1488:b0:4ab:8dcf:6968 with SMTP id d75a77b69052e-4b109c99f93ls113790461cf.1.-pod-prod-09-us; Wed, 20 Aug 2025 02:21:04 -0700 (PDT) X-Received: by 2002:a05:6102:5492:b0:4eb:efc6:740 with SMTP id ada2fe7eead31-51a50e8667bmr592007137.18.1755681664301; Wed, 20 Aug 2025 02:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1755681664; cv=none; d=google.com; s=arc-20240605; b=V+l7KstliT0ldsul0ge1OuSSYeRZoT6/Jvo5z7DJHLu7lVfOzVAmKpagmez6fuqmxQ IrmyPws/NXG4IdSxDpMZXmDz2T7VLI1XrBp3jPiGVoGRnYRLcNZWkTxmZvednKgZQo1u YCYy+SjEq0b2WLZ+WyykI3KKObLGyWtOISZm/dRQOlIBpUAEZ8Oh9H+dnJzpFGhnw1qU clIDIKe5RHO66N8are1+oqDbUPpezqpubkmLMLplLb9xgQ7TWH3J/W+ZTtLvXeLFttEL 336AGl0MRHqqzB1KUihtm45kK6EVY2qKSsSz8+t6+dAtQ+BnjfGV+jCaMl1oxb0KE2uv GhFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=OllHgaJPHZrcy9CF5DlL8MbEUxZTRUPFW1t+DfBaZ/4=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=dWUizTX6czVPMbAfWc0cyRgipIbU7XxerSDuJ46nb1S+5LI2q+PnyUihkgXLCi+iEc Ppg+gLwuNPKQZ31nWFMpgEDkynXILrZ3yhYMmdbuOYtXGss1jEHWUJNP4k4vKbS7ccDG IyehMIejlUqR6dDA/qfek0KGBl1b4WbRLlibPWTsr30ICXbNsumktBbaYqvBme4zdt0A diu3RKRzLibBPuxkaQPu74PitcqWySuovDIVebAUZraDQ7KQB4Pql09AcFVSSYmrXVFD CAJ6H8UR34+8+GWqdB857f61zAkMqsRU7UXH7T478R1csF7XLftbh6MvAqqeVQZWkeLn iJ9w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=GdZHV5zd; spf=pass (google.com: domain of fm-1328757-20250820092102483fac7439582cfac2-sqv2aq@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820092102483fac7439582cfac2-sQv2AQ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id ada2fe7eead31-5127d4dbe17si470047137.1.2025.08.20.02.21.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Aug 2025 02:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20250820092102483fac7439582cfac2-sqv2aq@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 20250820092102483fac7439582cfac2 for ; Wed, 20 Aug 2025 11:21:02 +0200 From: "'Kasturi Shekar' via isar-users" To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH 2/2] deploy-image-wic.sh: fix shellcheck warnings Date: Wed, 20 Aug 2025 14:50:41 +0530 Message-Id: <20250820092041.41798-2-kasturi.shekar@siemens.com> In-Reply-To: <20250820092041.41798-1-kasturi.shekar@siemens.com> References: <20250820092041.41798-1-kasturi.shekar@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=GdZHV5zd; spf=pass (google.com: domain of fm-1328757-20250820092102483fac7439582cfac2-sqv2aq@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20250820092102483fac7439582cfac2-sQv2AQ@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: uD4Bd/RV+WrS No functional changes, only style and readability fixes without altering runtime behavior Signed-off-by: Kasturi Shekar --- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index fa1061c1..e21da8e2 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -8,8 +8,7 @@ installdata=${INSTALL_DATA:-/install} SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; ) -. ${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh - +. "${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh" if ! $installer_unattended; then installer_image_uri=$(find "$installdata" -type f -iname "*.wic*" -a -not -iname "*.wic.bmap" -exec basename {} \;) @@ -37,7 +36,7 @@ if ! $installer_unattended; then # inspired by poky/meta/recipes-core/initrdscripts/files/install-efi.sh target_device_list="" current_root_dev_type=$(findmnt / -o fstype -n) - if [ ${current_root_dev_type} = "nfs" ]; then + if [ "$current_root_dev_type" = "nfs" ]; then current_root_dev="nfs" else current_root_dev=$(readlink -f "$(findmnt / -o source -n)") @@ -108,7 +107,7 @@ if ! $installer_unattended; then exit 0 fi else - installer_target_dev=/dev/$(echo "$target_device_list" | tr -d " ") + installer_target_dev="/dev/$(echo "$target_device_list" | tr -d " ")" fi TARGET_DEVICE_SIZE=$(lsblk --nodeps --noheadings -o SIZE "$installer_target_dev" | tr -d " ") if ! dialog --yes-label Ok --no-label Cancel \ @@ -186,11 +185,13 @@ if version_ge "$bmap_version" "3.6"; then gauge_pid=$! fi -if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then +if ! bmaptool "$quiet_flag" copy "$bmap_options" "$installer_image_uri" "$installer_target_dev"; then kill "$gauge_pid" exit 1 fi +# Attempt to terminate the gauge process if still running. +# Errors are ignored since the process may already have exited. kill "$gauge_pid" 2>/dev/null if ! $installer_unattended; then -- 2.39.5 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250820092041.41798-2-kasturi.shekar%40siemens.com.