public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Kasturi Shekar' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: Kasturi Shekar <kasturi.shekar@siemens.com>
Subject: [PATCH v4 1/2] fix premature success dialog in installer script
Date: Thu, 21 Aug 2025 12:09:42 +0530	[thread overview]
Message-ID: <20250821063944.47909-1-kasturi.shekar@siemens.com> (raw)
In-Reply-To: <e3c59c2c37a9a9661576aeb57a1bf8d6781ef526.camel@siemens.com>

The 'Installation successful' message was displayed before the
progress bar completed. Fixed by tracking the dialog --gauge PID
and terminating it after bmaptool finishes. This ensures
the progress bar runs to 100% before showing the final message.

Changes:
- Tracked the PID of the dialog --gauge process.
- Killed gauge process after bmaptool completed.
- Ensured success message is shown only after the progress bar ends.

Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
---
 .../deploy-image/files/usr/bin/deploy-image-wic.sh            | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index aba81c84..fa1061c1 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then
         done
     ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
 
+    gauge_pid=$!
 fi
 
 if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
+    kill "$gauge_pid"
     exit 1
 fi
 
+kill "$gauge_pid" 2>/dev/null
+
 if ! $installer_unattended; then
     dialog --title "Reboot" \
            --msgbox "Installation was successful. System will be rebooted. Please remove the USB stick." 6 60
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250821063944.47909-1-kasturi.shekar%40siemens.com.

  reply	other threads:[~2025-08-21  6:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <N7lI8iF-GEc>
2025-08-06  5:54 ` [PATCH v2] " 'Kasturi Shekar' via isar-users
2025-08-06  7:29   ` 'MOESSBAUER, Felix' via isar-users
2025-08-06  9:28     ` 'Shekar, Kasturi' via isar-users
2025-08-06 10:22     ` 'Shekar, Kasturi' via isar-users
2025-08-20  9:34   ` [PATCH 1/2 v3] " 'Kasturi Shekar' via isar-users
2025-08-20  9:34     ` [PATCH 2/2] deploy-image-wic.sh: fix shellcheck warnings 'Kasturi Shekar' via isar-users
2025-08-20 15:49     ` [PATCH 1/2 v3] fix premature success dialog in installer script 'MOESSBAUER, Felix' via isar-users
2025-08-21  6:39       ` 'Kasturi Shekar' via isar-users [this message]
2025-08-21  6:39         ` [PATCH v4 2/2] deploy-image-wic.sh: fix shellcheck warnings 'Kasturi Shekar' via isar-users
2025-08-21  6:39         ` [PATCH v4 0/2] fix premature success dialog 'Kasturi Shekar' via isar-users
2025-08-21  8:59           ` 'MOESSBAUER, Felix' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250821063944.47909-1-kasturi.shekar@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=kasturi.shekar@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox