public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Badrikesh Prusty' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: Badrikesh Prusty <badrikesh.prusty@siemens.com>
Subject: [PATCH] isar-installer: enable bmap usage in unattended installations
Date: Sat, 13 Dec 2025 08:11:50 -0500	[thread overview]
Message-ID: <20251213131150.1110465-1-badrikesh.prusty@siemens.com> (raw)

The installer previously searched for the bmap file only during interactive
installations (inside `if ! installer_unattended`). This caused bmap files
to be ignored during unattended installs.

The bmap path is now derived directly from the installer image outside the
interactive block. If the file does not exist, bmap usage is disabled.

This ensures correct bmap usage in both interactive and unattended modes.

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 .../deploy-image/files/usr/bin/deploy-image-wic.sh    | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index a4e38876..55d5df6f 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -31,7 +31,6 @@ if ! $installer_unattended; then
         dialog --msgbox "Could not find an image to install. Installation aborted." 6 60
         exit 1
     fi
-    DISK_BMAP=$(find "$installdata" -type f -iname "${installer_image_uri%.wic*}.wic.bmap")
 
     # inspired by poky/meta/recipes-core/initrdscripts/files/install-efi.sh
     target_device_list=""
@@ -167,10 +166,6 @@ if ! $installer_unattended; then
 
     # set absolute paths to be compatible with unattended mode
     installer_image_uri="$installdata/$installer_image_uri"
-
-    if [ -z "$DISK_BMAP" ]; then
-        DISK_BMAP="$installdata/$DISK_BMAP"
-    fi
 fi
 
 if ! cmp /dev/zero "$installer_target_dev" -n 1M; then
@@ -190,7 +185,11 @@ if ! cmp /dev/zero "$installer_target_dev" -n 1M; then
 fi
 
 bmap_options=""
-if [ -z "$DISK_BMAP" ]; then
+
+# bmap file is expected to be next to the installer image
+DISK_BMAP="${installer_image_uri%.wic*}.wic.bmap"
+
+if [ ! -f "$DISK_BMAP" ]; then
     bmap_options="--nobmap"
 fi
 
-- 
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251213131150.1110465-1-badrikesh.prusty%40siemens.com.

             reply	other threads:[~2025-12-13 13:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 13:11 'Badrikesh Prusty' via isar-users [this message]
2025-12-17 12:56 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251213131150.1110465-1-badrikesh.prusty@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=badrikesh.prusty@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox