public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: cedric.hombourger@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH v2 13/17] testsuite: make SignatureTest idempotent
Date: Fri, 19 Dec 2025 14:19:19 +0100	[thread overview]
Message-ID: <20251219131923.1504046-14-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20251219131923.1504046-1-felix.moessbauer@siemens.com>

The SignatureTest copies the tmp dir for later comparison. However, this
currently fails in case the test was run before as the target dir then
already exists. We fix it by clearing the target dir upfront. We further
reduce the disk consumption by removing the tmp dir copy in case the
test was successfull. On error, we keep the copy for manual
analysis.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 testsuite/cibase.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/testsuite/cibase.py b/testsuite/cibase.py
index 5b0139de..5ef1a5b5 100755
--- a/testsuite/cibase.py
+++ b/testsuite/cibase.py
@@ -171,6 +171,7 @@ class CIBaseTest(CIBuilder):
         Generate signature data for target(s) and check for cacheability issues
         """
         self.configure(**kwargs)
+        self.delete_from_build_dir('tmp_before_sstate')
         self.move_in_build_dir('tmp', 'tmp_before_sstate')
         self.bitbake(targets, sig_handler='none')
 
@@ -190,6 +191,9 @@ class CIBaseTest(CIBuilder):
             for line in output.splitlines():
                 self.log.error(ansi_escape.sub('', line))
             self.fail("Detected cacheability issues")
+        else:
+            # on success, cleanup temporary copy (keep on failure to inspect)
+            self.delete_from_build_dir('tmp_before_sstate')
 
     def perform_sstate_test(self, image_target, package_target, **kwargs):
         def check_executed_tasks(target, expected):
-- 
2.51.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251219131923.1504046-14-felix.moessbauer%40siemens.com.

  parent reply	other threads:[~2025-12-19 13:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 13:19 [PATCH v2 00/17] Various improvements to the testsuite 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 01/17] testsuite: move targets with custom kernel to separate test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 02/17] testsuite: enable ccache on kernel tests 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 03/17] testsuite: make prebuilt container a feature test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 04/17] testsuite: make compat test standalone test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 05/17] testsuite: handle IMAGE_INSTALL solely in cibuilder.py 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 06/17] testsuite: limit cross_debsrc test to subset of packages 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 07/17] testsuite: forward SSTATE_MIRRORS into CI env on sstate 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 08/17] ci: add support for sstate cache 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 09/17] testsuite: make test_cross_deps more specific 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 10/17] testsuite: fix typo in log message in perform_signature_lint 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 11/17] testsuite: fix SignatureTest by avoiding absolute path in bblayers 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 12/17] testsuite: use more recent distros in SignatureTest 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` 'Felix Moessbauer' via isar-users [this message]
2025-12-19 13:19 ` [PATCH v2 14/17] testsuite: add rootfs target for rootfs only tests 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 15/17] testsuite: refactor sbom tests to avoid overhead 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 16/17] testsuite: make sbuild-flavor test standalone 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 17/17] testsuite: skip VM tests if images are not available 'Felix Moessbauer' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219131923.1504046-14-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox