From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: cedric.hombourger@siemens.com,
Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH v2 17/17] testsuite: skip VM tests if images are not available
Date: Fri, 19 Dec 2025 14:19:23 +0100 [thread overview]
Message-ID: <20251219131923.1504046-18-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20251219131923.1504046-1-felix.moessbauer@siemens.com>
We currently fail the test if the image is not available. Instead, we
now skip it and report what is missing. By that, we stay semantically
correct by not failing tests when pre-conditions are not fulfilled.
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
testsuite/cibuilder.py | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index 614a3397..b64d808c 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -24,6 +24,7 @@ from utils import CIUtils
from avocado import Test
from avocado.utils import path
from avocado.utils import process
+from avocado.core import exceptions
sys.path.append(os.path.join(os.path.dirname(__file__), '../bitbake/lib'))
@@ -703,6 +704,7 @@ class CIBuilder(Test):
keep=False,
):
time_to_wait = self.params.get('time_to_wait', default=DEF_VM_TO_SEC)
+ self.skip_if_vm_image_missing(arch, distro, image)
self.log.info("===================================================")
self.log.info(f"Running Isar VM boot test for ({distro}-{arch})")
@@ -800,3 +802,20 @@ class CIBuilder(Test):
self.vm_turn_off(vm)
return stdout, stderr
+
+ def skip_if_vm_image_missing(self, arch, distro, image):
+ (
+ image_fstypes,
+ image_fullname,
+ deploy_dir_image,
+ ) = CIUtils.getVars(
+ 'IMAGE_FSTYPES',
+ 'IMAGE_FULLNAME',
+ 'DEPLOY_DIR_IMAGE',
+ target=f"mc:qemu{arch}-{distro}:{image}",
+ )
+ image_type = image_fstypes.split()[0]
+ rootfs_image = f"{image_fullname}.{image_type}"
+ rootfs_image_path = os.path.join(deploy_dir_image, rootfs_image)
+ if not os.path.exists(rootfs_image_path):
+ raise exceptions.TestSkipError(f'VM image missing: {rootfs_image}')
--
2.51.0
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251219131923.1504046-18-felix.moessbauer%40siemens.com.
prev parent reply other threads:[~2025-12-19 13:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 13:19 [PATCH v2 00/17] Various improvements to the testsuite 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 01/17] testsuite: move targets with custom kernel to separate test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 02/17] testsuite: enable ccache on kernel tests 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 03/17] testsuite: make prebuilt container a feature test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 04/17] testsuite: make compat test standalone test 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 05/17] testsuite: handle IMAGE_INSTALL solely in cibuilder.py 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 06/17] testsuite: limit cross_debsrc test to subset of packages 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 07/17] testsuite: forward SSTATE_MIRRORS into CI env on sstate 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 08/17] ci: add support for sstate cache 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 09/17] testsuite: make test_cross_deps more specific 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 10/17] testsuite: fix typo in log message in perform_signature_lint 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 11/17] testsuite: fix SignatureTest by avoiding absolute path in bblayers 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 12/17] testsuite: use more recent distros in SignatureTest 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 13/17] testsuite: make SignatureTest idempotent 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 14/17] testsuite: add rootfs target for rootfs only tests 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 15/17] testsuite: refactor sbom tests to avoid overhead 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` [PATCH v2 16/17] testsuite: make sbuild-flavor test standalone 'Felix Moessbauer' via isar-users
2025-12-19 13:19 ` 'Felix Moessbauer' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219131923.1504046-18-felix.moessbauer@siemens.com \
--to=isar-users@googlegroups.com \
--cc=cedric.hombourger@siemens.com \
--cc=felix.moessbauer@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox