public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Richa Bharti' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com, amikan@ilbers.de
Cc: cedric.hombourger@siemens.com, srikanth.krishnakar@siemens.com,
	ibr@ilbers.de, Richa Bharti <Richa.Bharti@siemens.com>
Subject: [PATCH v3] wic: support passing extraargs for EFI partition creation
Date: Tue, 23 Dec 2025 16:08:14 +0530	[thread overview]
Message-ID: <20251223103814.16129-1-Richa.Bharti@siemens.com> (raw)
In-Reply-To: <c2005266-c883-4bec-8ff6-7c4733638673@ilbers.de>

Some EFI firmwares require FAT filesystems to use specific geometry or
sector parameters.

Add support for an `extraargs` source parameter to allow passing
additional mkdosfs options when creating the EFI System Partition (ESP).
If no extra arguments are provided, mkdosfs defaults to "-S 512",
preserving existing behaviour.

Signed-off-by: Richa Bharti <Richa.Bharti@siemens.com>
---
 meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks | 2 +-
 meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py    | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks
index e22dba2f..219c5d06 100644
--- a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks
+++ b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks
@@ -2,7 +2,7 @@
 # long-description: Creates a partitioned EFI disk image without any swap that
 # the user can directly dd to boot media, where the last partition is btrfs.
 
-part /boot --source bootimg-efi-isar --sourceparams "loader=systemd-boot" --ondisk sda --label efi --part-type EF00 --align 1024
+part /boot --source bootimg-efi-isar --sourceparams "loader=systemd-boot,extraargs=-s 8" --ondisk sda --label efi --part-type EF00 --align 1024
 
 part / --source rootfs --ondisk sda --fstype btrfs --label platform --align 1024 --use-uuid --exclude-path boot/
 
diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
index fd4d6017..b0edb8f5 100644
--- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
+++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
@@ -537,8 +537,10 @@ class BootimgEFIPlugin(SourcePlugin):
 
         label = part.label if part.label else "ESP"
 
-        dosfs_cmd = "mkdosfs -n %s -i %s -C %s %d" % \
-                    (label, part.fsuuid, bootimg, blocks)
+        extraargs = source_params.get('extraargs', "-S 512")
+
+        dosfs_cmd = "mkdosfs -n %s -i %s %s -C %s %d" % \
+                    (label, part.fsuuid, extraargs, bootimg, blocks)
         exec_native_cmd(dosfs_cmd, native_sysroot)
 
         mcopy_cmd = "mcopy -i %s -s %s/* ::/" % (bootimg, hdddir)
-- 
2.30.2

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251223103814.16129-1-Richa.Bharti%40siemens.com.

  reply	other threads:[~2025-12-23 10:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 13:02 [PATCH] " 'Richa Bharti' via isar-users
2025-12-18  7:28 ` Anton Mikanovich
2025-12-18  8:22   ` [PATCH v2] " 'Richa Bharti' via isar-users
2025-12-18  8:29     ` RICHA BHARTI
2025-12-18  8:39     ` 'Bharti, Richa' via isar-users
2025-12-22  7:24     ` Anton Mikanovich
2025-12-23 10:38       ` 'Richa Bharti' via isar-users [this message]
2026-01-05  9:55         ` [PATCH v3] " Anton Mikanovich
2025-12-23 10:44       ` [PATCH v2] " RICHA BHARTI
2025-12-23 15:22         ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251223103814.16129-1-Richa.Bharti@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=Richa.Bharti@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=cedric.hombourger@siemens.com \
    --cc=ibr@ilbers.de \
    --cc=srikanth.krishnakar@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox