* [PATCH] classes-recipe/imagetypes_ddi: remove redundant dependency
@ 2026-02-12 11:47 'Benedikt Niedermayr' via isar-users
2026-02-18 8:23 ` Zhihang Wei
0 siblings, 1 reply; 2+ messages in thread
From: 'Benedikt Niedermayr' via isar-users @ 2026-02-12 11:47 UTC (permalink / raw)
To: isar-users; +Cc: quirin.gylstorff
Adding "isar-ddi-definitions" via DEPENDS is redundant as it is already
added via IMAGER_BUILD_DEPS.
Furthermore this avoids building "isar-ddi-definitions" when ddi has not
been added to IMAGE_FSTYPES.
Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
---
meta/classes-recipe/imagetypes_ddi.bbclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/classes-recipe/imagetypes_ddi.bbclass b/meta/classes-recipe/imagetypes_ddi.bbclass
index a2d5af669295..0e45fb8a5309 100644
--- a/meta/classes-recipe/imagetypes_ddi.bbclass
+++ b/meta/classes-recipe/imagetypes_ddi.bbclass
@@ -4,7 +4,6 @@
# SPDX-License-Identifier: MIT
# Class to generate discoverable disk images (DDI)
-DEPENDS += "isar-ddi-definitions"
IMAGER_BUILD_DEPS:ddi += " isar-ddi-definitions"
IMAGER_INSTALL:ddi += " isar-ddi-definitions"
--
2.43.0
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260212114806.4025303-1-benedikt.niedermayr%40siemens.com.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] classes-recipe/imagetypes_ddi: remove redundant dependency
2026-02-12 11:47 [PATCH] classes-recipe/imagetypes_ddi: remove redundant dependency 'Benedikt Niedermayr' via isar-users
@ 2026-02-18 8:23 ` Zhihang Wei
0 siblings, 0 replies; 2+ messages in thread
From: Zhihang Wei @ 2026-02-18 8:23 UTC (permalink / raw)
To: Benedikt Niedermayr, isar-users; +Cc: quirin.gylstorff
Applied to next, thanks.
Zhihang
On 2/12/26 12:47, 'Benedikt Niedermayr' via isar-users wrote:
> Adding "isar-ddi-definitions" via DEPENDS is redundant as it is already
> added via IMAGER_BUILD_DEPS.
> Furthermore this avoids building "isar-ddi-definitions" when ddi has not
> been added to IMAGE_FSTYPES.
>
> Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
> ---
> meta/classes-recipe/imagetypes_ddi.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes-recipe/imagetypes_ddi.bbclass b/meta/classes-recipe/imagetypes_ddi.bbclass
> index a2d5af669295..0e45fb8a5309 100644
> --- a/meta/classes-recipe/imagetypes_ddi.bbclass
> +++ b/meta/classes-recipe/imagetypes_ddi.bbclass
> @@ -4,7 +4,6 @@
> # SPDX-License-Identifier: MIT
> # Class to generate discoverable disk images (DDI)
>
> -DEPENDS += "isar-ddi-definitions"
> IMAGER_BUILD_DEPS:ddi += " isar-ddi-definitions"
> IMAGER_INSTALL:ddi += " isar-ddi-definitions"
>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/34a05b6c-7991-49b3-91d1-61f57f2475eb%40ilbers.de.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-18 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-12 11:47 [PATCH] classes-recipe/imagetypes_ddi: remove redundant dependency 'Benedikt Niedermayr' via isar-users
2026-02-18 8:23 ` Zhihang Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox