public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, quirin.gylstorff@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH v1 11/15] add helper script to clean artifacts in build dir
Date: Thu, 26 Feb 2026 17:28:36 +0100	[thread overview]
Message-ID: <20260226162843.1642329-12-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20260226162843.1642329-1-felix.moessbauer@siemens.com>

When running in rootless mode, cleaning the build directory from outside
the build environment is a non trivial task due to mixed file
ownerships. To simplify this, we introduce the isar-clean-builddir
script that can perform the cleanup without requiring root privileges.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 RECIPE-API-CHANGELOG.md     |  5 +++
 scripts/isar-clean-builddir | 73 +++++++++++++++++++++++++++++++++++++
 2 files changed, 78 insertions(+)
 create mode 100755 scripts/isar-clean-builddir

diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index 7640d87d..52af27ce 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -999,3 +999,8 @@ This internally switches the chroot mode from `schroot` to `unshare`.
 When using kas, the `build_system` needs to be set to `isar-rootless`, but the final
 interfaces still need to be clarified. Further, kas patches are needed (for details,
 check the kas mailing list).
+
+Note, that the build dir may contain files that were generated within the rootless
+environment and cannot be deleted from the outside by the calling user. To simplify
+the cleanup, we provide the `isar-clean-builddir` script that helps purging
+directories with mixed ownerships (without requiring root privileges).
diff --git a/scripts/isar-clean-builddir b/scripts/isar-clean-builddir
new file mode 100755
index 00000000..6bc90b1d
--- /dev/null
+++ b/scripts/isar-clean-builddir
@@ -0,0 +1,73 @@
+#!/bin/sh
+# isar-clean-builddir - Clean the build/tmp directory
+#
+# This script removes all files from the specified directory, including those
+# owned by other users (which requires elevated privileges).
+#
+# Rootless Mode:
+#   When --rootless is specified, no privileged commands are executed. This
+#   requires that the UID namespace where files were generated matches the
+#   cleanup environment. When running from a container, this script must be
+#   called from within the same container.
+#
+# Part of the Isar API. External tools may call this script for cleanup.
+#
+# Copyright (c) Siemens AG, 2026
+# SPDX-License-Identifier: MIT
+
+DRY_RUN=0
+ROOTLESS=0
+
+usage()
+{
+    EXIT_CODE="$1"
+    SELF="isar-clean-builddir"
+    printf "%b" "Usage: ${SELF} [--rootless] [--dry-run] [dir]\n"
+
+    exit "${EXIT_CODE:-1}"
+}
+
+while [ $# -gt 0 ]; do
+    case "$1" in
+    --dry-run)
+        DRY_RUN=1
+        shift 1
+        ;;
+    -h | --help)
+        usage 0
+        ;;
+    --rootless)
+        ROOTLESS=1
+        shift 1
+        ;;
+    --*)
+        usage 1
+        ;;
+    *)
+        break
+        ;;
+    esac
+done
+
+[ $# -eq 1 ] || usage 1
+if ! [ -d "$1" ]; then
+    echo "error: \"$1\" is not a directory"
+    exit 1
+fi
+
+if [ $ROOTLESS -eq 1 ]; then
+    PRIVILEGED_CMD="unshare --map-auto --map-root-user --keep-caps"
+else
+    PRIVILEGED_CMD="sudo"
+fi
+
+if [ $DRY_RUN -eq 1 ]; then
+    echo "dry-run, not executing"
+    DRY_RUN_PREFIX="/bin/echo"
+fi
+
+# clean all files that do not belong to us
+# shellcheck disable=2086
+find "$1" \( ! -user "$(whoami)" -type d -prune \) -exec $DRY_RUN_PREFIX $PRIVILEGED_CMD rm -rf {} \;
+# clean remaining files
+$DRY_RUN_PREFIX rm -rf "$1"
-- 
2.51.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260226162843.1642329-12-felix.moessbauer%40siemens.com.

  parent reply	other threads:[~2026-02-26 16:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 16:28 [PATCH v1 00/16] add support to build isar unprivileged 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 01/15] refactor bootstrap: store rootfs tar with user permissions 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 02/15] deb-dl-dir: export without root privileges 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 03/15] download debs without locking 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 04/15] introduce wrappers for privileged execution 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 05/15] bootstrap: move cleanup trap to function 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 06/15] rootfs: rework sstate caching of rootfs artifact 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 07/15] rootfs_generate_initramfs: rework deployment to avoid chowning 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 08/15] use bitbake function to generate mounting scripts 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 09/15] apt-fetcher: prepare for chroot specific fetching 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 10/15] add support for fully rootless builds 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` 'Felix Moessbauer' via isar-users [this message]
2026-02-26 16:28 ` [PATCH v1 12/15] apt-fetcher: implement support for unshare backend 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 13/15] dpkg-source: implement multiarch " 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 14/16] rootfs: remove temporary sstate deploy directory after task execution 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 14/15] use copy of sbom-chroot for sbom creation 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 15/15] add support for devshell on unshare backend 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 15/16] use copy of sbom-chroot for sbom creation 'Felix Moessbauer' via isar-users
2026-02-26 16:28 ` [PATCH v1 16/16] add support for devshell on unshare backend 'Felix Moessbauer' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226162843.1642329-12-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox