[PATCH 1/1] compat: handle user errors gracefully to avoid parser splat

[PATCH 1/1] compat: handle user errors gracefully to avoid parser splat

['Felix Moessbauer' via isar-users]

A common user error is to forget to define a machine (or use one that is
not defined). In this case, a huge parsing error is printed, giving no
indication what the actually user error is. Instead of crashing the
parser, we now report a meaningful user error.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
Dear maintainers,

I recommend to include this patch in the upcoming release.

Best regards,
Felix

 meta/classes-recipe/compat.bbclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/classes-recipe/compat.bbclass b/meta/classes-recipe/compat.bbclass
index 907c3ce2..7df55576 100644
--- a/meta/classes-recipe/compat.bbclass
+++ b/meta/classes-recipe/compat.bbclass
@@ -19,6 +19,9 @@ python() {
     package_arch = d.getVar('PACKAGE_ARCH')
     overrides = d.getVar('OVERRIDES').split(':')
 
+    if not distro_arch:
+        bb.fatal("DISTRO_ARCH is not set")
+
     localdata = bb.data.createCopy(d)
     new_overrides = [distro_arch] + [o for o in overrides if not o == package_arch]
     localdata.setVar('OVERRIDES', ':'.join(new_overrides))
-- 
2.51.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260227101009.2465660-1-felix.moessbauer%40siemens.com.

Re: [PATCH 1/1] compat: handle user errors gracefully to avoid parser splat

[Zhihang Wei]

Applied to next, thanks.

Zhihang

On 2/27/26 11:10, 'Felix Moessbauer' via isar-users wrote:
> A common user error is to forget to define a machine (or use one that is
> not defined). In this case, a huge parsing error is printed, giving no
> indication what the actually user error is. Instead of crashing the
> parser, we now report a meaningful user error.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> Dear maintainers,
>
> I recommend to include this patch in the upcoming release.
>
> Best regards,
> Felix
>
>   meta/classes-recipe/compat.bbclass | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes-recipe/compat.bbclass b/meta/classes-recipe/compat.bbclass
> index 907c3ce2..7df55576 100644
> --- a/meta/classes-recipe/compat.bbclass
> +++ b/meta/classes-recipe/compat.bbclass
> @@ -19,6 +19,9 @@ python() {
>       package_arch = d.getVar('PACKAGE_ARCH')
>       overrides = d.getVar('OVERRIDES').split(':')
>   
> +    if not distro_arch:
> +        bb.fatal("DISTRO_ARCH is not set")
> +
>       localdata = bb.data.createCopy(d)
>       new_overrides = [distro_arch] + [o for o in overrides if not o == package_arch]
>       localdata.setVar('OVERRIDES', ':'.join(new_overrides))

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/9d8f796e-dd33-42e5-8d29-5469050db6fb%40ilbers.de.