public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, quirin.gylstorff@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH v3 01/16] refactor bootstrap: store rootfs tar with user permissions
Date: Tue,  7 Apr 2026 16:22:55 +0200	[thread overview]
Message-ID: <20260407142310.2327696-2-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20260407142310.2327696-1-felix.moessbauer@siemens.com>

As the mmdebstrap itself is executed as root, the generated rootfs will
also be owned by root when stored as file. To avoid this, we let
mmdebstrap emit the rootfs on stdout and write it to a file outside of
the sudo call.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 .../isar-mmdebstrap/isar-mmdebstrap.inc             | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
index 6c2cb170..f21a6164 100644
--- a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
+++ b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
@@ -246,11 +246,11 @@ do_bootstrap() {
                    ${@get_apt_opts(d, '--aptopt')} \
                    ${@get_distro_components_argument(d)} \
                    "${@get_distro_suite(d)}" \
-                   "${WORKDIR}/rootfs.tar.zst" \
-                   "$bootstrap_list"
+                   - \
+                   "$bootstrap_list" > ${WORKDIR}/rootfs.tar.zst
 
     # Finalize bootstrap by setting the link in deploy
-    sudo ln -Tfsr "${WORKDIR}/rootfs.tar.zst" "${DEPLOY_ISAR_BOOTSTRAP}.tar.zst"
+    ln -Tfsr "${WORKDIR}/rootfs.tar.zst" "${DEPLOY_ISAR_BOOTSTRAP}.tar.zst"
 
     if [ "${ISAR_USE_CACHED_BASE_REPO}" != "1" ]; then
         deb_dl_dir_export "${WORKDIR}/dl_dir" "${BOOTSTRAP_BASE_DISTRO}-${BASE_DISTRO_CODENAME}"
@@ -265,8 +265,7 @@ SSTATEPOSTINSTFUNCS += "bootstrap_sstate_finalize"
 
 bootstrap_sstate_prepare() {
     # this runs in SSTATE_BUILDDIR, which will be deleted automatically
-    sudo cp -a "${WORKDIR}/rootfs.tar.zst" ./bootstrap.tar.zst
-    sudo chown $(id -u):$(id -g) bootstrap.tar.zst
+    cp -a "${WORKDIR}/rootfs.tar.zst" ./bootstrap.tar.zst
 }
 
 bootstrap_sstate_finalize() {
@@ -274,8 +273,8 @@ bootstrap_sstate_finalize() {
     # we should restore symlinks after using tar
     if [ -f bootstrap.tar.zst ]; then
         mv bootstrap.tar.zst "${WORKDIR}/rootfs.tar.zst"
-        sudo ln -Tfsr "${WORKDIR}/rootfs.tar.zst" \
-                      "${DEPLOY_ISAR_BOOTSTRAP}.tar.zst"
+        ln -Tfsr "${WORKDIR}/rootfs.tar.zst" \
+                 "${DEPLOY_ISAR_BOOTSTRAP}.tar.zst"
     fi
 }
 
-- 
2.53.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260407142310.2327696-2-felix.moessbauer%40siemens.com.

  reply	other threads:[~2026-04-07 14:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 14:22 [PATCH v3 00/16] add support to build isar unprivileged 'Felix Moessbauer' via isar-users
2026-04-07 14:22 ` 'Felix Moessbauer' via isar-users [this message]
2026-04-07 14:22 ` [PATCH v3 02/16] deb-dl-dir: export without root privileges 'Felix Moessbauer' via isar-users
2026-04-07 14:22 ` [PATCH v3 03/16] download debs without locking 'Felix Moessbauer' via isar-users
2026-04-07 14:22 ` [PATCH v3 04/16] introduce wrappers for privileged execution 'Felix Moessbauer' via isar-users
2026-04-07 14:22 ` [PATCH v3 05/16] bootstrap: move cleanup trap to function 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 06/16] rootfs: rework sstate caching of rootfs artifact 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 07/16] rootfs_generate_initramfs: rework deployment to avoid chowning 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 08/16] use bitbake function to generate mounting scripts 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 09/16] apt-fetcher: prepare for chroot specific fetching 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 10/16] add support for fully rootless builds 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 11/16] add helper script to clean artifacts in build dir 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 12/16] apt-fetcher: implement support for unshare backend 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 13/16] dpkg-source: implement multiarch " 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 14/16] use copy of sbom-chroot for sbom creation 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 15/16] add support for devshell on unshare backend 'Felix Moessbauer' via isar-users
2026-04-07 14:23 ` [PATCH v3 16/16] testsuite: add parameter to run tests in rootless mode 'Felix Moessbauer' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407142310.2327696-2-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox