From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 08 Apr 2026 09:19:45 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f190.google.com (mail-qt1-f190.google.com [209.85.160.190]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 6387Jh5A019913 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 8 Apr 2026 09:19:44 +0200 Received: by mail-qt1-f190.google.com with SMTP id d75a77b69052e-50b4076dc16sf255605391cf.2 for ; Wed, 08 Apr 2026 00:19:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1775632778; cv=pass; d=google.com; s=arc-20240605; b=Yn0sFG+NgpzF2riJMZ70hBst0pjCqdPeJ/SGlRbBP/4Mjjb2srupWJjRdqx0dEp99V gaqjm1OWFyitbenrFz+/fro/8cEZtN3u5s/cRKjXkG7Ao61S4cyZAQYe1nGP2CcGFvO5 +tGiKbKDSbZ4AxCx7pwE5xJMz2Q8ZUlU0mp3C9EvvKvoxAepXE9X4gnjVKs7rk1xbuVr BkfoflpCPdJADcU8NjE0IOAJkfKMPkMjgaYne5bzcjweKdaHzXvV+W16f2s1EkmGwGoA voWpe7P+Hdu82x8uhdxFh5sjNkD8z5RDXDF1jw8JgE5uHXqYqQNo/r/ZosUDx1Axglh1 voBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; fh=ZVFPn1rWjcsmrM6NU0qxV5unHGTAUt9vg6IgH1WrNQQ=; b=FSf5mCSFR84wdC7woaTbJGDaxxmEsR2YMR2oqx/koC2wfutSbIvd5D4wLzaMhFTk6J FGdDTI8Klb6qZ/ofs0KvNSO149LnPHJtuNc2MbOh6yi4e5wm8BH3FGbHs/sv16rPhHeV JQbCGWdEaknUn4cM6MS/HVSU+Uq4CuAQWCi3ExSX8sMW806VzQ7QJ8vS1ooPgS9k2NRC A6vV65Zxtypm6O3PrG1oNZgZ9DTtmlkbXn5duUVJ9nRsW5JPMn6FcFTpgBzi6UQmrdzX /PuHN2tJ3p06F1i/CZKLHO/+87K5vWkC9+Jqw6BHO2jzz8QQzkx3oBLXRgzvV6B01/5n 0kpA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1775632778; x=1776237578; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; b=j/emy9IoLvYKIlRVJrikH0mYy6T2JFYBdVYA+p3rNjujX7dU2x6OWQlGriKeOJcNuy 6V6nab1ZJIFECtxK79xuoWR0a7xqizq1kEjb6Bu0sOufJL8+lzGZX4/P/WnELRtroX+M Osoom0sqdx1RI1rParSuszQeDzUWns7BKVOvU9yGjUcry0r2HsMHnFkAX38GvlomKBMD qSC3/FCe+Zs4NrrTYwzAZ3GM+g1N1R0sh3xc+6A5x2hZ8XCxRDOSUjcwTiOvSeggOHwz lnj2err7o+n6swftISUdBnoEm/aQWKzJrGr6tWBAGKrQnn5eivF3pWFdskGmgXyorG3F cxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775632778; x=1776237578; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; b=gHJKBbQOU+GwUK7G4v3myf/gzaLiF4m/fmqyOCIkJE+S3Pt55+lKjfuEJDlkJCNJZq 6nOOCYPiZtnYZT2XTPm+42iKC+hOnYVEfHfs9RZvNpD3c9rZY+N32WKUEvb/buyyQJGs OMNlY4K6U/1HqWu4+2TTNEZskJHPDGkWubE18ix6xUf0ba7o7u9eIMkNc+bu+TQUV0wo zXsy6AsKIGlZbd6K7BHeSEvXrHfmUulh8fK89Zh3K5lLYsRh1D70MEjytsBCw5F5n5pR /538fEYUtoQd86jLDtZqkWZzrSAYR3+oJVAnUEJqnyqDnMcSruK1zE4Yaixfnvk5CGPc zGlQ== X-Forwarded-Encrypted: i=2; AJvYcCXBkD7hNoD60dqFPIsZjQGp/eDIWTI6AvGu2OfaVosVmOlV0+Lz2OYKEXzNtOxCg3rGJVwx@ilbers.de X-Gm-Message-State: AOJu0YxkW0ftXKgNIaK2wReNnK+s9xwDaoj66n09zn7ah/IMViFE+Kv7 qBHIGb8xes4btKBHJDOOh9DjY6K31weEwWoQ7BQigkwyHgYqlGrxH4GU X-Received: by 2002:ac8:7d56:0:b0:509:68c:634d with SMTP id d75a77b69052e-50d62614d02mr287958191cf.10.1775632777753; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AYAyTiLqJzzsl3L7p6aBhE0SJnz0kr8G99T+QJ0aYQOwg913sg==" Received: by 2002:ac8:5d89:0:b0:509:41df:80ff with SMTP id d75a77b69052e-50d4c6c8ddcls110277231cf.2.-pod-prod-06-us; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) X-Received: by 2002:a05:620a:178b:b0:8cf:dfc9:c09c with SMTP id af79cd13be357-8d41b8e3d3bmr2772150885a.10.1775632777314; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) Received: by 2002:a05:6808:2806:b0:46b:22a1:35fc with SMTP id 5614622812f47-46bd6fcb9b4msb6e; Tue, 7 Apr 2026 23:44:18 -0700 (PDT) X-Received: by 2002:a17:90b:4ecc:b0:359:7c55:c166 with SMTP id 98e67ed59e1d1-35de67dcbe1mr19197735a91.7.1775630657609; Tue, 07 Apr 2026 23:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775630657; cv=none; d=google.com; s=arc-20240605; b=YFOBkt6Srxl7o8uYWqIqjXaNmwGd3mMN+v4SNrJnp5PRiGu/Kd2AK9q6NvIJ/u+0zl jY78ygNoCQBWPYdgKzybrKyMBhjTdVSs4MfuOYaNqMpU80fYLNfHMOSedrESXGZdTOif y8zrWtJd5ij8AVIHcgtJF0uYFqFJbcOKJW7cYAY+b0SZzRNhP2lamlDZugutAyawMucs adm5hMLJOgnpb/zBPF1NKew0XISQ9ypvwD8czeasXmqqhp3EfZZs8bNnBER8zklWvd2K hRmTJDXES183umEuTHBwFAKhiY6Zdjt7m/mdM6XVG+wkfRBdHPsNaeTrK4pPvh8OK1LN Vkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=xhFVF4z4VULo4FX0pmMYK1tzPFTI5Q5NAT/4aG4uAlo=; fh=F5B7sHw8QSYpzAgwBsAEFSY7gmjvHKn1s8Oqz1DQh58=; b=l2DOHiyIIC7icHa4+WtBU0flMUw9Q+s3n6jl4cq3oLFnUjnrZTBa4SzO7ZkDRvTXRw CTe7oG7/59O//vy6Em7MladGzmElZVtP6Qt09L3MFrhXeVA5i5IRKHRpQHFT9UHoA+Bw xRYx2zzVNgeSwwrJ9YxQU+H04vb+v9/RQOuFrWqoEiWEpsmAIzCS5tInD8FKfUM5riiy XN9ad1PAe8UpC2dWZnrj6TUzQ7Y6CT59fMjjPFjcEcEZIvfBiW6MoM0+21XpveioFLMv NlUjSww8y33hmoPqqurURKi3TJM9/oT75BDOCNbJCI9DFAelZPkaOyEGVZ/MNsE3EMDs tubQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id 98e67ed59e1d1-35dd35e9bd0si580592a91.1.2026.04.07.23.44.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2026 23:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20260408064415291243c6d1000207d0 for ; Wed, 08 Apr 2026 08:44:15 +0200 From: "'Gourav Singh' via isar-users" To: isar-users@googlegroups.com Cc: cedric.hombourger@siemens.com, Gourav Singh Subject: [PATCH v2] wic/plugins/bootimg-efi-isar: gate root= with creator.rootdev not None Date: Wed, 8 Apr 2026 12:14:06 +0530 Message-Id: <20260408064406.3396423-1-gouravsingh@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1333022:519-21489:flowmailer X-Original-Sender: gouravsingh@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Gourav Singh Reply-To: Gourav Singh Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: zSS79a/oj4kp From: Cedric Hombourger Checks for creator.rootdev not being None were missing and would cause the kernel command line to read "root=None". When using the Discoverable Partitions Specification, we really want no root= parameter on the kernel command line (and root=None is anyhow not a valid option). Signed-off-by: Cedric Hombourger Signed-off-by: Gourav Singh --- meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index 6bc78d42..6c6698d6 100644 --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -104,7 +104,7 @@ class BootimgEFIPlugin(SourcePlugin): (get_bitbake_var("KERNEL_IMAGETYPE"), get_bitbake_var("INITRAMFS_LINK_NAME")) label = source_params.get('label') - label_conf = "root=%s" % creator.rootdev + label_conf = f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label @@ -201,7 +201,8 @@ class BootimgEFIPlugin(SourcePlugin): boot_conf += "linux /%s\n" % kernel label = source_params.get('label') - label_conf = "LABEL=Boot root=%s" % creator.rootdev + label_conf = "LABEL=Boot" + label_conf += f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label @@ -366,7 +367,7 @@ class BootimgEFIPlugin(SourcePlugin): with tempfile.TemporaryDirectory() as tmp_dir: label = source_params.get('label') - label_conf = "root=%s" % creator.rootdev + label_conf = f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label -- 2.39.5 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260408064406.3396423-1-gouravsingh%40siemens.com.