public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/2] testsuite: ensure WicTest actually builds a wic image
Date: Fri, 11 Sep 2026 17:56:58 +0200	[thread overview]
Message-ID: <20260911155659.2440003-2-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20260911155659.2440003-1-felix.moessbauer@siemens.com>

We currently assume that the target we build is a wic image.
This breaks when switching the target. We improve this by explicitly
requesting a wic image when executing this test.

Along that, we fix the misleading error messages: Report what is wrong
instead of what would be right.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 testsuite/cibase.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/testsuite/cibase.py b/testsuite/cibase.py
index c5bc06c3..2cf8448b 100755
--- a/testsuite/cibase.py
+++ b/testsuite/cibase.py
@@ -116,15 +116,21 @@ class CIBaseTest(CIBuilder):
             yaml.dump(cfg, f)
 
     def perform_wic_partition_test(self, targets, wic_deploy_parts, **kwargs):
-        self.configure(targets=targets, wic_deploy_parts=wic_deploy_parts, **kwargs)
+        lines = kwargs.get('lines', [])
+        lines += [
+            'IMAGE_FSTYPES = "wic"',
+            'IMAGER_INSTALL:wic = "${GRUB_BOOTLOADER_INSTALL}"',
+        ]
+        self.configure(targets=targets, wic_deploy_parts=wic_deploy_parts,
+                       lines=lines, **kwargs)
         self.bitbake(targets, **kwargs)
 
         wic_path = f"{self.build_dir}/tmp/deploy/images/*/*.wic.p1"
         partition_files = set(glob.glob(wic_path))
         if wic_deploy_parts and len(partition_files) == 0:
-            self.fail("Found raw wic partitions in DEPLOY_DIR")
-        if not wic_deploy_parts and len(partition_files) != 0:
             self.fail("Did not find raw wic partitions in DEPLOY_DIR")
+        if not wic_deploy_parts and len(partition_files) != 0:
+            self.fail("Found raw wic partitions in DEPLOY_DIR")
 
     def perform_repro_test(self, targets, signed=False, **kwargs):
         keys_dir = os.path.dirname(__file__) + '/keys/base-apt'
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260911155659.2440003-2-felix.moessbauer%40siemens.com.

  reply	other threads:[~2026-09-11 15:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 15:56 [PATCH 0/2] Modernize set of targets we built in the testsuite 'Felix Moessbauer' via isar-users
2026-09-11 15:56 ` 'Felix Moessbauer' via isar-users [this message]
2026-09-11 15:56 ` [PATCH 2/2] testsuite: modernize set of build targets 'Felix Moessbauer' via isar-users
2026-09-18 14:42 ` [PATCH 0/2] Modernize set of targets we built in the testsuite Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911155659.2440003-2-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox