public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/3] debianize: services are named after BPN not PN
Date: Thu, 12 Nov 2026 09:38:57 +0100	[thread overview]
Message-ID: <20261112083859.3152361-2-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20261112083859.3152361-1-felix.moessbauer@siemens.com>

In 09f4698a logic was added to automatically copy triggers and service
files into the debian folder so that they are picked up by debhelper.
However, the services were only looked up under their
${PN}.{service,trigger}, which breaks on variant builds like -native and
-compat.

As the package variant suffix is a bitbake only thing, it must not end
up in the names of the services (neither on lookup, nor on copy-in),
as the debian package is named ${BPN} and the entries must match.

Along that, we fix an incorrect tabs vs. spaces indentation.

Fixes: 09f4698a ("debianize: add support for systemd unit files")
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 .../recipes-bsp/optee-examples/files/debian/control.tmpl    | 2 +-
 meta/classes-recipe/debianize.bbclass                       | 6 +++---
 meta/recipes-bsp/optee-client/files/debian/control.tmpl     | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta-isar/recipes-bsp/optee-examples/files/debian/control.tmpl b/meta-isar/recipes-bsp/optee-examples/files/debian/control.tmpl
index 7533c34a..8b8e4eef 100644
--- a/meta-isar/recipes-bsp/optee-examples/files/debian/control.tmpl
+++ b/meta-isar/recipes-bsp/optee-examples/files/debian/control.tmpl
@@ -1,4 +1,4 @@
-Source: ${PN}
+Source: ${BPN}
 Section: admin
 Priority: optional
 Standards-Version: ${DEBIAN_STANDARDS_VERSION}
diff --git a/meta/classes-recipe/debianize.bbclass b/meta/classes-recipe/debianize.bbclass
index 6f6141b0..e483a52d 100644
--- a/meta/classes-recipe/debianize.bbclass
+++ b/meta/classes-recipe/debianize.bbclass
@@ -206,10 +206,10 @@ deb_debianize() {
 	for f in ${dh_installdeb_handled} \
 			 ${dh_installsystemd_handled} \
 			 ${dh_installsystemduser_handled} \
-	         ${dh_installtmpfiles_handled}
+			 ${dh_installtmpfiles_handled}
 	do
-		if [ -f ${WORKDIR}/${PN}${f} ]; then
-			install -v -m 644 ${WORKDIR}/${PN}${f} ${S}/debian/
+		if [ -f ${WORKDIR}/${BPN}${f} ]; then
+			install -v -m 644 ${WORKDIR}/${BPN}${f} ${S}/debian/
 		fi
 	done
 }
diff --git a/meta/recipes-bsp/optee-client/files/debian/control.tmpl b/meta/recipes-bsp/optee-client/files/debian/control.tmpl
index e3864407..0887c358 100644
--- a/meta/recipes-bsp/optee-client/files/debian/control.tmpl
+++ b/meta/recipes-bsp/optee-client/files/debian/control.tmpl
@@ -1,4 +1,4 @@
-Source: ${PN}
+Source: ${BPN}
 Priority: optional
 Maintainer: Unknown maintainer <unknown@example.com>
 Build-Depends: debhelper-compat (= ${DEBIAN_COMPAT}),
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20261112083859.3152361-2-felix.moessbauer%40siemens.com.

  reply	other threads:[~2026-11-12  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  8:38 [PATCH 0/3] Use BPN instead of PN for package naming 'Felix Moessbauer' via isar-users
2026-11-12  8:38 ` 'Felix Moessbauer' via isar-users [this message]
2026-11-12  8:38 ` [PATCH 2/3] dpkg-raw: do not leak package variants into debian package 'Felix Moessbauer' via isar-users
2026-11-12  8:38 ` [PATCH 3/3] debian templates: name package after BPN instead of PN 'Felix Moessbauer' via isar-users
2026-11-13 15:32 ` [PATCH 0/3] Use BPN instead of PN for package naming Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112083859.3152361-2-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox