public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: tobias.schaffner@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/1] fix(isar-sstate): correctly account number of bytes cleaned
Date: Thu, 19 Nov 2026 10:42:33 +0100	[thread overview]
Message-ID: <20261119094234.3630112-1-felix.moessbauer@siemens.com> (raw)

isar-sstate clean currently reports twice the amount of data that is
actually cleaned: it builds the siginfo set correctly, then mistakenly
applies filters to all_files instead of that set. As a result, old
archives are counted in both deletion lists and their sizes are added
twice.

Fixes: 33ca03c7 ("isar-sstate: add architecture filtering support")
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 scripts/isar-sstate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/isar-sstate b/scripts/isar-sstate
index 36a91134..9064def5 100755
--- a/scripts/isar-sstate
+++ b/scripts/isar-sstate
@@ -766,7 +766,7 @@ def sstate_clean(target, max_age, max_sig_age, verbose, filter, arch, **kwargs):
     archive_files = [f for f in all_files if f.suffix in ['tgz', 'tar.zst']]
     siginfo_files = [f for f in all_files if f.suffix in ['tgz.siginfo', 'tar.zst.siginfo']]
     archive_files = apply_filters(archive_files, filter, arch)
-    siginfo_files = apply_filters(all_files, filter, arch)
+    siginfo_files = apply_filters(siginfo_files, filter, arch)
 
     del_archive_files = [f for f in archive_files if f.age >= max_age_seconds]
     del_archive_hashes = [f.hash for f in del_archive_files]
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20261119094234.3630112-1-felix.moessbauer%40siemens.com.

                 reply	other threads:[~2026-11-19  9:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119094234.3630112-1-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=tobias.schaffner@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox