From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184544729767346176 X-Received: by 2002:a05:6a00:15d5:b0:58e:61e:fe3 with SMTP id o21-20020a056a0015d500b0058e061e0fe3mr2781460pfu.46.1674648464409; Wed, 25 Jan 2023 04:07:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:d34b:b0:196:f81:2760 with SMTP id l11-20020a170902d34b00b001960f812760ls5881756plk.2.-pod-prod-gmail; Wed, 25 Jan 2023 04:07:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXtrP1V/9ZfGa8wcpecrdHl25KL+DTwAqXRSjNKYhLlqvuAPLRgpiOVAq4fQgBxkrf6yBOpA X-Received: by 2002:a05:6a21:7891:b0:ad:79bb:7869 with SMTP id bf17-20020a056a21789100b000ad79bb7869mr47204121pzc.56.1674648463372; Wed, 25 Jan 2023 04:07:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674648463; cv=none; d=google.com; s=arc-20160816; b=myvaiY7JhyVeClle9lGWx6dYM4KON1fnr9BcFvCPjGOMSaV5mIE7o3gcXTGahsF+RK W1urivwDwBT4Dy7MJU4i36rYiXYY3xdHQzrRDD7c3kaUKdGxUiGjo0PhVEclLVb46baL uWwCmmP4f0WqA76rj6QhAdoYNrKMGS9EZsjHjXkcPWsVtTlASe1E0wOrgkycBL90o5Jj Kxh1Kgs6dkrADeQPyC6LERPl8aZyNNUL4gRHOWrRvQBvLpnOGMroEGLK73HCu2l2xt+1 NMZz+iudCRW0L6hh+Z12nBZYFUx8PeEggiiEkDb1Sjge4uAULYE3ej0KEYJ8WS7AioBN fa9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=WjI0pgJBUK0ExVzJzw1wDrVcCPfw/dgOngUF8EiRSxo=; b=rJq5QWN1qzgDmTWnOUJmAahGb6wbpWIPBNW5RoO+snjs7Mxc0vDxN75v3Poarp+aOv 9NGcff0LDLaMpPzcL3nAIKUbVHWEzXrw1G8TP52tMq7yQm0Xy48MQWHjFBku1eliuI12 OFEbXvfC+QRko8dEWppdjns0RUoRGI5eIjmCxIl7uHnbkv7DY7jI3xFS4qIPKLqge71d qJRiR/KZTsVWF0ZQqJ9/5K3Id5ejoVXmMQ5biR5Ol9+tRANNDjUut1vA9pgeuxZDL9tz pssEeIUv9+vraj4mAwshf0ljqkjoli9cQ+Bq9qp/0pqStPe4FZiFxJCpVNL+efudNiIX OyQQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 193-20020a6303ca000000b004d2250a0766si346024pgd.0.2023.01.25.04.07.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jan 2023 04:07:43 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from hp.localnet (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 30PC7b0S026719 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 13:07:38 +0100 From: Uladzimir Bely To: "Roberto A. Foglietta" , isar-users@googlegroups.com Cc: Jan Kiszka Subject: Re: [PATCH] dpkg class set default value for ISAR_CROSS_COMPILE, if missing Date: Wed, 25 Jan 2023 15:07:34 +0300 Message-ID: <2031708.YKUYFuaPT4@hp> In-Reply-To: <77c3fed2-4a48-afe5-cd21-ccbe999bbdbd@siemens.com> References: <77c3fed2-4a48-afe5-cd21-ccbe999bbdbd@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: M8fiTvvKipOB In mail from =D1=81=D1=80=D0=B5=D0=B4=D0=B0, 4 =D1=8F=D0=BD=D0=B2=D0=B0=D1= =80=D1=8F 2023 =D0=B3. 11:27:36 +03 user Jan Kiszka wrote: > On 03.01.23 22:42, Roberto A. Foglietta wrote: > > The variable ISAR_CROSS_COMPILE might not be initialised in the dpkg > > class thus the project fails to build. This sets the default, if missin= g. > >=20 > > Signed-off-by: Roberto A. Foglietta > > --- > >=20 > > meta/classes/dpkg.bbclass | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index bf60a5b..230bac9 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > >=20 > > https://github.com/ilbers/isar/commit/06916be39eb00e9808674231afb0ead03= a52 > > 6bc1 > You must send patches inline, or we can't review things. Exceptionally >=20 > pulling it in here: > > From 06916be39eb00e9808674231afb0ead03a526bc1 Mon Sep 17 00:00:00 2001 > > From: "Roberto A. Foglietta" > > Date: Tue, 3 Jan 2023 22:28:05 +0100 > > Subject: [PATCH] dpkg class set default value for ISAR_CROSS_COMPILE, if > >=20 > > missing > >=20 > > The variable ISAR_CROSS_COMPILE might not be initialised in the dpkg > > class thus the project fail to build. This sets the default, if missing. > >=20 > > Signed-off-by: Roberto A. Foglietta > > --- > >=20 > > meta/classes/dpkg.bbclass | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index bf60a5b..230bac9 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -3,6 +3,8 @@ > >=20 > > inherit dpkg-base > >=20 > > +ISAR_CROSS_COMPILE ?=3D "0" > > + > >=20 > > PACKAGE_ARCH ?=3D "${DISTRO_ARCH}" > > =20 > > DPKG_PREBUILD_ENV_FILE=3D"${WORKDIR}/dpkg_prebuild.env" >=20 > Not sure what saved our ass so far, but the usage of ISAR_CROSS_COMPILE > is way more spread out, so this does not make sense. If we want (and > need) a global default, it should go into isar's bitbake.conf now. That > would also be in line with USE_CCACHE e.g. >=20 > Jan It seems to had worked while `dpkg-base` inherited `buildchroot` which has= =20 ISAR_CROSS_COMPILE ??=3D "0" Now we don't depend on buildchroot in dpkg, so we definitely need this patc= h.=20 But probably, it's better to use weak assignment (??=3D) here like earlier.