Re: [PATCH 4/4] patch: suffix patch files copied to .applied_patches with "~"

[Cedric Hombourger <cedric_hombourger@mentor.com>]

On 10/25/2019 7:15 PM, Jan Kiszka wrote:
> On 21.10.19 13:36, Cedric Hombourger wrote:
>> Hi Henning
>>
>> On 10/21/2019 1:26 PM, Henning Schild wrote:
>>> I think that whole patching keeps the files so we can roll back and i
>>> think Jan wanted to somehow continue working on it using quilt.
>> Ok the last I heard from him is that he felt that the approach he had
>> implemented and upstream'ed was far easier than having to implement
>> something ala Yocto. I guess we can let him comment?
> I was wrong, the current implementation is too broken. You can trigger
> that by patching a tarball archive and then triggering an unpack
> followed by a (re-)patch. That's why we need a mechanism with more
> robust rollback support - i.e. OE quilt.

Ok I can drop this patch for now (no need to change something if we know 
it is broken).

Maybe I can work on this later (possibly after the work I started to 
rework our custom-kernel recipe so that it builds perf, status by the 
way is that the same set of kernel packages than what builddeb generates 
are created with hard-coded settings (for now), next steps are (1) use 
templates (2) generate perf packages). I do not have an ETA because I am 
working on this in parallel to some other activities - sorry for those 
of you waiting on this :)

>
> That said, this suffixing is Debian/Isar-specific and will "only" need
> adjustment when porting the OE patch class over.
>
> Jan
>