From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7280073785777061888 X-Received: by 2002:a1c:f215:0:b0:405:a30:151e with SMTP id s21-20020a1cf215000000b004050a30151emr4340664wmc.12.1696008358332; Fri, 29 Sep 2023 10:25:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1c08:b0:3fe:ef50:e1d8 with SMTP id j8-20020a05600c1c0800b003feef50e1d8ls243063wms.1.-pod-prod-00-eu; Fri, 29 Sep 2023 10:25:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3ESDHh27qvOkVQwJXrtX81DFw06xnRL1W9/mSbHMte5sQyNSNJXbAMp2iPva0ofq78v2A X-Received: by 2002:a05:600c:ca:b0:3fb:c075:b308 with SMTP id u10-20020a05600c00ca00b003fbc075b308mr4273073wmm.12.1696008356339; Fri, 29 Sep 2023 10:25:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696008356; cv=none; d=google.com; s=arc-20160816; b=eJtQgRUeTSzo9yIOUYB5pSFO6kxFb28utn4ReiBUIgS7Ue3XBhB+tPSLKCq2jGvjxs 3ev9zaSs+436SGq6GpvDJbBcs9pRkNlJ5yfooKj6xPoDlaPT8AVlEQTqvRJe2Hy9M/yt Y4a3s2dm3GCA94rTxFmBk0TKvsEFcZNXujP8q4qCDIBptIhZOxINZB1Ia2JUG+9VbfTS XLQEYpZkDlDdO50fPB4ejvVqQPLzcRmurQK+yQO6x21fBYX6BkLk8ePJpx9LUci8eSnH ep11mIzCfQBGKT6J2WqYXt4uY/FWAb7KJBWoiquSucXxVHreAJMBHPneoLP0itGCmxvq H90w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=e4SVRUtXI32KJpkZp0hYfXTp/abl2MHb64d7rF9otPw=; fh=IxbeHM4vWxalf1XNf2rnGcQL+r1v0Lr0C6ICsGNNkYw=; b=zVmSL18He3m4140DspzcHBVvkd7O63Or7Zdj2osvZUikCUBIV/6zJ+GVQ9w7xYudK8 BhPGiYdZxtul0Sg1odf6v2+uvg/T87D780Yk1WRhrQ3PKEYdv9LPhy9Z/h6+00DPEY74 CJjqCNU13UaMozH8RT9AxRpsRFfRiUowCB/7w5d3uq/WbcGi6Wd6zX3x3O9uDKjnLOvI 7RmeFQ3UIlwzsauNExY5NHDFgGmkmwCWBX7zDSar+Jq6EjGI93o6sJEzibFH9qxZMeSZ RR0H6sRgE42FTBZREhaM6bysoO30j+eAFs4bwCInH7PRhenA1tsH/iFCp9WpzlfBdLlx KCOA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id i6-20020a05600c354600b003fc39e1582fsi117347wmq.1.2023.09.29.10.25.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Sep 2023 10:25:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 38THPsKJ000569 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 19:25:55 +0200 Message-ID: <2086e64361cb3fdc602f358e53a27310a182f3f5.camel@ilbers.de> Subject: Re: [PATCH v2] base: Fix HOST_ARCH for native builds From: Uladzimir Bely To: Jan Kiszka , isar-users Date: Fri, 29 Sep 2023 20:25:57 +0300 In-Reply-To: <6c5308f8c43513ce66e462f6125d40009e5f7390.camel@ilbers.de> References: <6c5308f8c43513ce66e462f6125d40009e5f7390.camel@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: lLaM3HwGct5j On Fri, 2023-09-29 at 19:36 +0300, Uladzimir Bely wrote: > On Mon, 2023-09-25 at 13:41 +0200, Jan Kiszka wrote: > > From: Jan Kiszka > >=20 > > HOST_ARCH must be DISTRO_ARCH when we are not cross-building. > > Otherwise, > > recipes that set PACKAGE_ARCH to it will fail in native builds. > >=20 > > Use late expansion for ISAR_CROSS_COMPILE to avoid recursion > > issues. > >=20 > > Signed-off-by: Jan Kiszka > > --- > >=20 > > That "expand=3DFalse" seems to work fine, so let's move forward with > > it. > >=20 > > =C2=A0meta/classes/base.bbclass | 6 ++++-- > > =C2=A01 file changed, 4 insertions(+), 2 deletions(-) > >=20 > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > > index 88004120..8ca089a2 100644 > > --- a/meta/classes/base.bbclass > > +++ b/meta/classes/base.bbclass > > @@ -49,13 +49,15 @@ def oe_import(d): > > =C2=A0# We need the oe module name space early (before INHERITs get > > added) > > =C2=A0OE_IMPORTED :=3D "${@oe_import(d)}" > > =C2=A0 > > -def get_deb_host_arch(): > > +def get_deb_host_arch(d): > > =C2=A0=C2=A0=C2=A0=C2=A0 import subprocess > > +=C2=A0=C2=A0=C2=A0 if d.getVar("ISAR_CROSS_COMPILE", expand=3DFalse) != =3D "1": > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return d.getVar("DISTRO_ARC= H") > > =C2=A0=C2=A0=C2=A0=C2=A0 host_arch =3D subprocess.check_output( > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ["dpkg", "--print-arch= itecture"] > > =C2=A0=C2=A0=C2=A0=C2=A0 ).decode('utf-8').strip() > > =C2=A0=C2=A0=C2=A0=C2=A0 return host_arch > > -HOST_ARCH ??=3D "${@get_deb_host_arch()}" > > +HOST_ARCH ??=3D "${@get_deb_host_arch(d)}" > > =C2=A0HOST_DISTRO ??=3D "${DISTRO}" > > =C2=A0 > > =C2=A0die() { >=20 > For some reason this doesn't properly work for some targets in case > of > cross-compile mode. >=20 > Without patch (default local.conf with ISAR_CROSS_COMPILE set): > ``` > bitbake mc:qemuarm64-focal:isar-image-base -e | grep "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > bitbake mc:rpi-arm64-v8-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > bitbake mc:rpi-arm-v7-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > bitbake mc:stm32mp15x-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > ``` >=20 > With patch: > ``` > bitbake mc:qemuarm64-focal:isar-image-base -e | grep "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > bitbake mc:rpi-arm64-v8-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"amd64" > bitbake mc:rpi-arm-v7-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"armhf" > bitbake mc:stm32mp15x-bullseye:isar-image-base -e | grep > "^HOST_ARCH=3D" > HOST_ARCH=3D"armhf" > ``` >=20 > For some reasons this affects only "armhf" targets... >=20 ... And it looks to be caused by line 69 in "imagetypes.bbclass": ISAR_CROSS_COMPILE:armhf =3D "${@bb.utils.contains('IMAGE_BASETYPES', 'ubifs', '1', '${THIS_ISAR_CROSS_COMPILE}', d)}" With (,"expand=3DFalse") in case of armhf the wrong DISTRO_ARCH value assigned to HOST_ARCH. > As a result, in case of rpi-arm-v7 ${DL_DIR}/deb/debian-bullseye/ has > wrongly imported non-debian packages and second (cached from base- > apt) > build does not work since it can't resolve the dependencies. >=20