From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117959015048413184 X-Received: by 2002:a17:906:2245:b0:715:7c81:e39d with SMTP id 5-20020a170906224500b007157c81e39dmr2224523ejr.262.1657699223474; Wed, 13 Jul 2022 01:00:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:42c7:b0:43a:82dc:c2a2 with SMTP id i7-20020a05640242c700b0043a82dcc2a2ls341823edc.3.gmail; Wed, 13 Jul 2022 01:00:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uiDAu0n3/UfCFLNekPSe1sAH+qJu2Ht5w6SVHPIv4WjrecBagkd0R30BHn91WAK9W8QgMx X-Received: by 2002:a05:6402:3297:b0:43a:9233:23b4 with SMTP id f23-20020a056402329700b0043a923323b4mr3063915eda.397.1657699222202; Wed, 13 Jul 2022 01:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657699222; cv=none; d=google.com; s=arc-20160816; b=jacCTs2hQYOlgKDEeD6fuy6G/0hX8nslFOuXHTXVJ5Bz22/uo8rH57ygzmWuLmUP94 9kXe4WcSV0llfY5Vgml2NtxTK0CgwpHS9MRzjq/d0EUJhGlU0e+mT0VtKuAFvMrx+1eY Gij7/+RWrHgbBeho4rg4O8a9Rg2gLd5D/xUTQDoBDhdffr9Y7G2JkzEGmQT4+uEVXE7e ODtd4nJQLV9AmM9KbF8AwFNzKAbafBJhe79TEAN4Fm+9o7fsJ+tVScHD4oQ61j6QJxEu 3mATdkv8Vq1nZihEuC/TVHlir1SZ56V7c0Rb+A708pd9saZPLFUMs+xYkMHNlRoPPBsF Eibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=SB6YYONN5lYqKN/iokZmk03hhaApJwBzQYWbbp24fVg=; b=mrze0kCqCKIO6XpJx7kHCUvBC550eHjydRa+eHxRZplDrK/Di/TTsa9IKvRohCV6ju kknm1nikDQh9j09bLlrw1+t+Y0FqbAx4vQYFHoIV3HXd+IItUdxBn88KQlt+4kR/LAjl ure4aFagj6r3Owps8C/9jARqtC/bvWzSGRXKLYbdxB0sfaf4epJybsGLiN0WKqundVXr o4V0EcplkxuVTunqDwyIuw2Q9qTHNkQK0YbiCAbPdet2v1QkvuG8UJIw/RDhLkGK5tLu jvtwLBtjc7wZcrcdtVLHD/kkbCPKCGeYDIQqE7HT62QqKz1hr1V9+jH2pCRtZ09kYLlJ lhOQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id jx7-20020a170907760700b0072a6696083bsi385201ejc.2.2022.07.13.01.00.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jul 2022 01:00:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 26D80KKm015905 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 10:00:21 +0200 From: Uladzimir Bely To: isar-users@googlegroups.com, Tobias Schmidl Subject: Re: [PATCH v2 1/1] expand-on-first-boot: Check size before resizing Date: Wed, 13 Jul 2022 11:00:19 +0300 Message-ID: <20990131.4csPzL39Zc@home> In-Reply-To: <20220711081602.81904-2-tobiasschmidl@siemens.com> References: <20220711081602.81904-1-tobiasschmidl@siemens.com> <20220711081602.81904-2-tobiasschmidl@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: neIWZ8mCkPXv In the email from Monday, 11 July 2022 11:16:02 +03 user Tobias Schmidl wrote: > If the disk is too small, resizing might have detrimental effects. > Because of aligning issues, it could happen the the final partition is > _smaller_ than desired, which might lead to an unusable last partition. > > Signed-off-by: Tobias Schmidl > --- > .../files/expand-last-partition.sh | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index c0edde7..0aa1063 100755 > --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -22,6 +22,22 @@ if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then > exit 1 > fi > > +# this value is in blocks. Normally a block has 512 bytes. > +BUFFER_SIZE=32768 > +BOOT_DEV_NAME=${BOOT_DEV##*/} > +DISK_SIZE="$(cat /sys/class/block/"${BOOT_DEV_NAME}"/size)" > +ALL_PARTS_SIZE=0 > +for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"[1-9]*; do While whole device directory in 'sys/class/block' includes all partitions as subfolders, I would change it to +for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"/"${BOOT_DEV_NAME}"*; do It should cover all cases like 'sda/sdaX', 'mmcblk0/mmcblk0pX', 'nvme0/ nvme0pX' and similar. > + PART_SIZE=$(cat "${PARTITION}"/size) > + ALL_PARTS_SIZE=$((ALL_PARTS_SIZE + PART_SIZE)) > +done > + > +MINIMAL_SIZE=$((ALL_PARTS_SIZE + BUFFER_SIZE)) > +if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then > + echo "Disk is practically already full, doing nothing." >&2 > + exit 0 > +fi > + > LAST_PART="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | tail -1 | cut -d ' ' -f > 1)" > > # Transform the partition table as follows: -- Uladzimir Bely