From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users <isar-users@googlegroups.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 0/4] Make adjust_git work in both worlds
Date: Mon, 16 Aug 2021 10:52:59 +0300 [thread overview]
Message-ID: <2143861.vFx2qVVIhK@home> (raw)
In-Reply-To: <6d790e37-a2c8-012f-46b9-3e4ccb0806f2@siemens.com>
In the email from воскресенье, 15 августа 2021 г. 22:02:25 +03 user Jan Kiszka
wrote:
> On 13.08.21 14:40, Uladzimir Bely wrote:
> > When I previously looked at patch.bbclass, I noted, that we don't use it
> > completely.
> >
> > There are some patch_task_patch_prefunc() and patch_task_postfunc() here
> > that are used in OE when PATCHTOOL='git'. But in our case they are never
> > run due to not using PATCH_COMMIT_FUNCTIONS in isar.
> >
> > I suppose (but can't be completely sure without deep look to OE) that
> > prefunc may fix this 'patch is allready applied' issue in OE.
>
> If you can still reproduce the issue, just set PATCH_COMMIT_FUNCTIONS=1
> to check if it has any impact.
>
> Browsing poky and OE-core, I only find devtool setting this var. But
> both aren't using git as patch tool anyway, a downstream layer/recipe
> needs to requests that.
>
> Jan
Yes, I also tried this way.
Actually, enabling PATCH_COMMIT_FUNCTIONS also forces to make some more
changes in patch.bbclass (like sys.path.insert for OE lib path) that makes the
difference increase.
Anyway, even if this set to "1", the problem of patch reapply is still here -
custom patch is going to be applied despite it was already done on previous
build. So, reset to SRC_REV is still required.
--
Uladzimir Bely
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
next prev parent reply other threads:[~2021-08-16 7:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:48 Jan Kiszka
2021-08-12 11:48 ` [PATCH v2 1/4] dpkg-base: Lock do_adjust_git against each other Jan Kiszka
2021-08-13 13:55 ` Henning Schild
2021-08-15 18:55 ` Jan Kiszka
2021-08-26 8:00 ` [PATCH v3 " Jan Kiszka
2021-08-26 8:06 ` Jan Kiszka
2021-08-12 11:48 ` [PATCH v2 2/4] dpkg-base: Make mirror link relative Jan Kiszka
2021-08-13 14:04 ` Henning Schild
2021-08-13 17:49 ` [PATCH] dpkg-base: "unshare" git clones in adjust_git Henning Schild
2021-08-13 20:13 ` [PATCH v2] " Henning Schild
2021-08-13 20:14 ` Henning Schild
2021-08-15 18:55 ` [PATCH] " Jan Kiszka
2021-08-16 11:36 ` Henning Schild
2021-08-16 16:57 ` Jan Kiszka
2021-08-12 11:48 ` [PATCH v2 3/4] Rework do_adjust_git to support inside and outside usage Jan Kiszka
2021-08-12 11:48 ` [PATCH v2 4/4] Revert "dpkg: adjust task order to allow using "git" for patching" Jan Kiszka
2021-08-13 8:31 ` [PATCH v2 0/4] Make adjust_git work in both worlds Uladzimir Bely
2021-08-13 10:13 ` Jan Kiszka
2021-08-13 12:23 ` Uladzimir Bely
2021-08-13 12:28 ` Jan Kiszka
2021-08-13 12:40 ` Uladzimir Bely
2021-08-15 19:02 ` Jan Kiszka
2021-08-16 7:52 ` Uladzimir Bely [this message]
2021-08-16 7:55 ` Jan Kiszka
2021-08-16 8:27 ` Uladzimir Bely
2021-08-16 10:45 ` Jan Kiszka
2021-08-16 11:01 ` Jan Kiszka
2021-08-16 11:26 ` Henning Schild
2021-08-16 12:49 ` Uladzimir Bely
2021-08-19 6:17 ` Uladzimir Bely
2021-08-19 6:21 ` Jan Kiszka
2021-08-26 7:57 ` Jan Kiszka
2021-08-27 8:39 ` ub...@ilbers.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2143861.vFx2qVVIhK@home \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox