From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6995471841453146112 X-Received: by 2002:adf:c549:: with SMTP id s9mr17036812wrf.344.1629100383163; Mon, 16 Aug 2021 00:53:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a191:: with SMTP id u17ls24052wru.3.gmail; Mon, 16 Aug 2021 00:53:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye1t1et0RwYxdBgljJkKymtdINs6KiHotv+sEEbMVTN9n77COoAvDj1oBlTNn0zF/mAESj X-Received: by 2002:a5d:668f:: with SMTP id l15mr17435124wru.390.1629100382071; Mon, 16 Aug 2021 00:53:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629100382; cv=none; d=google.com; s=arc-20160816; b=RGRLEFgI71XcVJjt6xxaRvBWwLcSzsCH/Vu6omqYXCugwyc7hKqEYjB5WEyW60rGnf TdcPxUjyfSirkCGkhuyAaKBdKalPXYH71diC9g2kmdRJCAOwg8iG6LnBNXqzg2K1pK2b 9IrQ2txWOCCXs/WItgsEG4DtU3XDTik/Z/4DaxK4R9XO3mfMYFJdzi/tK5KaiQMWO+nG nNF5q0RvMwAvx+kP3z71auk3pa5D2Wxtr2Cv7+hdDJHISOxRvspTwOmCnNBV15BUtXkA zrQXBvkaNmVBO200dMLcsYlHYGe5zLjdm+ZcF9zDpY6lM40fakZsYBK2u0FkoIdj9a02 mj3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from; bh=2uW337/hRREo431vYuPqkYqiofvHKopPLYMn7L9Z8RA=; b=uN4WiH6NOrU7vurnuX/MJXhVDkQpIbs1OX8Of2eUukSYiztZU8LnlDeLS7ghguRL/p L+ck1luznhcVWjegS7s1Myc7Y2gKjmfYqEbOnFaNo3wdQujapuIRbQm665Jp8RS42Uss E8v+Mj5uCBO4Yqv0yHR5lIsPHvT3Ls241IekYoV0V1JzKowWe8zEoWV6AtRz+WKqjaMV 9gWDYBLgFh99Zb83dtuKQws9WN3BWGEhxwNjlbyZ94XBKkz30RkF4b5/CpSeqojXoYCa HRlDL0sDm92oBZGyyjSKDhKuNOB4Od+xo6iYX5oSkqvBHAvGpUFHqWbjzg8UZxBxRLEb NHRg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id s130si404680wme.0.2021.08.16.00.53.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Aug 2021 00:53:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 17G7r0F5002660 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 09:53:01 +0200 From: Uladzimir Bely To: isar-users , Jan Kiszka Subject: Re: [PATCH v2 0/4] Make adjust_git work in both worlds Date: Mon, 16 Aug 2021 10:52:59 +0300 Message-ID: <2143861.vFx2qVVIhK@home> In-Reply-To: <6d790e37-a2c8-012f-46b9-3e4ccb0806f2@siemens.com> References: <9030e8b4-5a26-42b8-bca4-7e07977044b1n@googlegroups.com> <6d790e37-a2c8-012f-46b9-3e4ccb0806f2@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ybzirGTq3wtt In the email from =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0=BD=D1= =8C=D0=B5, 15 =D0=B0=D0=B2=D0=B3=D1=83=D1=81=D1=82=D0=B0 2021 =D0=B3. 22:02= :25 +03 user Jan Kiszka=20 wrote: > On 13.08.21 14:40, Uladzimir Bely wrote: > > When I previously looked at patch.bbclass, I noted, that we don't use it > > completely. > >=20 > > There are some patch_task_patch_prefunc() and patch_task_postfunc() here > > that are used in OE when PATCHTOOL=3D'git'. But in our case they are ne= ver > > run due to not using PATCH_COMMIT_FUNCTIONS in isar. > >=20 > > I suppose (but can't be completely sure without deep look to OE) that > > prefunc may fix this 'patch is allready applied' issue in OE. >=20 > If you can still reproduce the issue, just set PATCH_COMMIT_FUNCTIONS=3D1 > to check if it has any impact. >=20 > Browsing poky and OE-core, I only find devtool setting this var. But > both aren't using git as patch tool anyway, a downstream layer/recipe > needs to requests that. >=20 > Jan Yes, I also tried this way. Actually, enabling PATCH_COMMIT_FUNCTIONS also forces to make some more=20 changes in patch.bbclass (like sys.path.insert for OE lib path) that makes = the=20 difference increase. Anyway, even if this set to "1", the problem of patch reapply is still here= -=20 custom patch is going to be applied despite it was already done on previous= =20 build. So, reset to SRC_REV is still required. =2D-=20 Uladzimir Bely Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov